Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Randy Witt <randy.e.witt@linux.intel.com>
To: brendan.le.foll@intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] toolchain-shar-extract.sh: explain why we cannot use sudo in extensible SDK
Date: Thu, 20 Aug 2015 12:30:52 -0700	[thread overview]
Message-ID: <55D62AEC.6040606@linux.intel.com> (raw)
In-Reply-To: <1439991165-13121-4-git-send-email-brendan.le.foll@intel.com>

On 08/19/2015 06:32 AM, brendan.le.foll@intel.com wrote:
> From: Brendan Le Foll <brendan.le.foll@intel.com>
>
> Signed-off-by: Brendan Le Foll <brendan.le.foll@intel.com>
> ---
>   meta/files/toolchain-shar-extract.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/files/toolchain-shar-extract.sh b/meta/files/toolchain-shar-extract.sh
> index c4c2a70..d8e714a 100644
> --- a/meta/files/toolchain-shar-extract.sh
> +++ b/meta/files/toolchain-shar-extract.sh
> @@ -135,7 +135,7 @@ mkdir -p $target_sdk_dir >/dev/null 2>&1
>   # if don't have the right to access dir, gain by sudo
>   if [ ! -x $target_sdk_dir -o ! -w $target_sdk_dir -o ! -r $target_sdk_dir ]; then
>   	if [ "$SDK_EXTENSIBLE" = "1" ]; then
> -		echo "Unable to access \"$target_sdk_dir\"."
> +		echo "Unable to access \"$target_sdk_dir\", can\'t install extensible SDK as root."

This is a bit unclear since it makes it sound like the user was trying to 
install as root, which would have already failed if that were the case. Perhaps 
wording it as: "Unable to access $dir, will not attempt to install using sudo, 
because the extensible sdk can't be installed as root."

>   		exit 1
>   	fi
>
>



      reply	other threads:[~2015-08-20 19:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 13:32 Extensible SDK install patch fixes brendan.le.foll
2015-08-19 13:32 ` [PATCH 1/3] toolchain-shar-extract.sh: ensure extensible SDK install path obeys restrictions brendan.le.foll
2015-08-19 13:32 ` [PATCH 2/3] toolchain-shar-extract.sh: better default install path for extensible SDK brendan.le.foll
2015-08-19 17:52   ` Christopher Larson
2015-08-20  7:34     ` Brendan Le Foll
2015-08-20 16:47       ` Christopher Larson
2015-08-19 13:32 ` [PATCH 3/3] toolchain-shar-extract.sh: explain why we cannot use sudo in " brendan.le.foll
2015-08-20 19:30   ` Randy Witt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D62AEC.6040606@linux.intel.com \
    --to=randy.e.witt@linux.intel.com \
    --cc=brendan.le.foll@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox