Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] Add a dummy pointercal calibration for qemu
@ 2015-09-17 13:00 Jussi Kukkonen
  2015-09-17 13:00 ` [PATCH 1/1] xinput-calibrator: Add a dummy calibration file " Jussi Kukkonen
  0 siblings, 1 reply; 6+ messages in thread
From: Jussi Kukkonen @ 2015-09-17 13:00 UTC (permalink / raw)
  To: openembedded-core

xinput_calibrator keeps popping up on every boot (or session start)
when testing Sato image on qemu: This seems to be because qemu
emulates a tablet and is made worse by xinput_calibrator not
actually being able to write xinput files for xorg drivers, so the
problem persists on following boots.

The patch adds a dummy calibration file for "qemuall". I wasn't sure
how this should be done so let me know if there's a better solution.

 - Jussi

The following changes since commit ea562de57590c966cd5a75fda8defecd397e6436:

  qemu: Update to upstream patches (2015-09-14 20:46:40 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib jku/pointercal-xinput
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/pointercal-xinput

Jussi Kukkonen (1):
  xinput-calibrator: Add a dummy calibration file for qemu

 .../xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput      | 2 ++
 meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb    | 6 ++++++
 2 files changed, 8 insertions(+)
 create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput

-- 
2.1.4



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu
  2015-09-17 13:00 [PATCH 0/1] Add a dummy pointercal calibration for qemu Jussi Kukkonen
@ 2015-09-17 13:00 ` Jussi Kukkonen
  2015-09-17 13:23   ` Otavio Salvador
  2015-09-17 15:09   ` Martin Jansa
  0 siblings, 2 replies; 6+ messages in thread
From: Jussi Kukkonen @ 2015-09-17 13:00 UTC (permalink / raw)
  To: openembedded-core

This prevents xinput_calibrator from popping up on every boot in qemu.

Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
---
 .../xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput      | 2 ++
 meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb    | 6 ++++++
 2 files changed, 8 insertions(+)
 create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput

diff --git a/meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
new file mode 100644
index 0000000..a816d6d
--- /dev/null
+++ b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
@@ -0,0 +1,2 @@
+# Dummy pointercal.xinput file to prevent xinput_calibrator
+# from running on qemu startup
diff --git a/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
index 65348c3..cab3d14 100644
--- a/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
+++ b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
@@ -5,8 +5,14 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384
 PR = "r7"
 
 SRC_URI = "file://pointercal.xinput"
+SRC_URI_append_qemuall = " file://pointercal-qemu.xinput"
 S = "${WORKDIR}"
 
+do_install_prepend_qemuall () {
+    install -d ${D}${sysconfdir}/
+    install -m 0644 ${S}/pointercal-qemu.xinput ${D}${sysconfdir}/pointercal.xinput
+}
+
 do_install() {
     # Only install file if it has a contents
     if [ -s ${S}/pointercal.xinput ] &&\
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu
  2015-09-17 13:00 ` [PATCH 1/1] xinput-calibrator: Add a dummy calibration file " Jussi Kukkonen
@ 2015-09-17 13:23   ` Otavio Salvador
  2015-09-17 13:36     ` Jussi Kukkonen
  2015-09-17 15:09   ` Martin Jansa
  1 sibling, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2015-09-17 13:23 UTC (permalink / raw)
  To: Jussi Kukkonen; +Cc: Patches and discussions about the oe-core layer

On Thu, Sep 17, 2015 at 10:00 AM, Jussi Kukkonen
<jussi.kukkonen@intel.com> wrote:
> This prevents xinput_calibrator from popping up on every boot in qemu.
>
> Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>

Why you don't provide a valid calibration for it instead?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu
  2015-09-17 13:23   ` Otavio Salvador
@ 2015-09-17 13:36     ` Jussi Kukkonen
  2015-09-17 13:50       ` Otavio Salvador
  0 siblings, 1 reply; 6+ messages in thread
From: Jussi Kukkonen @ 2015-09-17 13:36 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On 17 September 2015 at 16:23, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:
>
> On Thu, Sep 17, 2015 at 10:00 AM, Jussi Kukkonen
> <jussi.kukkonen@intel.com> wrote:
> > This prevents xinput_calibrator from popping up on every boot in qemu.
> >
> > Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
>
> Why you don't provide a valid calibration for it instead?

xinput_calibrator does not actually work for xorg drivers: it fails to
write the values in xinput format for xorg devices. I was planning on
looking at that as well but since I know very little about these drivers I
was going for the low hanging fruit first...

Also, Ross pointed out that I should just add the file into
meta/recipes-graphics/xinput-calibrator/pointercal-xinput/qemuall/pointercal.xinput
and then the recipe changes become unneeded.

Jussi

[-- Attachment #2: Type: text/html, Size: 1137 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu
  2015-09-17 13:36     ` Jussi Kukkonen
@ 2015-09-17 13:50       ` Otavio Salvador
  0 siblings, 0 replies; 6+ messages in thread
From: Otavio Salvador @ 2015-09-17 13:50 UTC (permalink / raw)
  To: Jussi Kukkonen; +Cc: Patches and discussions about the oe-core layer

On Thu, Sep 17, 2015 at 10:36 AM, Jussi Kukkonen
<jussi.kukkonen@intel.com> wrote:
> On 17 September 2015 at 16:23, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> On Thu, Sep 17, 2015 at 10:00 AM, Jussi Kukkonen
>> <jussi.kukkonen@intel.com> wrote:
>> > This prevents xinput_calibrator from popping up on every boot in qemu.
>> >
>> > Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
>>
>> Why you don't provide a valid calibration for it instead?
>
> xinput_calibrator does not actually work for xorg drivers: it fails to write
> the values in xinput format for xorg devices. I was planning on looking at
> that as well but since I know very little about these drivers I was going
> for the low hanging fruit first...
>
> Also, Ross pointed out that I should just add the file into
> meta/recipes-graphics/xinput-calibrator/pointercal-xinput/qemuall/pointercal.xinput
> and then the recipe changes become unneeded.

This is a workaround, not a fix.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu
  2015-09-17 13:00 ` [PATCH 1/1] xinput-calibrator: Add a dummy calibration file " Jussi Kukkonen
  2015-09-17 13:23   ` Otavio Salvador
@ 2015-09-17 15:09   ` Martin Jansa
  1 sibling, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2015-09-17 15:09 UTC (permalink / raw)
  To: Jussi Kukkonen; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2202 bytes --]

On Thu, Sep 17, 2015 at 04:00:38PM +0300, Jussi Kukkonen wrote:
> This prevents xinput_calibrator from popping up on every boot in qemu.
> 
> Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> ---
>  .../xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput      | 2 ++
>  meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb    | 6 ++++++
>  2 files changed, 8 insertions(+)
>  create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
> 
> diff --git a/meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
> new file mode 100644
> index 0000000..a816d6d
> --- /dev/null
> +++ b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
> @@ -0,0 +1,2 @@
> +# Dummy pointercal.xinput file to prevent xinput_calibrator
> +# from running on qemu startup

NAK

Just put this in qemuall subdirectory and don't change the recipe.

> diff --git a/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
> index 65348c3..cab3d14 100644
> --- a/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
> +++ b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
> @@ -5,8 +5,14 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384
>  PR = "r7"
>  
>  SRC_URI = "file://pointercal.xinput"
> +SRC_URI_append_qemuall = " file://pointercal-qemu.xinput"
>  S = "${WORKDIR}"
>  
> +do_install_prepend_qemuall () {
> +    install -d ${D}${sysconfdir}/
> +    install -m 0644 ${S}/pointercal-qemu.xinput ${D}${sysconfdir}/pointercal.xinput
> +}
> +
>  do_install() {
>      # Only install file if it has a contents
>      if [ -s ${S}/pointercal.xinput ] &&\
> -- 
> 2.1.4
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-17 15:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-17 13:00 [PATCH 0/1] Add a dummy pointercal calibration for qemu Jussi Kukkonen
2015-09-17 13:00 ` [PATCH 1/1] xinput-calibrator: Add a dummy calibration file " Jussi Kukkonen
2015-09-17 13:23   ` Otavio Salvador
2015-09-17 13:36     ` Jussi Kukkonen
2015-09-17 13:50       ` Otavio Salvador
2015-09-17 15:09   ` Martin Jansa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox