[PATCH] staging.bbclass: make already-stripped can be skipped

[PATCH] staging.bbclass: make already-stripped can be skipped

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

Add a check like what we does in package.bbclass
so that the already-stripped QA test can be skipped.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/classes/staging.bbclass | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass
index 967eddd..243bcdf 100644
--- a/meta/classes/staging.bbclass
+++ b/meta/classes/staging.bbclass
@@ -127,7 +127,10 @@ python sysroot_strip () {
                     elf_file = isELF(file)
                     if elf_file & 1:
                         if elf_file & 2:
-                            bb.warn("File '%s' from %s was already stripped, this will prevent future debugging!" % (file[len(dvar):], pn))
+                            if 'already-stripped' in (d.getVar('INSANE_SKIP_' + pn, True) or "").split():
+                                bb.note("Skipping file %s from %s for already-stripped QA test" % (file[len(dvar):], pn))
+                            else:
+                                bb.warn("File '%s' from %s was already stripped, this will prevent future debugging!" % (file[len(dvar):], pn))
                             continue
 
                         if s.st_ino in inodes:
-- 
2.3.5

Re: [PATCH] staging.bbclass: make already-stripped can be skipped

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]

On Wed, Dec 16, 2015 at 05:54:01PM +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> Add a check like what we does in package.bbclass
> so that the already-stripped QA test can be skipped.

Cannot we use package_qa_handle_error function here? So that these
issues end in qa.log and user/distro can easily define how important the
warning is for them?

> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta/classes/staging.bbclass | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass
> index 967eddd..243bcdf 100644
> --- a/meta/classes/staging.bbclass
> +++ b/meta/classes/staging.bbclass
> @@ -127,7 +127,10 @@ python sysroot_strip () {
>                      elf_file = isELF(file)
>                      if elf_file & 1:
>                          if elf_file & 2:
> -                            bb.warn("File '%s' from %s was already stripped, this will prevent future debugging!" % (file[len(dvar):], pn))
> +                            if 'already-stripped' in (d.getVar('INSANE_SKIP_' + pn, True) or "").split():
> +                                bb.note("Skipping file %s from %s for already-stripped QA test" % (file[len(dvar):], pn))
> +                            else:
> +                                bb.warn("File '%s' from %s was already stripped, this will prevent future debugging!" % (file[len(dvar):], pn))
>                              continue
>  
>                          if s.st_ino in inodes:
> -- 
> 2.3.5
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]