From: Martin Jansa <martin.jansa@gmail.com>
To: Andrew Shadura <andrew.shadura@collabora.co.uk>
Cc: OE Core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] cups: update systemd support
Date: Fri, 8 Jan 2016 16:34:51 +0100 [thread overview]
Message-ID: <20160108153451.GA2573@jama> (raw)
In-Reply-To: <5683B790.7000905@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]
On Wed, Dec 30, 2015 at 11:53:04AM +0100, Andrew Shadura wrote:
> On 11/12/15 22:39, Burton, Ross wrote:
> > Sorry for the delay in looking at this. buildhistory-diff reports this:
> >
> > packages/corei7-64-poky-linux/cups/cups: FILELIST: removed
> > "/etc/rc2.d/S81cups /lib/systemd/system/cups.service /etc/rc5.d/S81cups
> > /etc/rc5.d/K36cups /etc/rc0.d/K36cups /etc/rc2.d/K36cups
> > /etc/rc3.d/S81cups /etc/rc3.d/K36cups /lib/systemd/system/cups.socket
> > /lib/systemd/system/cups.path /etc/init.d/cups" added
> > "/lib/systemd/system/org.cups.cupsd.socket
> > /lib/systemd/system/org.cups.cupsd.service
> > /lib/systemd/system/org.cups.cups-lpd@.service
> > /lib/systemd/system/org.cups.cupsd.path
> > /lib/systemd/system/org.cups.cups-lpd.socket"
> >
> > Looks like if systemd is enabled it removes the sysvinit files, but we
> > still need those installed if sysvinit is in DISTRO_FEATURES.
>
> I just had a look at the recipe, and it seems it removes those files on
> its own even without my patch. I guess fixing that makes sense in a
> separate patch then?
My latest bitbake world build shows new QA issue:
cups-2.0.4: cups: Files/directories were installed but not shipped in
any package:
/lib/systemd/system/org.cups.cupsd.path
/lib/systemd/system/org.cups.cupsd.service
/lib/systemd/system/org.cups.cupsd.socket
/lib/systemd/system/org.cups.cups-lpd@.service
/lib/systemd/system/org.cups.cups-lpd.socket
Please set FILES such that these items are packaged. Alternatively if
they are unneeded, avoid installing them or delete them within
do_install.
I'm not sure if it's caused by this change, but it would be good to fix
it.
>
> --
> Cheers,
> Andrew
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2016-01-08 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 17:41 [PATCH] cups: explicitly configure with systemd when needed Andrew Shadura
2015-10-22 10:59 ` Burton, Ross
2015-10-22 11:06 ` Andrew Shadura
2015-10-22 11:20 ` Burton, Ross
2015-10-22 14:00 ` [PATCH v2] cups: update systemd support Andrew Shadura
2015-11-02 14:47 ` Andrew Shadura
[not found] ` <562EAA43.8020604@collabora.co.uk>
2015-11-20 13:48 ` Andrew Shadura
2015-12-11 21:39 ` Burton, Ross
2015-12-30 10:53 ` Andrew Shadura
2016-01-08 15:34 ` Martin Jansa [this message]
2016-01-08 15:37 ` Andrew Shadura
2016-01-18 14:44 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108153451.GA2573@jama \
--to=martin.jansa@gmail.com \
--cc=andrew.shadura@collabora.co.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox