Re: [PATCH v2] cups: update systemd support

[Andrew Shadura <andrew.shadura@collabora.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]

On 08/01/16 16:34, Martin Jansa wrote:
> On Wed, Dec 30, 2015 at 11:53:04AM +0100, Andrew Shadura wrote:
>> > On 11/12/15 22:39, Burton, Ross wrote:
>>> > > Sorry for the delay in looking at this.  buildhistory-diff reports this:
>>> > > 
>>> > > packages/corei7-64-poky-linux/cups/cups: FILELIST: removed
>>> > > "/etc/rc2.d/S81cups /lib/systemd/system/cups.service /etc/rc5.d/S81cups
>>> > > /etc/rc5.d/K36cups /etc/rc0.d/K36cups /etc/rc2.d/K36cups
>>> > > /etc/rc3.d/S81cups /etc/rc3.d/K36cups /lib/systemd/system/cups.socket
>>> > > /lib/systemd/system/cups.path /etc/init.d/cups" added
>>> > > "/lib/systemd/system/org.cups.cupsd.socket
>>> > > /lib/systemd/system/org.cups.cupsd.service
>>> > > /lib/systemd/system/org.cups.cups-lpd@.service
>>> > > /lib/systemd/system/org.cups.cupsd.path
>>> > > /lib/systemd/system/org.cups.cups-lpd.socket"
>>> > > 
>>> > > Looks like if systemd is enabled it removes the sysvinit files, but we
>>> > > still need those installed if sysvinit is in DISTRO_FEATURES.
>> > 
>> > I just had a look at the recipe, and it seems it removes those files on
>> > its own even without my patch. I guess fixing that makes sense in a
>> > separate patch then?
> My latest bitbake world build shows new QA issue:
> 
> cups-2.0.4: cups: Files/directories were installed but not shipped in
> any package:
>   /lib/systemd/system/org.cups.cupsd.path
>   /lib/systemd/system/org.cups.cupsd.service
>   /lib/systemd/system/org.cups.cupsd.socket
>   /lib/systemd/system/org.cups.cups-lpd@.service
>   /lib/systemd/system/org.cups.cups-lpd.socket
> Please set FILES such that these items are packaged. Alternatively if
> they are unneeded, avoid installing them or delete them within
> do_install.
> 
> I'm not sure if it's caused by this change, but it would be good to fix
> it.

Hmm, the whole point of my change is precisely fixing this issue, are
you sure you have applied my patch?


-- 
Cheers,
  Andrew


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]