From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [wic][PATCH 02/15] runqemu: don't use virtio for wic images
Date: Tue, 2 Feb 2016 16:04:26 +0200 [thread overview]
Message-ID: <20160202140426.GA32458@linux.intel.com> (raw)
In-Reply-To: <1454428628.27087.84.camel@linuxfoundation.org>
On Tue, Feb 02, 2016 at 03:57:08PM +0000, Richard Purdie wrote:
> On Tue, 2016-02-02 at 14:55 +0200, Ed Bartosh wrote:
> > On Tue, Feb 02, 2016 at 02:50:19PM +0000, Richard Purdie wrote:
> > > On Tue, 2016-02-02 at 09:27 +0200, Ed Bartosh wrote:
> > > > qemu hands with 'waiting for root device' message during the
> > > > boot of wic images if '-drive if=virtio' option is used.
> > > >
> > > > Removed if=virtio from qemu command line for wic images. This
> > > > should fix above mentioned boot issue.
> > >
> > > Does this not change the command for other image types too?
> > No, it doesn't. This patch changes qemu command line only for wic
> > images.
>
> Sorry, somehow I didn't see the second line in that diff which adds it
> back.
>
> I do worry about creating too many codepaths in this code though. Any
> idea why virtio doesn't work?
I'll look at it and update patchset. Thanks for review!
--
Regards,
Ed
next prev parent reply other threads:[~2016-02-02 16:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 7:27 [wic][PATCH 00/15] Support for wic images in runqemu and oe-selftest Ed Bartosh
2016-02-02 7:27 ` [wic][PATCH 01/15] runqemu: add support for wic images Ed Bartosh
2016-02-02 7:27 ` [wic][PATCH 02/15] runqemu: don't use virtio " Ed Bartosh
2016-02-02 14:50 ` Richard Purdie
2016-02-02 12:55 ` Ed Bartosh
2016-02-02 15:12 ` Burton, Ross
2016-02-02 15:57 ` Richard Purdie
2016-02-02 14:04 ` Ed Bartosh [this message]
2016-02-02 7:27 ` [wic][PATCH 03/15] runqemu: don't set KERNEL " Ed Bartosh
2016-02-02 7:27 ` [wic][PATCH 04/15] runqemu: support path/to/<image>-<machine>.wic Ed Bartosh
2016-02-02 7:27 ` [wic][PATCH 05/15] oe-selftest: remove unused parameter Ed Bartosh
2016-02-02 7:27 ` [wic][PATCH 06/15] qemurunner: add parameter to method 'start' Ed Bartosh
2016-02-02 7:27 ` [wic][PATCH 07/15] oeqa/targetcontrol: make ssh control optional Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 08/15] oeqa/targetcontrol: support wic image type Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 09/15] wic-image-minimal: change IMAGE_FSTYPES Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 10/15] wic-image-minimal: updated .wks to boot by qemu Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 11/15] oe-selftest: add new wic testcase Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 12/15] wic: fix processing of --use-uuid Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 13/15] wic-image-minimal: use uuid for root partition Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 14/15] oe-selftest: pylinted wic tests Ed Bartosh
2016-02-02 7:28 ` [wic][PATCH 15/15] oe-selftest: don't use specific tasks Ed Bartosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202140426.GA32458@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox