[PATCH] inetutils: fix up recent build fails due to phantom empty directory

[PATCH] inetutils: fix up recent build fails due to phantom empty directory

[Paul Gortmaker]

Recently I started getting this error:

| rmdir: failed to remove 'build/tmp/work/core2-64-overc-linux/inetutils/1.9.4-r0/image/usr/lib64': No such file or directory
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_install (log file is located at build/tmp/work/core2-64-overc-linux/inetutils/1.9.4-r0/temp/log.do_install.23373)
ERROR: Task 2 (meta-openembedded/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb, do_install) failed with exit code '1'
NOTE: Tasks Summary: Attempted 818 tasks of which 723 didn't need to be rerun and 1 failed.

Looking at the surrounding code, it seems the empty status of this dir was
always considered optional.  It is unclear to me why it would have just
started to vanish however.

Since it was optional, make the return code from its removal also of
no relevance using a crime I've seen committed in other recipes.

Others are free to dig deeper into the true root cause if their time
permits them to do so.

Cc: Joe MacDonald <joe_macdonald@mentor.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb
index 50aedd30d461..68487eab7d58 100644
--- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb
+++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb
@@ -79,7 +79,7 @@ do_install_append () {
 
     rm -rf ${D}${libexecdir}/
     # remove usr/lib if empty
-    rmdir ${D}${libdir}
+    rmdir ${D}${libdir} || true
 }
 
 PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
-- 
2.1.4

Re: [PATCH] inetutils: fix up recent build fails due to phantom empty directory

[Paul Gortmaker]

[Re: [PATCH] inetutils: fix up recent build fails due to phantom empty directory] On 04/02/2016 (Thu 13:14) Joe MacDonald wrote:

> [[PATCH] inetutils: fix up recent build fails due to phantom empty directory] On 16.01.31 (Sun 14:42) Paul Gortmaker wrote:
> 
> > Recently I started getting this error:
> > 
> > | rmdir: failed to remove 'build/tmp/work/core2-64-overc-linux/inetutils/1.9.4-r0/image/usr/lib64': No such file or directory
> > | WARNING: exit code 1 from a shell command.
> > | ERROR: Function failed: do_install (log file is located at build/tmp/work/core2-64-overc-linux/inetutils/1.9.4-r0/temp/log.do_install.23373)
> > ERROR: Task 2 (meta-openembedded/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb, do_install) failed with exit code '1'
> > NOTE: Tasks Summary: Attempted 818 tasks of which 723 didn't need to be rerun and 1 failed.
> > 
> > Looking at the surrounding code, it seems the empty status of this dir was
> > always considered optional.  It is unclear to me why it would have just
> > started to vanish however.
> > 
> > Since it was optional, make the return code from its removal also of
> > no relevance using a crime I've seen committed in other recipes.
> 
> I meant to respond to this as soon as I saw it, sorry about that.  Do
> you know if this change is functionally any different than adding
> --ignore-fail-on-non-empty to the rmdir command instead of the "|| true"
> thing?  If --ignore-fail corrects the problem for you, I'd rather use
> that.

Turns out that won't work, since it isn't that it is present and
non-empty, but it simply has ceased to exist. (Again, NFI why...)

So, we'd need a "--ignore-fail-on-non-exist" GNUism for this.

P.
--

> 
> -J.
> 
> > Others are free to dig deeper into the true root cause if their time
> > permits them to do so.
> > 
> > Cc: Joe MacDonald <joe_macdonald@mentor.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> >  meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb
> > index 50aedd30d461..68487eab7d58 100644
> > --- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb
> > +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb
> > @@ -79,7 +79,7 @@ do_install_append () {
> >  
> >      rm -rf ${D}${libexecdir}/
> >      # remove usr/lib if empty
> > -    rmdir ${D}${libdir}
> > +    rmdir ${D}${libdir} || true
> >  }
> >  
> >  PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
> -- 
> -Joe MacDonald.
> :wq