Re: [PATCH][RFC] base.bbclass: Introduce EXTRA_CONF_PACKAGECONFIG variable

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]

On Mon, Apr 18, 2016 at 07:49:51PM -0300, Otavio Salvador wrote:
> On Mon, Apr 18, 2016 at 7:45 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Mon, 2016-04-18 at 19:31 -0300, Otavio Salvador wrote:
> >> On Fri, Mar 25, 2016 at 8:55 AM, Martin Jansa <martin.jansa@gmail.com
> >> > wrote:
> >> > Was there some agreement about variable name?
> >>
> >> meta-qt5 5.6 is using this so we need a final decision if it will be
> >> merged or not. I am in favor it as I think it is clear enough.
> >
> > It was an RFC and I still don't get a good feeling about the names
> > used.
> >
> > I suggested:
> >
> > PACKAGECONFIG_CONFPARAMS
> > or
> > PACKAGECONFIG_CONFARGS
> 
> I like CONFARGS.

I'll send patch with PACKAGECONFIG_CONFARGS and wait until it's merged
somewhere, before updating usages of this in other layers (so that I
don't need to redo it again if the name is changed again).

> > as it then makes things slightly clearer these things are coming from
> > PACKAGECONFIG. We have a namespace which is a bit of a mess and I'd
> > prefer to try and improve with new things if we can...
> >
> > The fact meta-qt5 is already using this is bad, it really shouldn't be.
> > We're also very close to the final build of 2.1 right now so this would
> > be a very late change :/.

meta-qt5/master isn't using it, it's only in master-next, because
without this change the builds are broken when people use
openembedded-core/meta/conf/distro/include/no-static-libs.inc
e.g. with default Poky config.

> I think it is a safe change but I am fine in postponing it for 2.2. In
> this case we need to revert the usage of it in meta-qt5 (which I also
> support).

Nothing needs to be reverted, because it wasn't merged in any permanent
layer.

If it doesn't go to 2.1 then I'll leave meta-qt5/krogoth version broken
for Poky builds with no-static-libs.inc.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]