[PATCH] wic: mountpoint is an optional argument

[PATCH] wic: mountpoint is an optional argument

[Maciej Borzecki]

According to wic documentation partition mount point is an optional
argument. Skipping mount point also makes sense in certain
configurations when one needs to specify a partition that is not mounted
by the running system, such as a recovery or a mirror partition (in dual
rootfs setups).

Signed-off-by: Maciej Borzecki <maciej.borzecki@rndity.com>
---
 scripts/lib/wic/ksparser.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/wic/ksparser.py b/scripts/lib/wic/ksparser.py
index 6887a7d02441165d7696318ddd132c739c8121b3..0894e2b199a299fbbed272f2e1c95e9d692e3ab1 100644
--- a/scripts/lib/wic/ksparser.py
+++ b/scripts/lib/wic/ksparser.py
@@ -124,7 +124,7 @@ class KickStart():
         subparsers = parser.add_subparsers()
 
         part = subparsers.add_parser('part')
-        part.add_argument('mountpoint')
+        part.add_argument('mountpoint', nargs='?')
         part.add_argument('--active', action='store_true')
         part.add_argument('--align', type=int)
         part.add_argument("--extra-space", type=sizetype, default=10*1024)
-- 
2.5.0

Re: [PATCH] wic: mountpoint is an optional argument

[Ed Bartosh]

Hi Maciej,

Thank you for the patch! It looks good to me.

Acked-by: Ed Bartosh <ed.bartosh@linux.intel.com>

BTW, the same effect can be achieved by specifying mount point without
leading slash, i.e. part mirror --ondisk sda ....

On Tue, Jul 12, 2016 at 01:37:25PM +0200, Maciej Borzecki wrote:
> According to wic documentation partition mount point is an optional
> argument. Skipping mount point also makes sense in certain
> configurations when one needs to specify a partition that is not mounted
> by the running system, such as a recovery or a mirror partition (in dual
> rootfs setups).
> 
> Signed-off-by: Maciej Borzecki <maciej.borzecki@rndity.com>
> ---
>  scripts/lib/wic/ksparser.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/wic/ksparser.py b/scripts/lib/wic/ksparser.py
> index 6887a7d02441165d7696318ddd132c739c8121b3..0894e2b199a299fbbed272f2e1c95e9d692e3ab1 100644
> --- a/scripts/lib/wic/ksparser.py
> +++ b/scripts/lib/wic/ksparser.py
> @@ -124,7 +124,7 @@ class KickStart():
>          subparsers = parser.add_subparsers()
>  
>          part = subparsers.add_parser('part')
> -        part.add_argument('mountpoint')
> +        part.add_argument('mountpoint', nargs='?')
>          part.add_argument('--active', action='store_true')
>          part.add_argument('--align', type=int)
>          part.add_argument("--extra-space", type=sizetype, default=10*1024)

--
Regards,
Ed