From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wic: Add dosfstools-native mtools-native to dependencies
Date: Wed, 26 Oct 2016 12:27:15 +0300 [thread overview]
Message-ID: <20161026092715.GA2297@linux.intel.com> (raw)
In-Reply-To: <20161026015017.13160-1-raj.khem@gmail.com>
Hi Khem,
On Tue, Oct 25, 2016 at 06:50:17PM -0700, Khem Raj wrote:
> these tools are needed for building wic images for some
> boards e.g. overo/gumstix
NAK
Usage of native tools depends on .wks content: modules, partition types,
etc. Your change will cause unnecessary build activity for some
machines/wks files where those tools are not used.
I'd suggest to put these dependencies to board-dependent meta.
Please, look how it's done for genericx86, beaglebone and edgerouter:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/include/genericx86-common.inc
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/beaglebone.conf
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/edgerouter.conf
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/classes/image_types.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index a7fffbc..be7e38c 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -298,7 +298,7 @@ IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native"
> IMAGE_DEPENDS_ubi = "mtd-utils-native"
> IMAGE_DEPENDS_ubifs = "mtd-utils-native"
> IMAGE_DEPENDS_multiubi = "mtd-utils-native"
> -IMAGE_DEPENDS_wic = "parted-native"
> +IMAGE_DEPENDS_wic = "parted-native dosfstools-native mtools-native"
>
> # This variable is available to request which values are suitable for IMAGE_FSTYPES
> IMAGE_TYPES = " \
> --
> 2.10.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Regards,
Ed
next prev parent reply other threads:[~2016-10-26 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 1:50 [PATCH] wic: Add dosfstools-native mtools-native to dependencies Khem Raj
2016-10-26 9:27 ` Ed Bartosh [this message]
2016-10-26 23:54 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026092715.GA2297@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox