* [PATCH] wic: Add dosfstools-native mtools-native to dependencies
@ 2016-10-26 1:50 Khem Raj
2016-10-26 9:27 ` Ed Bartosh
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2016-10-26 1:50 UTC (permalink / raw)
To: openembedded-core
these tools are needed for building wic images for some
boards e.g. overo/gumstix
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/classes/image_types.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index a7fffbc..be7e38c 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -298,7 +298,7 @@ IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native"
IMAGE_DEPENDS_ubi = "mtd-utils-native"
IMAGE_DEPENDS_ubifs = "mtd-utils-native"
IMAGE_DEPENDS_multiubi = "mtd-utils-native"
-IMAGE_DEPENDS_wic = "parted-native"
+IMAGE_DEPENDS_wic = "parted-native dosfstools-native mtools-native"
# This variable is available to request which values are suitable for IMAGE_FSTYPES
IMAGE_TYPES = " \
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wic: Add dosfstools-native mtools-native to dependencies
2016-10-26 1:50 [PATCH] wic: Add dosfstools-native mtools-native to dependencies Khem Raj
@ 2016-10-26 9:27 ` Ed Bartosh
2016-10-26 23:54 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Ed Bartosh @ 2016-10-26 9:27 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
Hi Khem,
On Tue, Oct 25, 2016 at 06:50:17PM -0700, Khem Raj wrote:
> these tools are needed for building wic images for some
> boards e.g. overo/gumstix
NAK
Usage of native tools depends on .wks content: modules, partition types,
etc. Your change will cause unnecessary build activity for some
machines/wks files where those tools are not used.
I'd suggest to put these dependencies to board-dependent meta.
Please, look how it's done for genericx86, beaglebone and edgerouter:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/include/genericx86-common.inc
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/beaglebone.conf
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/edgerouter.conf
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/classes/image_types.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index a7fffbc..be7e38c 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -298,7 +298,7 @@ IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native"
> IMAGE_DEPENDS_ubi = "mtd-utils-native"
> IMAGE_DEPENDS_ubifs = "mtd-utils-native"
> IMAGE_DEPENDS_multiubi = "mtd-utils-native"
> -IMAGE_DEPENDS_wic = "parted-native"
> +IMAGE_DEPENDS_wic = "parted-native dosfstools-native mtools-native"
>
> # This variable is available to request which values are suitable for IMAGE_FSTYPES
> IMAGE_TYPES = " \
> --
> 2.10.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Regards,
Ed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wic: Add dosfstools-native mtools-native to dependencies
2016-10-26 9:27 ` Ed Bartosh
@ 2016-10-26 23:54 ` Khem Raj
0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2016-10-26 23:54 UTC (permalink / raw)
To: Ed Bartosh; +Cc: Patches and discussions about the oe-core layer
On Wed, Oct 26, 2016 at 2:27 AM, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> Hi Khem,
>
> On Tue, Oct 25, 2016 at 06:50:17PM -0700, Khem Raj wrote:
>> these tools are needed for building wic images for some
>> boards e.g. overo/gumstix
> NAK
>
> Usage of native tools depends on .wks content: modules, partition types,
> etc. Your change will cause unnecessary build activity for some
> machines/wks files where those tools are not used.
>
> I'd suggest to put these dependencies to board-dependent meta.
> Please, look how it's done for genericx86, beaglebone and edgerouter:
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/include/genericx86-common.inc
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/beaglebone.conf
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/edgerouter.conf
>
yes, agreed, I was trying to see if it could be made easy for using
wic out of box but then there
are many machine specific deps would make it futile I guess.
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/classes/image_types.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
>> index a7fffbc..be7e38c 100644
>> --- a/meta/classes/image_types.bbclass
>> +++ b/meta/classes/image_types.bbclass
>> @@ -298,7 +298,7 @@ IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native"
>> IMAGE_DEPENDS_ubi = "mtd-utils-native"
>> IMAGE_DEPENDS_ubifs = "mtd-utils-native"
>> IMAGE_DEPENDS_multiubi = "mtd-utils-native"
>> -IMAGE_DEPENDS_wic = "parted-native"
>> +IMAGE_DEPENDS_wic = "parted-native dosfstools-native mtools-native"
>>
>> # This variable is available to request which values are suitable for IMAGE_FSTYPES
>> IMAGE_TYPES = " \
>> --
>> 2.10.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Regards,
> Ed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-26 23:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 1:50 [PATCH] wic: Add dosfstools-native mtools-native to dependencies Khem Raj
2016-10-26 9:27 ` Ed Bartosh
2016-10-26 23:54 ` Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox