[PATCH] classes/cpan-base: fix for PERLVERSION

[PATCH] classes/cpan-base: fix for PERLVERSION

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

Immediate expansion of get_perl_version() is too early for
PERLVERSION, it will result in 'None' before perl is built
and packages that rely on this veriable fail to work with
the incorrect version.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/classes/cpan-base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/cpan-base.bbclass b/meta/classes/cpan-base.bbclass
index 55ac052..48d53cc 100644
--- a/meta/classes/cpan-base.bbclass
+++ b/meta/classes/cpan-base.bbclass
@@ -36,5 +36,5 @@ def is_target(d):
 
 PERLLIBDIRS = "${libdir}/perl"
 PERLLIBDIRS_class-native = "${libdir}/perl-native"
-PERLVERSION := "${@get_perl_version(d)}"
+PERLVERSION = "${@get_perl_version(d)}"
 PERLVERSION[vardepvalue] = ""
-- 
2.8.3

Re: [PATCH] classes/cpan-base: fix for PERLVERSION

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

On 9 November 2016 at 05:51, <jackie.huang@windriver.com> wrote:

> -PERLVERSION := "${@get_perl_version(d)}"
> +PERLVERSION = "${@get_perl_version(d)}"
>

This uses := as the get_perl_version is a non-trivial amount of python
which doesn't need to be re-evaluated all the time.  Have you looked at how
bad the performance hit is, and whether there is an alternative?

Ross

[-- Attachment #2: Type: text/html, Size: 909 bytes --]

Re: [PATCH] classes/cpan-base: fix for PERLVERSION

[Huang, Jie (Jackie)]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

Yes, I can fix it in the recipe that uses PERLVERSION as an alternative.

Thanks,
Jackie

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Monday, December 05, 2016 11:34 PM
To: Huang, Jie (Jackie)
Cc: OE-core
Subject: Re: [OE-core] [PATCH] classes/cpan-base: fix for PERLVERSION


On 9 November 2016 at 05:51, <jackie.huang@windriver.com<mailto:jackie.huang@windriver.com>> wrote:
-PERLVERSION := "${@get_perl_version(d)}"
+PERLVERSION = "${@get_perl_version(d)}"

This uses := as the get_perl_version is a non-trivial amount of python which doesn't need to be re-evaluated all the time.  Have you looked at how bad the performance hit is, and whether there is an alternative?

Ross

[-- Attachment #2: Type: text/html, Size: 4165 bytes --]