* [PATCH] apt-package: Include maintenance scripts
@ 2016-11-16 16:33 Linus Wallgren
2016-11-17 22:16 ` Aníbal Limón
0 siblings, 1 reply; 5+ messages in thread
From: Linus Wallgren @ 2016-11-16 16:33 UTC (permalink / raw)
To: openembedded-core; +Cc: Linus Wallgren
Apt can run multiple tasks daily, such as for example clean, update,
autoclean, unattended-upgrades etc.
[YOCTO #10669]
Signed-off-by: Linus Wallgren <linus.wallgren@scypho.com>
---
meta/recipes-devtools/apt/apt-package.inc | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/apt/apt-package.inc b/meta/recipes-devtools/apt/apt-package.inc
index a553aa2..38cd558 100644
--- a/meta/recipes-devtools/apt/apt-package.inc
+++ b/meta/recipes-devtools/apt/apt-package.inc
@@ -32,13 +32,19 @@ FILES_${PN} = "${bindir}/apt-cdrom ${bindir}/apt-get \
${bindir}/apt-config ${bindir}/apt-cache \
${libdir}/apt ${libdir}/libapt*.so.* \
${localstatedir} ${sysconfdir} \
- ${libdir}/dpkg"
+ ${libdir}/dpkg \
+ ${systemd_unitdir}/system \
+ "
FILES_${PN}-utils = "${bindir}/apt-sortpkgs ${bindir}/apt-extracttemplates"
FILES_${PN}-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-manpages', True))} \
${docdir}/apt"
FILES_${PN}-utils-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-utils-manpages', True))}"
FILES_${PN}-dev = "${libdir}/libapt*.so ${includedir}"
+inherit systemd
+
+SYSTEMD_SERVICE_${PN} = "apt-daily.timer"
+
do_install () {
set -x
install -d ${D}${bindir}
@@ -75,4 +81,11 @@ do_install () {
install -d ${D}${includedir}/apt-pkg/
install -m 0644 include/apt-pkg/*.h ${D}${includedir}/apt-pkg/
+
+ install -d ${D}${systemd_unitdir}/system/
+ install -m 0644 ${S}/debian/apt.systemd.daily ${D}/usr/lib/apt/
+ install -m 0644 ${S}/debian/apt-daily.service ${D}${systemd_unitdir}/system/
+ install -m 0644 ${S}/debian/apt-daily.timer ${D}${systemd_unitdir}/system/
+ install -d ${D}${sysconfdir}/cron.daily/
+ install -m 0755 ${S}/debian/apt.apt-compat.cron.daily ${D}${sysconfdir}/cron.daily/
}
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] apt-package: Include maintenance scripts
2016-11-16 16:33 [PATCH] apt-package: Include maintenance scripts Linus Wallgren
@ 2016-11-17 22:16 ` Aníbal Limón
2016-11-19 14:06 ` Andreas Oberritter
0 siblings, 1 reply; 5+ messages in thread
From: Aníbal Limón @ 2016-11-17 22:16 UTC (permalink / raw)
To: Linus Wallgren, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]
Hi Linus,
Your patch looks good, only missing one thing you need to conditional
those lines to only work when systemd is enabled in DISTRO_FEATURES, see
example:
http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-support/consolekit/consolekit_0.4.6.bb#n26
Thanks in advance,
alimon
On 11/16/2016 10:33 AM, Linus Wallgren wrote:
> Apt can run multiple tasks daily, such as for example clean, update,
> autoclean, unattended-upgrades etc.
>
> [YOCTO #10669]
>
> Signed-off-by: Linus Wallgren <linus.wallgren@scypho.com>
> ---
> meta/recipes-devtools/apt/apt-package.inc | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/apt/apt-package.inc b/meta/recipes-devtools/apt/apt-package.inc
> index a553aa2..38cd558 100644
> --- a/meta/recipes-devtools/apt/apt-package.inc
> +++ b/meta/recipes-devtools/apt/apt-package.inc
> @@ -32,13 +32,19 @@ FILES_${PN} = "${bindir}/apt-cdrom ${bindir}/apt-get \
> ${bindir}/apt-config ${bindir}/apt-cache \
> ${libdir}/apt ${libdir}/libapt*.so.* \
> ${localstatedir} ${sysconfdir} \
> - ${libdir}/dpkg"
> + ${libdir}/dpkg \
> + ${systemd_unitdir}/system \
> + "
> FILES_${PN}-utils = "${bindir}/apt-sortpkgs ${bindir}/apt-extracttemplates"
> FILES_${PN}-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-manpages', True))} \
> ${docdir}/apt"
> FILES_${PN}-utils-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-utils-manpages', True))}"
> FILES_${PN}-dev = "${libdir}/libapt*.so ${includedir}"
>
> +inherit systemd
> +
> +SYSTEMD_SERVICE_${PN} = "apt-daily.timer"
> +
> do_install () {
> set -x
> install -d ${D}${bindir}
> @@ -75,4 +81,11 @@ do_install () {
>
> install -d ${D}${includedir}/apt-pkg/
> install -m 0644 include/apt-pkg/*.h ${D}${includedir}/apt-pkg/
> +
> + install -d ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt.systemd.daily ${D}/usr/lib/apt/
> + install -m 0644 ${S}/debian/apt-daily.service ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt-daily.timer ${D}${systemd_unitdir}/system/
> + install -d ${D}${sysconfdir}/cron.daily/
> + install -m 0755 ${S}/debian/apt.apt-compat.cron.daily ${D}${sysconfdir}/cron.daily/
> }
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] apt-package: Include maintenance scripts
2016-11-17 22:16 ` Aníbal Limón
@ 2016-11-19 14:06 ` Andreas Oberritter
2016-11-21 20:57 ` [PATCHv2] " Linus Wallgren
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Oberritter @ 2016-11-19 14:06 UTC (permalink / raw)
To: Aníbal Limón, Linus Wallgren, openembedded-core
On 17.11.2016 23:16, Aníbal Limón wrote:
> Your patch looks good, only missing one thing you need to conditional
> those lines to only work when systemd is enabled in DISTRO_FEATURES, see
> example:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-support/consolekit/consolekit_0.4.6.bb#n26
No, because systemd.bbclass, which consolekit doesn't inherit, deletes
all files in systemd_unitdir if systemd is not in distro features.
> On 11/16/2016 10:33 AM, Linus Wallgren wrote:
>> Apt can run multiple tasks daily, such as for example clean, update,
>> autoclean, unattended-upgrades etc.
>>
>> [YOCTO #10669]
>>
>> Signed-off-by: Linus Wallgren <linus.wallgren@scypho.com>
>> ---
>> meta/recipes-devtools/apt/apt-package.inc | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/apt/apt-package.inc b/meta/recipes-devtools/apt/apt-package.inc
>> index a553aa2..38cd558 100644
>> --- a/meta/recipes-devtools/apt/apt-package.inc
>> +++ b/meta/recipes-devtools/apt/apt-package.inc
>> @@ -32,13 +32,19 @@ FILES_${PN} = "${bindir}/apt-cdrom ${bindir}/apt-get \
>> ${bindir}/apt-config ${bindir}/apt-cache \
>> ${libdir}/apt ${libdir}/libapt*.so.* \
>> ${localstatedir} ${sysconfdir} \
>> - ${libdir}/dpkg"
>> + ${libdir}/dpkg \
>> + ${systemd_unitdir}/system \
>> + "
>> FILES_${PN}-utils = "${bindir}/apt-sortpkgs ${bindir}/apt-extracttemplates"
>> FILES_${PN}-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-manpages', True))} \
>> ${docdir}/apt"
>> FILES_${PN}-utils-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-utils-manpages', True))}"
>> FILES_${PN}-dev = "${libdir}/libapt*.so ${includedir}"
>>
>> +inherit systemd
>> +
>> +SYSTEMD_SERVICE_${PN} = "apt-daily.timer"
>> +
>> do_install () {
>> set -x
>> install -d ${D}${bindir}
>> @@ -75,4 +81,11 @@ do_install () {
>>
>> install -d ${D}${includedir}/apt-pkg/
>> install -m 0644 include/apt-pkg/*.h ${D}${includedir}/apt-pkg/
>> +
>> + install -d ${D}${systemd_unitdir}/system/
>> + install -m 0644 ${S}/debian/apt.systemd.daily ${D}/usr/lib/apt/
>> + install -m 0644 ${S}/debian/apt-daily.service ${D}${systemd_unitdir}/system/
>> + install -m 0644 ${S}/debian/apt-daily.timer ${D}${systemd_unitdir}/system/
>> + install -d ${D}${sysconfdir}/cron.daily/
>> + install -m 0755 ${S}/debian/apt.apt-compat.cron.daily ${D}${sysconfdir}/cron.daily/
>> }
>>
Please consider using tabs for consistency with the rest of the recipe.
Regards,
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv2] apt-package: Include maintenance scripts
2016-11-19 14:06 ` Andreas Oberritter
@ 2016-11-21 20:57 ` Linus Wallgren
2016-11-22 20:26 ` Aníbal Limón
0 siblings, 1 reply; 5+ messages in thread
From: Linus Wallgren @ 2016-11-21 20:57 UTC (permalink / raw)
To: openembedded-core; +Cc: Linus Wallgren
Apt can run multiple tasks daily, such as for example clean, update,
autoclean, unattended-upgrades etc.
[YOCTO #10669]
Signed-off-by: Linus Wallgren <linus.wallgren@scypho.com>
---
meta/recipes-devtools/apt/apt-package.inc | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/apt/apt-package.inc b/meta/recipes-devtools/apt/apt-package.inc
index a553aa2..c17048a 100644
--- a/meta/recipes-devtools/apt/apt-package.inc
+++ b/meta/recipes-devtools/apt/apt-package.inc
@@ -32,13 +32,19 @@ FILES_${PN} = "${bindir}/apt-cdrom ${bindir}/apt-get \
${bindir}/apt-config ${bindir}/apt-cache \
${libdir}/apt ${libdir}/libapt*.so.* \
${localstatedir} ${sysconfdir} \
- ${libdir}/dpkg"
+ ${libdir}/dpkg \
+ ${systemd_unitdir}/system \
+ "
FILES_${PN}-utils = "${bindir}/apt-sortpkgs ${bindir}/apt-extracttemplates"
FILES_${PN}-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-manpages', True))} \
${docdir}/apt"
FILES_${PN}-utils-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-utils-manpages', True))}"
FILES_${PN}-dev = "${libdir}/libapt*.so ${includedir}"
+inherit systemd
+
+SYSTEMD_SERVICE_${PN} = "apt-daily.timer"
+
do_install () {
set -x
install -d ${D}${bindir}
@@ -75,4 +81,11 @@ do_install () {
install -d ${D}${includedir}/apt-pkg/
install -m 0644 include/apt-pkg/*.h ${D}${includedir}/apt-pkg/
+
+ install -d ${D}${systemd_unitdir}/system/
+ install -m 0644 ${S}/debian/apt.systemd.daily ${D}/usr/lib/apt/
+ install -m 0644 ${S}/debian/apt-daily.service ${D}${systemd_unitdir}/system/
+ install -m 0644 ${S}/debian/apt-daily.timer ${D}${systemd_unitdir}/system/
+ install -d ${D}${sysconfdir}/cron.daily/
+ install -m 0755 ${S}/debian/apt.apt-compat.cron.daily ${D}${sysconfdir}/cron.daily/
}
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCHv2] apt-package: Include maintenance scripts
2016-11-21 20:57 ` [PATCHv2] " Linus Wallgren
@ 2016-11-22 20:26 ` Aníbal Limón
0 siblings, 0 replies; 5+ messages in thread
From: Aníbal Limón @ 2016-11-22 20:26 UTC (permalink / raw)
To: Linus Wallgren, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2087 bytes --]
On 11/21/2016 02:57 PM, Linus Wallgren wrote:
> Apt can run multiple tasks daily, such as for example clean, update,
> autoclean, unattended-upgrades etc.
>
> [YOCTO #10669]
>
> Signed-off-by: Linus Wallgren <linus.wallgren@scypho.com>
Acked-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> meta/recipes-devtools/apt/apt-package.inc | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/apt/apt-package.inc b/meta/recipes-devtools/apt/apt-package.inc
> index a553aa2..c17048a 100644
> --- a/meta/recipes-devtools/apt/apt-package.inc
> +++ b/meta/recipes-devtools/apt/apt-package.inc
> @@ -32,13 +32,19 @@ FILES_${PN} = "${bindir}/apt-cdrom ${bindir}/apt-get \
> ${bindir}/apt-config ${bindir}/apt-cache \
> ${libdir}/apt ${libdir}/libapt*.so.* \
> ${localstatedir} ${sysconfdir} \
> - ${libdir}/dpkg"
> + ${libdir}/dpkg \
> + ${systemd_unitdir}/system \
> + "
> FILES_${PN}-utils = "${bindir}/apt-sortpkgs ${bindir}/apt-extracttemplates"
> FILES_${PN}-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-manpages', True))} \
> ${docdir}/apt"
> FILES_${PN}-utils-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-utils-manpages', True))}"
> FILES_${PN}-dev = "${libdir}/libapt*.so ${includedir}"
>
> +inherit systemd
> +
> +SYSTEMD_SERVICE_${PN} = "apt-daily.timer"
> +
> do_install () {
> set -x
> install -d ${D}${bindir}
> @@ -75,4 +81,11 @@ do_install () {
>
> install -d ${D}${includedir}/apt-pkg/
> install -m 0644 include/apt-pkg/*.h ${D}${includedir}/apt-pkg/
> +
> + install -d ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt.systemd.daily ${D}/usr/lib/apt/
> + install -m 0644 ${S}/debian/apt-daily.service ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt-daily.timer ${D}${systemd_unitdir}/system/
> + install -d ${D}${sysconfdir}/cron.daily/
> + install -m 0755 ${S}/debian/apt.apt-compat.cron.daily ${D}${sysconfdir}/cron.daily/
> }
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-22 20:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 16:33 [PATCH] apt-package: Include maintenance scripts Linus Wallgren
2016-11-17 22:16 ` Aníbal Limón
2016-11-19 14:06 ` Andreas Oberritter
2016-11-21 20:57 ` [PATCHv2] " Linus Wallgren
2016-11-22 20:26 ` Aníbal Limón
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox