* [PATCH] gcr: add missing dependencies for vapi
@ 2016-12-10 2:56 jackie.huang
2016-12-10 10:42 ` Burton, Ross
0 siblings, 1 reply; 3+ messages in thread
From: jackie.huang @ 2016-12-10 2:56 UTC (permalink / raw)
To: openembedded-core
From: Jackie Huang <jackie.huang@windriver.com>
According to the vapi_DEPS definition:
gcr-3.vapi depends on gck-1.vapi,
gcr-ui-3.vapi depends on gck-1.vapi and gcr-3.vapi
But these dependencies are missing for the make targets,
so it will fail when build in parallel:
error: Package `gck-1' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `gcr-3' not found in specified Vala API directories or GObject-Introspection GIR directories
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
.../gcr-add-missing-dependencies-for-vapi.patch | 51 ++++++++++++++++++++++
meta/recipes-gnome/gcr/gcr_3.20.0.bb | 2 +
2 files changed, 53 insertions(+)
create mode 100644 meta/recipes-gnome/gcr/files/gcr-add-missing-dependencies-for-vapi.patch
diff --git a/meta/recipes-gnome/gcr/files/gcr-add-missing-dependencies-for-vapi.patch b/meta/recipes-gnome/gcr/files/gcr-add-missing-dependencies-for-vapi.patch
new file mode 100644
index 0000000..4b95103
--- /dev/null
+++ b/meta/recipes-gnome/gcr/files/gcr-add-missing-dependencies-for-vapi.patch
@@ -0,0 +1,51 @@
+From e7e0c56ca82031121f192f7f711b78418b154c9f Mon Sep 17 00:00:00 2001
+From: Jackie Huang <jackie.huang@windriver.com>
+Date: Mon, 28 Nov 2016 10:17:34 +0800
+Subject: [PATCH] gcr: add missing dependencies for vapi
+
+According to the vapi_DEPS definition:
+gcr-3.vapi depends on gck-1.vapi,
+gcr-ui-3.vapi depends on gck-1.vapi and gcr-3.vapi
+
+But these dependencies are missing for the make targets,
+so it will fail when build in parallel:
+error: Package `gck-1' not found in specified Vala API directories or GObject-Introspection GIR directories
+error: Package `gcr-3' not found in specified Vala API directories or GObject-Introspection GIR directories
+
+Upstream-Status: Submitted [https://github.com/GNOME/gcr/pull/4]
+
+Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
+---
+ gcr/Makefile.am | 2 +-
+ ui/Makefile.am | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/gcr/Makefile.am b/gcr/Makefile.am
+index eda302f..6e78dba 100644
+--- a/gcr/Makefile.am
++++ b/gcr/Makefile.am
+@@ -221,7 +221,7 @@ gir_DATA += Gcr-@GCR_MAJOR@.gir
+
+ if ENABLE_VAPIGEN
+
+-gcr-@GCR_MAJOR@.vapi: Gcr-@GCR_MAJOR@.gir gcr/Gcr-@GCR_MAJOR@.metadata gcr-@GCR_MAJOR@.deps
++gcr-@GCR_MAJOR@.vapi: Gcr-@GCR_MAJOR@.gir gcr/Gcr-@GCR_MAJOR@.metadata gcr-@GCR_MAJOR@.deps gck-@GCK_MAJOR@.vapi
+
+ VAPIGEN_VAPIS += gcr-@GCR_MAJOR@.vapi
+
+diff --git a/ui/Makefile.am b/ui/Makefile.am
+index aa52476..6612f0d 100644
+--- a/ui/Makefile.am
++++ b/ui/Makefile.am
+@@ -160,7 +160,7 @@ gir_DATA += GcrUi-@GCR_MAJOR@.gir
+
+ if ENABLE_VAPIGEN
+
+-gcr-ui-@GCR_MAJOR@.vapi: GcrUi-@GCR_MAJOR@.gir ui/GcrUi-@GCR_MAJOR@.metadata gcr-ui-@GCR_MAJOR@.deps
++gcr-ui-@GCR_MAJOR@.vapi: GcrUi-@GCR_MAJOR@.gir ui/GcrUi-@GCR_MAJOR@.metadata gcr-ui-@GCR_MAJOR@.deps gck-@GCK_MAJOR@.vapi gcr-@GCR_MAJOR@.vapi
+
+ VAPIGEN_VAPIS += gcr-ui-@GCR_MAJOR@.vapi
+
+--
+2.8.3
+
diff --git a/meta/recipes-gnome/gcr/gcr_3.20.0.bb b/meta/recipes-gnome/gcr/gcr_3.20.0.bb
index b32a455..2088902 100644
--- a/meta/recipes-gnome/gcr/gcr_3.20.0.bb
+++ b/meta/recipes-gnome/gcr/gcr_3.20.0.bb
@@ -11,6 +11,8 @@ inherit autotools gnomebase gtk-icon-cache gtk-doc distro_features_check upstrea
# depends on gtk+3, but also x11 through gtk+-x11
REQUIRED_DISTRO_FEATURES = "x11"
+SRC_URI += "file://gcr-add-missing-dependencies-for-vapi.patch"
+
SRC_URI[archive.md5sum] = "4314bf89eac293dd0a9d806593ff1b35"
SRC_URI[archive.sha256sum] = "90572c626d8a708225560c42b4421f7941315247fa1679d4ef569bde7f4bb379"
--
2.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gcr: add missing dependencies for vapi
2016-12-10 2:56 [PATCH] gcr: add missing dependencies for vapi jackie.huang
@ 2016-12-10 10:42 ` Burton, Ross
2016-12-12 0:58 ` Huang, Jie (Jackie)
0 siblings, 1 reply; 3+ messages in thread
From: Burton, Ross @ 2016-12-10 10:42 UTC (permalink / raw)
To: jackie.huang@windriver.com; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
On 10 December 2016 at 02:56, <jackie.huang@windriver.com> wrote:
> +Upstream-Status: Submitted [https://github.com/GNOME/gcr/pull/4]
>
Did you get the message that GNOME doesn't take pull requests at github?
Ross
[-- Attachment #2: Type: text/html, Size: 731 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gcr: add missing dependencies for vapi
2016-12-10 10:42 ` Burton, Ross
@ 2016-12-12 0:58 ` Huang, Jie (Jackie)
0 siblings, 0 replies; 3+ messages in thread
From: Huang, Jie (Jackie) @ 2016-12-12 0:58 UTC (permalink / raw)
To: BURTON, ROSS; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
Yes, I will re-send the patch.
Thanks,
Jackie
From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Saturday, December 10, 2016 6:43 PM
To: Huang, Jie (Jackie)
Cc: OE-core
Subject: Re: [OE-core] [PATCH] gcr: add missing dependencies for vapi
On 10 December 2016 at 02:56, <jackie.huang@windriver.com<mailto:jackie.huang@windriver.com>> wrote:
+Upstream-Status: Submitted [https://github.com/GNOME/gcr/pull/4]
Did you get the message that GNOME doesn't take pull requests at github?
Ross
[-- Attachment #2: Type: text/html, Size: 3999 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-12 0:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-10 2:56 [PATCH] gcr: add missing dependencies for vapi jackie.huang
2016-12-10 10:42 ` Burton, Ross
2016-12-12 0:58 ` Huang, Jie (Jackie)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox