Re: [PATCH] wic: Prevent duplicate entries on fstab

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Mon, Mar 06, 2017 at 11:00:59AM -0300, Fabio Berton wrote:
> Same error with poky-contrib:ed/wic/wip, we need to add --fstype= to
> part /boot line in all wks files.
> 
Only if we want boot partitions to be added to fstab. Currently / and
/boot partitions are not added. Why do we want to change this?

BTW, your patch will make wic to parse the same fstab file several
times. Can you change this, please?

> 
> On 03/03/2017 10:49 AM, Burton, Ross wrote:
> >
> >On 3 March 2017 at 12:12, Fabio Berton
> ><fabio.berton@ossystems.com.br
> ><mailto:fabio.berton@ossystems.com.br>> wrote:
> >
> >    Sorry for delay. This error for qemux86 is because common.wks.inc
> >    and directdisk-gpt.wks files in scripts/lib/wic/canned-wks
> >    directory doesn't have option --fstype= for part /boot.
> >
> >    For qemuarm machines I get the error:
> >
> >    | DEBUG: Executing python function set_image_size
> >    | DEBUG: Python function set_image_size finished
> >    | DEBUG: Executing shell function do_image_wic
> >    | Error: Please build syslinux first
> >
> >
> >There's patches queued that will change the behaviour here and
> >likely cause your patch to not apply - can you rebase on top of
> >poky-contrib:ed/wic/wip and see what happens?  The build
> >dependency is now wic-tools.
> >
> >Ross
> 

> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
--
Regards,
Ed