Re: [PATCH] wic: Prevent duplicate entries on fstab

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Mon, Mar 06, 2017 at 03:48:00PM -0300, Fabio Berton wrote:
> Hi Ed,
> 
> The main motivation to my patch is prevent to duplicate entries. For
> example, if I add to my fstab line:
> 
> LABEL=data           /data                auto defaults              0  1
> 
> and add to wsk file:
> 
> part /data --ondisk mmcblk0 --fstype=ext4 --label data --align 8192
> --size 500M --extra-space 0
> 
> Final fstab will have two entries for /data.
This can be easily avoided if you remove leading slash:
part data --ondisk mmcblk0 --fstype=ext4 --label data --align 8192 --size 500M --extra-space 0


> 
> In most Linux distros mount /boot partition, if we have kernel image
> or boot script to update we need to mount /boot partition. Why the
> reason to not mount /boot?
>
The code that skips / and /boot was brought to wic codebase more than 4
years ago: https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=75c143a7aef46ecea07cf33edd2b1a0192e10149

I don't know exact reason to be honest. However, I think we need to be careful with this
kind of legacy. It doesn't mean we shouldn't remove it, but it should
not be done as a side effect of the patch addressing absolutely
different issue, I believe.

> >>>    For qemuarm machines I get the error:
> >>>
> >>>    | DEBUG: Executing python function set_image_size
> >>>    | DEBUG: Python function set_image_size finished
> >>>    | DEBUG: Executing shell function do_image_wic
> >>>    | Error: Please build syslinux first

Sorry, missed this. It looks like you're trying to use plugin that
depends on syslinux. For example, directdisk.wks uses bootimg-pcbios,
which uses syslinux. It's x86 specific and should not be used on arm.

--
Regards,
Ed