Re: [Openembedded-architecture] [PATCH] meta: start to ignore the largefile distro feature

[Khem Raj <raj.khem@gmail.com>]

On 17-03-07 10:35:58, Burton, Ross wrote:
> CCing openembedded-architecture to open the field for comments.
> 
> On 7 March 2017 at 04:58, Andre McCurdy <armccurdy@gmail.com> wrote:
> 
> > The largefile distro feature has been enabled by default in oe-core
> > for a long time and, more recently, also in poky-tiny. Building
> > without the largefile distro feature receives little or no testing.
> > Many packages now enable LFS without exposing a configure option, so
> > there should be very little expectation that disabling the distro
> > feature will result in a distro which globally disables LFS.
> >
> 
> So I've had a bug for this for some time but have never got around to it.
> 
> If we're going to assert "LFS by default" do we want a sanity check to
> verify it was used?
> 
> Do we want to put -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 in the default
> CFLAGS?

I think this is fine to assert, however, there might be applications which
still want to use --enable/--disable autoconf stuff, and ignore/override the
env settings we might pass, so we need to watch
out for those. Otherwise, this seems a step in right direction.

> 
> I'm not aware of any good reason to not use LFS, but now is the time for
> anyone else to speak up if you have a good reason to keep it as an option!

me neither, we should just make it default settings.

> 
> Ross

> _______________________________________________
> Openembedded-architecture mailing list
> Openembedded-architecture@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-architecture