Re: [PATCHv3 0/5] Add dummy tools to help identify needed dependencies

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2048 bytes --]

On Wed, Mar 08, 2017 at 06:00:30PM +0000, Richard Purdie wrote:
> On Wed, 2017-03-08 at 17:21 +0000, Burton, Ross wrote:
> > 
> > On 8 March 2017 at 09:43, Peter Kjellerstedt <peter.kjellerstedt@axis
> > .com> wrote:
> > > since I see that you have integrated/staged the two patches that
> > > add
> > > inherits of pkgconfig, but not the patches that add the dummy
> > > commands,
> > > I assume you have some reservations to these patches. What are your
> > > take on the subject of blacklisting vs whitelisting the commands
> > > from
> > > the build host? I know that having these dummy commands in place
> > > helped
> > > me a great deal when updating our recipes to build correctly with
> > > RSS.
> > > 
> > FWIW I wasn't entirely keen on how the blacklisting had to be very
> > careful about how PATH was manipulated, which is why I merged to my
> > staging branch the fixes but not the dummy commands.
> > 
> > If the majority of people agree that this should be merged I don't
> > have a strong opinion either way.
> 
> Ultimately I think there is a better solution than this but I haven't
> had time to look at that as yet.
> 
> I do worry that it makes assumptions about PATH that may or may not be
> valid everywhere, equally I do see it could be useful.
> 
> So I also have mixed feelings...

I got many complains about my PNBLACKLISTs saying that the issues weren't
reproducible elsewhere and in the end it was in 90% one of these
commonly installed tools like pkgconfig being used from the host.

So I agree that PATH changes are tricky and that whitelisting would be
even better than this, but still I would prefer to get this merged as it
will help to identify and fix most common issues and changing this to
whitelist would be easier in future.

My jenkins buildhost is quite minimal (that's why it detected so many
issues with RSS, but I'll include the rest of this series in next run to
see if it will find even more).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]