Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Burton, Ross" <ross.burton@intel.com>,
	Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv3 0/5] Add dummy tools to help identify needed dependencies
Date: Wed, 08 Mar 2017 18:00:30 +0000	[thread overview]
Message-ID: <1488996030.22968.78.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJTo0Laa_WrQOjCyNBBmpWbKkza9Pg=dAiQEQJBrQoiEWab0Bw@mail.gmail.com>

On Wed, 2017-03-08 at 17:21 +0000, Burton, Ross wrote:
> 
> On 8 March 2017 at 09:43, Peter Kjellerstedt <peter.kjellerstedt@axis
> .com> wrote:
> > since I see that you have integrated/staged the two patches that
> > add
> > inherits of pkgconfig, but not the patches that add the dummy
> > commands,
> > I assume you have some reservations to these patches. What are your
> > take on the subject of blacklisting vs whitelisting the commands
> > from
> > the build host? I know that having these dummy commands in place
> > helped
> > me a great deal when updating our recipes to build correctly with
> > RSS.
> > 
> FWIW I wasn't entirely keen on how the blacklisting had to be very
> careful about how PATH was manipulated, which is why I merged to my
> staging branch the fixes but not the dummy commands.
> 
> If the majority of people agree that this should be merged I don't
> have a strong opinion either way.

Ultimately I think there is a better solution than this but I haven't
had time to look at that as yet.

I do worry that it makes assumptions about PATH that may or may not be
valid everywhere, equally I do see it could be useful.

So I also have mixed feelings...

Cheers,

Richard


  parent reply	other threads:[~2017-03-08 18:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 11:17 [PATCHv3 0/5] Add dummy tools to help identify needed dependencies Peter Kjellerstedt
2017-03-03 11:17 ` [PATCHv3 1/5] module.bbclass: Add inherit of pkgconfig Peter Kjellerstedt
2017-03-03 11:17 ` [PATCHv3 2/5] linux-libc-headers: " Peter Kjellerstedt
2017-03-03 11:17 ` [PATCHv3 3/5] scripts/dbus-binding-tool: Add a dummy version that always fails Peter Kjellerstedt
2017-03-03 11:17 ` [PATCHv3 4/5] scripts/gdbus-codegen: " Peter Kjellerstedt
2017-03-03 11:17 ` [PATCHv3 5/5] scripts/pkg-config: " Peter Kjellerstedt
2017-03-03 16:23 ` [PATCHv3 0/5] Add dummy tools to help identify needed dependencies Max Krummenacher
2017-03-03 19:52   ` Peter Kjellerstedt
2017-03-08  9:43     ` Peter Kjellerstedt
2017-03-08 17:14       ` Khem Raj
2017-03-08 17:21       ` Burton, Ross
2017-03-08 17:26         ` Mark Hatle
2017-03-08 18:00         ` Richard Purdie [this message]
2017-03-08 18:41           ` Martin Jansa
2017-03-09  0:18             ` Richard Purdie
2017-03-09  0:44               ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488996030.22968.78.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox