[PATCH] sanity: explain where TMPDIR is if we're telling the user to delete it

[PATCH] sanity: explain where TMPDIR is if we're telling the user to delete it

[Ross Burton]

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 94c78b5..ade8cb6 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -589,7 +589,7 @@ def sanity_handle_abichanges(status, d):
             with open(abifile, "w") as f:
                 f.write(current_abi)
         elif int(abi) <= 11 and current_abi == "12":
-            status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please start with a clean TMPDIR.\n")
+            status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please start with a clean TMPDIR (%s).\n" % d.getVar("TMPDIR"))
         elif (abi != current_abi):
             # Code to convert from one ABI to another could go here if possible.
             status.addresult("Error, TMPDIR has changed its layout version number (%s to %s) and you need to either rebuild, revert or adjust it at your own risk.\n" % (abi, current_abi))
-- 
2.8.1

✗ patchtest: failure for sanity: explain where TMPDIR is if we're telling the user to delete it

[Patchwork]

== Series Details ==

Series: sanity: explain where TMPDIR is if we're telling the user to delete it
Revision: 1
URL   : https://patchwork.openembedded.org/series/6146/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Patch line too long (current length 226) [test_max_line_length] 
  Suggested fix    Shorten the corresponding patch line (max length supported 180)
  Patch            meta/classes/sanity.bbclass
  Line             +            status.addresult("The layout of TMPDIR changed for Recipe Specific  ...



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] sanity: explain where TMPDIR is if we're telling the user to delete it

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Tue, Apr 4, 2017 at 7:22 AM, Ross Burton <ross.burton@intel.com> wrote:

> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/classes/sanity.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 94c78b5..ade8cb6 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -589,7 +589,7 @@ def sanity_handle_abichanges(status, d):
>              with open(abifile, "w") as f:
>                  f.write(current_abi)
>          elif int(abi) <= 11 and current_abi == "12":
> -            status.addresult("The layout of TMPDIR changed for Recipe
> Specific Sysroots.\nConversion doesn't make sense and this change will
> rebuild everything so please start with a clean TMPDIR.\n")
> +            status.addresult("The layout of TMPDIR changed for Recipe
> Specific Sysroots.\nConversion doesn't make sense and this change will
> rebuild everything so please start with a clean TMPDIR (%s).\n" %
> d.getVar("TMPDIR"))
>

This looks good, though I wonder if we should explicitly state that it
should be removed. I could see someone wondering how they “clean” their
tmpdir :)
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2012 bytes --]

Re: [PATCH] sanity: explain where TMPDIR is if we're telling the user to delete it

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

On 4 April 2017 at 16:13, Christopher Larson <kergoth@gmail.com> wrote:

> This looks good, though I wonder if we should explicitly state that it
> should be removed. I could see someone wondering how they “clean” their
> tmpdir :)
>

Good point, v2 sent.

Ross

[-- Attachment #2: Type: text/html, Size: 636 bytes --]