[PATCH V2] sanity: explain where TMPDIR is if we're telling the user to delete it

[PATCH V2] sanity: explain where TMPDIR is if we're telling the user to delete it

[Ross Burton]

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 94c78b5..e8064ac 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -589,7 +589,7 @@ def sanity_handle_abichanges(status, d):
             with open(abifile, "w") as f:
                 f.write(current_abi)
         elif int(abi) <= 11 and current_abi == "12":
-            status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please start with a clean TMPDIR.\n")
+            status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please delete TMPDIR (%s).\n" % d.getVar("TMPDIR"))
         elif (abi != current_abi):
             # Code to convert from one ABI to another could go here if possible.
             status.addresult("Error, TMPDIR has changed its layout version number (%s to %s) and you need to either rebuild, revert or adjust it at your own risk.\n" % (abi, current_abi))
-- 
2.8.1

✗ patchtest: failure for sanity: explain where TMPDIR is if we're telling the user to delete it (rev2)

[Patchwork]

== Series Details ==

Series: sanity: explain where TMPDIR is if we're telling the user to delete it (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/6146/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Patch line too long (current length 214) [test_max_line_length] 
  Suggested fix    Shorten the corresponding patch line (max length supported 180)
  Patch            meta/classes/sanity.bbclass
  Line             +            status.addresult("The layout of TMPDIR changed for Recipe Specific  ...



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: ✗ patchtest: failure for sanity: explain where TMPDIR is if we're telling the user to delete it (rev2)

[Paul Eggleton]

On Wednesday, 5 April 2017 5:02:05 AM NZST Patchwork wrote:
> * Issue             Patch line too long (current length 214)
> [test_max_line_length] Suggested fix    Shorten the corresponding patch
> line (max length supported 180) Patch           
> meta/classes/sanity.bbclass
>   Line             +            status.addresult("The layout of TMPDIR
> changed for Recipe Specific  ...

I'm not sure we need to be checking for this. If our code strictly adhered to 
a maximum line length already then maybe, but the vast majority of it doesn't 
at the moment.

Cheers,
Paul


-- 

Paul Eggleton
Intel Open Source Technology Centre