From: Denys Dmytriyenko <denis@denix.org>
To: "C.R. Guo" <chunrong.guo@nxp.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] kernel-fitimage: fix KERNEL_DEVICETREE includes subdirectory issue
Date: Mon, 15 May 2017 13:33:48 -0400 [thread overview]
Message-ID: <20170515173348.GK28053@denix.org> (raw)
In-Reply-To: <DB5PR0401MB1848C8D63FF1C4CDB7AB366184E10@DB5PR0401MB1848.eurprd04.prod.outlook.com>
On Mon, May 15, 2017 at 03:09:32AM +0000, C.R. Guo wrote:
> Hello Denys ,
>
>
> for example:
> KERNEL_DEVICETREE ?= "freescale/fsl-ls1046a-rdb.dtb"
^^^^^^^^^^^^^^^^^^^^
> ${DTB}= "freescale/fsl-ls1046a-rdb.dtb"
^^^^^^^^^^^^^^^^^^^^
> DTB=`basename ${DTB}`
>
> ${DTB}= "fsl-ls1046a-rdb.dtb"
>
> if use DTB_PATH="arch/${ARCH}/boot/dts/${DTB}"
>
>
> DTB_PATH = ="arch/${ARCH}/boot/dts/fsl-ls1046a-rdb.dtb"
>
> but dtb files real path is arch/${ARCH}/boot/dts/freescale/fsl-ls1046a-rdb.dtb"
The original DTB and KERNEL_DEVICETREE above still have the correct path,
don't they?
--
Denys
> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denis@denix.org]
> Sent: Friday, May 12, 2017 11:12 PM
> To: Chunrong Guo
> Cc: openembedded-core@lists.openembedded.org; C.R. Guo
> Subject: Re: [OE-core] [PATCH 3/3] kernel-fitimage: fix KERNEL_DEVICETREE includes subdirectory issue
>
> On Wed, May 10, 2017 at 04:47:13PM +0800, Chunrong Guo wrote:
> > From: Chunrong Guo <chunrong.guo@nxp.com>
> >
> > * For example:
> > KERNEL_DEVICETREE ?= "freescale/fsl-ls1046a-rdb.dtb"
> >
> > ${DTB}= "freescale/fsl-ls1046a-rdb.dtb"
> >
> > but only fsl-ls1046a-rdb.dtb should be used in fit-image.its
> >
> > Signed-off-by: Chunrong Guo <B40290@freescale.com>
> > ---
> > meta/classes/kernel-fitimage.bbclass | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/kernel-fitimage.bbclass
> > b/meta/classes/kernel-fitimage.bbclass
> > index 9fa836f..3171d10 100644
> > --- a/meta/classes/kernel-fitimage.bbclass
> > +++ b/meta/classes/kernel-fitimage.bbclass
> > @@ -346,7 +346,10 @@ fitimage_assemble() {
> > bbwarn "${DTB} contains the full path to the the dts file, but only the dtb name should be used."
> > DTB=`basename ${DTB} | sed 's,\.dts$,.dtb,g'`
> > fi
> > - DTB_PATH="arch/${ARCH}/boot/dts/${DTB}"
> > +
> > + DTB=`basename ${DTB}`
> > + DTB_PATH=`find arch/${ARCH}/boot -name
> > +"${DTB}"`
>
> Any way to not use "find" here? Shouldn't KERNEL_DEVICETREE and DTB_PATH already give you the full path?
>
>
> > +
> > if [ ! -e "${DTB_PATH}" ]; then
> > DTB_PATH="arch/${ARCH}/boot/${DTB}"
> > fi
> > --
> > 1.8.3.2
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
prev parent reply other threads:[~2017-05-15 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 8:47 [PATCH 1/3] kernel-fitimage: Support ext2.gz filesystems Chunrong Guo
2017-05-10 8:47 ` [PATCH 2/3] kernel-fitimage: set replacementtype to vmlinux Chunrong Guo
2017-05-10 8:47 ` [PATCH 3/3] kernel-fitimage: fix KERNEL_DEVICETREE includes subdirectory issue Chunrong Guo
2017-05-10 13:20 ` Anders Darander
[not found] ` <DB5PR0401MB18485FA0120D685F729EBDDB84ED0@DB5PR0401MB1848.eurprd04.prod.outlook.com>
2017-05-12 7:11 ` Anders Darander
2017-05-12 15:12 ` Denys Dmytriyenko
[not found] ` <DB5PR0401MB1848C8D63FF1C4CDB7AB366184E10@DB5PR0401MB1848.eurprd04.prod.outlook.com>
2017-05-15 17:33 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515173348.GK28053@denix.org \
--to=denis@denix.org \
--cc=chunrong.guo@nxp.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox