[master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[Jonathan Liu]

The whoami command is used when building the Linux kernel in
scripts/mkcompile_h to embed the build user that is visible
in /proc/version.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 3ad905c917..4f20aa3d1c 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -465,7 +465,7 @@ HOSTTOOLS += " \
     mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
     python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
     sleep sort split stat strings strip tail tar tee test touch tr true uname \
-    uniq wc wget which xargs \
+    uniq wc wget which whoami xargs \
 "
 
 # Tools needed to run testimage runtime image testing
-- 
2.12.2

Re: [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[Khem Raj]

On Sun, Jun 11, 2017 at 9:58 AM, Jonathan Liu <net147@gmail.com> wrote:
> The whoami command is used when building the Linux kernel in
> scripts/mkcompile_h to embed the build user that is visible
> in /proc/version.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 3ad905c917..4f20aa3d1c 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -465,7 +465,7 @@ HOSTTOOLS += " \
>      mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
>      python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
>      sleep sort split stat strings strip tail tar tee test touch tr true uname \
> -    uniq wc wget which xargs \
> +    uniq wc wget which whoami xargs \

I think it might be better to not use whoami at all to begin with, it
might be good for reproducibility
too.

>  "
>
>  # Tools needed to run testimage runtime image testing
> --
> 2.12.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[Denys Dmytriyenko]

On Sun, Jun 11, 2017 at 10:22:58AM -0700, Khem Raj wrote:
> On Sun, Jun 11, 2017 at 9:58 AM, Jonathan Liu <net147@gmail.com> wrote:
> > The whoami command is used when building the Linux kernel in
> > scripts/mkcompile_h to embed the build user that is visible
> > in /proc/version.
> >
> > Signed-off-by: Jonathan Liu <net147@gmail.com>
> > ---
> >  meta/conf/bitbake.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 3ad905c917..4f20aa3d1c 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -465,7 +465,7 @@ HOSTTOOLS += " \
> >      mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
> >      python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
> >      sleep sort split stat strings strip tail tar tee test touch tr true uname \
> > -    uniq wc wget which xargs \
> > +    uniq wc wget which whoami xargs \
> 
> I think it might be better to not use whoami at all to begin with, it
> might be good for reproducibility too.

There was this whole discussion about adding whoami couple months ago - 
Richard won't accept the change:

http://lists.openembedded.org/pipermail/openembedded-core/2017-March/134878.html

-- 
Denys

Re: [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

On 11 June 2017 at 17:58, Jonathan Liu <net147@gmail.com> wrote:

> The whoami command is used when building the Linux kernel in
> scripts/mkcompile_h to embed the build user that is visible
> in /proc/version.
>

Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8, in theory
at least.  Unless you have an entirely from-scratch recipe that doesn't use
kernel.bbclass, I guess.

Ross

[-- Attachment #2: Type: text/html, Size: 905 bytes --]

Re: [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[Denys Dmytriyenko]

On Sun, Jun 11, 2017 at 08:17:09PM +0100, Burton, Ross wrote:
> On 11 June 2017 at 17:58, Jonathan Liu <net147@gmail.com> wrote:
> 
> > The whoami command is used when building the Linux kernel in
> > scripts/mkcompile_h to embed the build user that is visible
> > in /proc/version.
> >
> 
> Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8, in theory
> at least.  Unless you have an entirely from-scratch recipe that doesn't use
> kernel.bbclass, I guess.

Not in pyro - care to backport?

-- 
Denys

Re: [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[Richard Purdie]

On Sun, 2017-06-11 at 15:59 -0400, Denys Dmytriyenko wrote:
> On Sun, Jun 11, 2017 at 08:17:09PM +0100, Burton, Ross wrote:
> > 
> > On 11 June 2017 at 17:58, Jonathan Liu <net147@gmail.com> wrote:
> > 
> > > 
> > > The whoami command is used when building the Linux kernel in
> > > scripts/mkcompile_h to embed the build user that is visible
> > > in /proc/version.
> > > 
> > Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8,
> > in theory
> > at least.  Unless you have an entirely from-scratch recipe that
> > doesn't use
> > kernel.bbclass, I guess.
> Not in pyro - care to backport?

I've backported this onto the pyro branch.

Cheers,

Richard

Re: [master][pyro][PATCH] bitbake.conf: Add whoami to HOSTTOOLS

[Denys Dmytriyenko]

On Sun, Jun 11, 2017 at 11:01:20PM +0100, Richard Purdie wrote:
> On Sun, 2017-06-11 at 15:59 -0400, Denys Dmytriyenko wrote:
> > On Sun, Jun 11, 2017 at 08:17:09PM +0100, Burton, Ross wrote:
> > > 
> > > On 11 June 2017 at 17:58, Jonathan Liu <net147@gmail.com> wrote:
> > > 
> > > > 
> > > > The whoami command is used when building the Linux kernel in
> > > > scripts/mkcompile_h to embed the build user that is visible
> > > > in /proc/version.
> > > > 
> > > Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8,
> > > in theory
> > > at least.  Unless you have an entirely from-scratch recipe that
> > > doesn't use
> > > kernel.bbclass, I guess.
> > Not in pyro - care to backport?
> 
> I've backported this onto the pyro branch.

Thanks! I guess I've missed it...

-- 
Denys