Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/3] gcc-6.3: Fix libgfortran build
@ 2017-06-30  8:51 Ricardo Ribalda Delgado
  2017-06-30  8:51 ` [PATCH 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-06-30  8:51 UTC (permalink / raw)
  To: openembedded-core

Without this patch libbacktrace cannot be included/link during
libgfortran build.

libbtool: link: cannot find the library `../libbacktrace/libbacktrace.la'
or unhandled argument `../libbacktrace/libbacktrace.la'

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-6.3.inc              |  1 +
 .../gcc/gcc-6.3/0099-Fix-gfortran-build.patch      | 44 ++++++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch

diff --git a/meta/recipes-devtools/gcc/gcc-6.3.inc b/meta/recipes-devtools/gcc/gcc-6.3.inc
index 86b3e9ff19a4..36a116d48fb4 100644
--- a/meta/recipes-devtools/gcc/gcc-6.3.inc
+++ b/meta/recipes-devtools/gcc/gcc-6.3.inc
@@ -74,6 +74,7 @@ SRC_URI = "\
            file://0047-libgcc_s-Use-alias-for-__cpu_indicator_init-instead-.patch \
            file://0048-sync-gcc-stddef.h-with-musl.patch \
            file://0054_all_nopie-all-flags.patch \
+           file://0099-Fix-gfortran-build.patch \
            ${BACKPORTS} \
 "
 BACKPORTS = "\
diff --git a/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch b/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch
new file mode 100644
index 000000000000..32b2f9a0567f
--- /dev/null
+++ b/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch
@@ -0,0 +1,44 @@
+diff --git a/libgfortran/Makefile.am b/libgfortran/Makefile.am
+index 39d3e11d223c..b5efe6dfe195 100644
+--- a/libgfortran/Makefile.am
++++ b/libgfortran/Makefile.am
+@@ -37,7 +37,7 @@ toolexeclib_LTLIBRARIES = libgfortran.la
+ toolexeclib_DATA = libgfortran.spec
+ libgfortran_la_LINK = $(LINK) $(libgfortran_la_LDFLAGS)
+ libgfortran_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
+-	$(LTLDFLAGS) $(LIBQUADLIB) ../libbacktrace/libbacktrace.la \
++	$(LTLDFLAGS) $(LIBQUADLIB) ../../libbacktrace/libbacktrace.la \
+ 	-lm $(extra_ldflags_libgfortran) \
+ 	$(version_arg) -Wc,-shared-libgcc
+ libgfortran_la_DEPENDENCIES = $(version_dep) libgfortran.spec $(LIBQUADLIB_DEP)
+@@ -63,7 +63,7 @@ AM_CPPFLAGS = -iquote$(srcdir)/io -I$(srcdir)/$(MULTISRCTOP)../gcc \
+ 	      -I$(MULTIBUILDTOP)../libgcc \
+ 	      -I$(srcdir)/$(MULTISRCTOP)../libbacktrace \
+ 	      -I$(MULTIBUILDTOP)../libbacktrace \
+-	      -I../libbacktrace
++	      -I../../libbacktrace
+ 
+ # Fortran rules for complex multiplication and division
+ AM_CFLAGS += -fcx-fortran-rules
+diff --git a/libgfortran/Makefile.in b/libgfortran/Makefile.in
+index 7ed080cf7b0d..d197fbd6b683 100644
+--- a/libgfortran/Makefile.in
++++ b/libgfortran/Makefile.in
+@@ -598,7 +598,7 @@ toolexeclib_LTLIBRARIES = libgfortran.la
+ toolexeclib_DATA = libgfortran.spec
+ libgfortran_la_LINK = $(LINK) $(libgfortran_la_LDFLAGS)
+ libgfortran_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
+-	$(LTLDFLAGS) $(LIBQUADLIB) ../libbacktrace/libbacktrace.la \
++	$(LTLDFLAGS) $(LIBQUADLIB) ../../libbacktrace/libbacktrace.la \
+ 	-lm $(extra_ldflags_libgfortran) \
+ 	$(version_arg) -Wc,-shared-libgcc
+ 
+@@ -618,7 +618,7 @@ AM_CPPFLAGS = -iquote$(srcdir)/io -I$(srcdir)/$(MULTISRCTOP)../gcc \
+ 	      -I$(MULTIBUILDTOP)../libgcc \
+ 	      -I$(srcdir)/$(MULTISRCTOP)../libbacktrace \
+ 	      -I$(MULTIBUILDTOP)../libbacktrace \
+-	      -I../libbacktrace
++	      -I../../libbacktrace
+ 
+ gfor_io_src = io/size_from_kind.c $(am__append_2)
+ gfor_io_headers = \
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] libgfortran: Add missing dependency gcc-cross
  2017-06-30  8:51 [PATCH 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
@ 2017-06-30  8:51 ` Ricardo Ribalda Delgado
  2017-06-30  8:51 ` [PATCH 3/3] libgfortran: Add missing fincludes Ricardo Ribalda Delgado
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-06-30  8:51 UTC (permalink / raw)
  To: openembedded-core

Due to the fact that the recipe uses INHIBIT_DEFAULT_DEPS, we need to
manually add the cross compiler as a dependency.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-devtools/gcc/libgfortran.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gcc/libgfortran.inc b/meta/recipes-devtools/gcc/libgfortran.inc
index 4846decbb834..3b94c1b85b70 100644
--- a/meta/recipes-devtools/gcc/libgfortran.inc
+++ b/meta/recipes-devtools/gcc/libgfortran.inc
@@ -37,7 +37,7 @@ do_install () {
 }
 
 INHIBIT_DEFAULT_DEPS = "1"
-DEPENDS = "gcc-runtime"
+DEPENDS = "gcc-runtime gcc-cross-${TARGET_ARCH}"
 
 BBCLASSEXTEND = "nativesdk"
 
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] libgfortran: Add missing fincludes
  2017-06-30  8:51 [PATCH 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
  2017-06-30  8:51 ` [PATCH 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
@ 2017-06-30  8:51 ` Ricardo Ribalda Delgado
  2017-06-30  9:01 ` ✗ patchtest: failure for "gcc-6.3: Fix libgfortran build..." and 2 more Patchwork
  2017-07-03 16:03 ` [PATCH 1/3] gcc-6.3: Fix libgfortran build Khem Raj
  3 siblings, 0 replies; 5+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-06-30  8:51 UTC (permalink / raw)
  To: openembedded-core

ERROR: libgfortran-6.3.0-r0 do_package: QA Issue: libgfortran:
Files/directories were installed but not shipped in any package:
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude/ieee_features.mod
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude/ieee_arithmetic.mod
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude/ieee_exceptions.mod

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-devtools/gcc/libgfortran.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/gcc/libgfortran.inc b/meta/recipes-devtools/gcc/libgfortran.inc
index 3b94c1b85b70..5f5d4af7589d 100644
--- a/meta/recipes-devtools/gcc/libgfortran.inc
+++ b/meta/recipes-devtools/gcc/libgfortran.inc
@@ -54,6 +54,7 @@ FILES_${PN}-dev = "\
     ${libdir}/libgfortran.la \
     ${libdir}/gcc/${TARGET_SYS}/${BINV}/libgfortranbegin.* \
     ${libdir}/gcc/${TARGET_SYS}/${BINV}/libcaf_single* \
+    ${libdir}/gcc/${TARGET_SYS}/${BINV}/finclude/ \
 "
 FILES_${PN}-staticdev = "${libdir}/libgfortran.a"
 
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* ✗ patchtest: failure for "gcc-6.3: Fix libgfortran build..." and 2 more
  2017-06-30  8:51 [PATCH 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
  2017-06-30  8:51 ` [PATCH 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
  2017-06-30  8:51 ` [PATCH 3/3] libgfortran: Add missing fincludes Ricardo Ribalda Delgado
@ 2017-06-30  9:01 ` Patchwork
  2017-07-03 16:03 ` [PATCH 1/3] gcc-6.3: Fix libgfortran build Khem Raj
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-06-30  9:01 UTC (permalink / raw)
  To: Ricardo Ribalda Delgado; +Cc: openembedded-core

== Series Details ==

Series: "gcc-6.3: Fix libgfortran build..." and 2 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/7525/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Added patch file is missing Upstream-Status in the header [test_upstream_status_presence] 
  Suggested fix    Add Upstream-Status: <status> to the header of meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)

* Issue             A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence] 
  Suggested fix    Sign off the added patch file (meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] gcc-6.3: Fix libgfortran build
  2017-06-30  8:51 [PATCH 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
                   ` (2 preceding siblings ...)
  2017-06-30  9:01 ` ✗ patchtest: failure for "gcc-6.3: Fix libgfortran build..." and 2 more Patchwork
@ 2017-07-03 16:03 ` Khem Raj
  3 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2017-07-03 16:03 UTC (permalink / raw)
  To: Ricardo Ribalda Delgado; +Cc: Patches and discussions about the oe-core layer

On Fri, Jun 30, 2017 at 1:51 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Without this patch libbacktrace cannot be included/link during
> libgfortran build.
>
> libbtool: link: cannot find the library `../libbacktrace/libbacktrace.la'
> or unhandled argument `../libbacktrace/libbacktrace.la'
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-6.3.inc              |  1 +
>  .../gcc/gcc-6.3/0099-Fix-gfortran-build.patch      | 44 ++++++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch
>
> diff --git a/meta/recipes-devtools/gcc/gcc-6.3.inc b/meta/recipes-devtools/gcc/gcc-6.3.inc
> index 86b3e9ff19a4..36a116d48fb4 100644
> --- a/meta/recipes-devtools/gcc/gcc-6.3.inc
> +++ b/meta/recipes-devtools/gcc/gcc-6.3.inc
> @@ -74,6 +74,7 @@ SRC_URI = "\
>             file://0047-libgcc_s-Use-alias-for-__cpu_indicator_init-instead-.patch \
>             file://0048-sync-gcc-stddef.h-with-musl.patch \
>             file://0054_all_nopie-all-flags.patch \
> +           file://0099-Fix-gfortran-build.patch \

call it 0055 for legibility sake.

>             ${BACKPORTS} \
>  "
>  BACKPORTS = "\
> diff --git a/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch b/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch
> new file mode 100644
> index 000000000000..32b2f9a0567f
> --- /dev/null
> +++ b/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch
> @@ -0,0 +1,44 @@
> +diff --git a/libgfortran/Makefile.am b/libgfortran/Makefile.am
> +index 39d3e11d223c..b5efe6dfe195 100644
> +--- a/libgfortran/Makefile.am
> ++++ b/libgfortran/Makefile.am
> +@@ -37,7 +37,7 @@ toolexeclib_LTLIBRARIES = libgfortran.la
> + toolexeclib_DATA = libgfortran.spec
> + libgfortran_la_LINK = $(LINK) $(libgfortran_la_LDFLAGS)
> + libgfortran_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
> +-      $(LTLDFLAGS) $(LIBQUADLIB) ../libbacktrace/libbacktrace.la \
> ++      $(LTLDFLAGS) $(LIBQUADLIB) ../../libbacktrace/libbacktrace.la \
> +       -lm $(extra_ldflags_libgfortran) \
> +       $(version_arg) -Wc,-shared-libgcc
> + libgfortran_la_DEPENDENCIES = $(version_dep) libgfortran.spec $(LIBQUADLIB_DEP)
> +@@ -63,7 +63,7 @@ AM_CPPFLAGS = -iquote$(srcdir)/io -I$(srcdir)/$(MULTISRCTOP)../gcc \
> +             -I$(MULTIBUILDTOP)../libgcc \
> +             -I$(srcdir)/$(MULTISRCTOP)../libbacktrace \
> +             -I$(MULTIBUILDTOP)../libbacktrace \
> +-            -I../libbacktrace
> ++            -I../../libbacktrace
> +
> + # Fortran rules for complex multiplication and division
> + AM_CFLAGS += -fcx-fortran-rules
> +diff --git a/libgfortran/Makefile.in b/libgfortran/Makefile.in
> +index 7ed080cf7b0d..d197fbd6b683 100644
> +--- a/libgfortran/Makefile.in
> ++++ b/libgfortran/Makefile.in
> +@@ -598,7 +598,7 @@ toolexeclib_LTLIBRARIES = libgfortran.la
> + toolexeclib_DATA = libgfortran.spec
> + libgfortran_la_LINK = $(LINK) $(libgfortran_la_LDFLAGS)
> + libgfortran_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
> +-      $(LTLDFLAGS) $(LIBQUADLIB) ../libbacktrace/libbacktrace.la \
> ++      $(LTLDFLAGS) $(LIBQUADLIB) ../../libbacktrace/libbacktrace.la \
> +       -lm $(extra_ldflags_libgfortran) \
> +       $(version_arg) -Wc,-shared-libgcc
> +
> +@@ -618,7 +618,7 @@ AM_CPPFLAGS = -iquote$(srcdir)/io -I$(srcdir)/$(MULTISRCTOP)../gcc \
> +             -I$(MULTIBUILDTOP)../libgcc \
> +             -I$(srcdir)/$(MULTISRCTOP)../libbacktrace \
> +             -I$(MULTIBUILDTOP)../libbacktrace \
> +-            -I../libbacktrace
> ++            -I../../libbacktrace
> +
> + gfor_io_src = io/size_from_kind.c $(am__append_2)
> + gfor_io_headers = \
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-07-03 16:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-30  8:51 [PATCH 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
2017-06-30  8:51 ` [PATCH 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
2017-06-30  8:51 ` [PATCH 3/3] libgfortran: Add missing fincludes Ricardo Ribalda Delgado
2017-06-30  9:01 ` ✗ patchtest: failure for "gcc-6.3: Fix libgfortran build..." and 2 more Patchwork
2017-07-03 16:03 ` [PATCH 1/3] gcc-6.3: Fix libgfortran build Khem Raj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox