* [PATCH V2 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
@ 2017-10-17 1:46 Chen Qi
2017-10-17 1:46 ` [PATCH V2 1/1] " Chen Qi
2017-10-17 2:00 ` ✗ patchtest: failure for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Chen Qi @ 2017-10-17 1:46 UTC (permalink / raw)
To: openembedded-core
**** V2 *****
Change to keep the alphabetical order.
The following changes since commit 96967261993f8b583b51cdeccbb1fd06042d2192:
bitbake: toaster/highlight.pack.js: Fix corrupted file (2017-10-10 11:05:08 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/bug12227
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/bug12227
Chen Qi (1):
bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
meta/conf/bitbake.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 1/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
2017-10-17 1:46 [PATCH V2 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL Chen Qi
@ 2017-10-17 1:46 ` Chen Qi
2017-10-17 2:18 ` Denys Dmytriyenko
2017-10-17 2:00 ` ✗ patchtest: failure for " Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Chen Qi @ 2017-10-17 1:46 UTC (permalink / raw)
To: openembedded-core
We changed to make tools required by testimage to be included conditionally.
This resulted in users who use ssh for git fetching having failures.
Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
[YOCTO #12227]
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
meta/conf/bitbake.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 0eefb86..4fba9d6 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -487,7 +487,7 @@ HOSTTOOLS += " \
HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
# Link to these if present
-HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
+HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
# Temporary add few more detected in bitbake world
HOSTTOOLS_NONFATAL += "join nl size yes zcat"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2 1/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
2017-10-17 1:46 ` [PATCH V2 1/1] " Chen Qi
@ 2017-10-17 2:18 ` Denys Dmytriyenko
2017-10-17 2:31 ` ChenQi
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2017-10-17 2:18 UTC (permalink / raw)
To: Chen Qi; +Cc: openembedded-core
On Tue, Oct 17, 2017 at 09:46:32AM +0800, Chen Qi wrote:
> We changed to make tools required by testimage to be included conditionally.
> This resulted in users who use ssh for git fetching having failures.
>
> Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
>
> [YOCTO #12227]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
1. Why don't people specify what has changed between v1 and v2 of the patch?
2. A corrected/sorted patch already went in earlier:
http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a
> meta/conf/bitbake.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 0eefb86..4fba9d6 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -487,7 +487,7 @@ HOSTTOOLS += " \
> HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
>
> # Link to these if present
> -HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
> +HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
>
> # Temporary add few more detected in bitbake world
> HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2 1/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
2017-10-17 2:18 ` Denys Dmytriyenko
@ 2017-10-17 2:31 ` ChenQi
2017-10-17 3:05 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: ChenQi @ 2017-10-17 2:31 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: openembedded-core
On 10/17/2017 10:18 AM, Denys Dmytriyenko wrote:
> On Tue, Oct 17, 2017 at 09:46:32AM +0800, Chen Qi wrote:
>> We changed to make tools required by testimage to be included conditionally.
>> This resulted in users who use ssh for git fetching having failures.
>>
>> Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
>>
>> [YOCTO #12227]
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
> 1. Why don't people specify what has changed between v1 and v2 of the patch?
It's in [OE-core] [PATCH V2 0/1] bitbake.conf: add ssh to
HOSTTOOLS_NONFATAL.
>
> 2. A corrected/sorted patch already went in earlier:
> http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a
Sorry. My carelessness.
I should have checked the latest master.
Best Regards,
Chen Qi
>
>> meta/conf/bitbake.conf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 0eefb86..4fba9d6 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -487,7 +487,7 @@ HOSTTOOLS += " \
>> HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
>>
>> # Link to these if present
>> -HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
>> +HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
>>
>> # Temporary add few more detected in bitbake world
>> HOSTTOOLS_NONFATAL += "join nl size yes zcat"
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2 1/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
2017-10-17 2:31 ` ChenQi
@ 2017-10-17 3:05 ` Denys Dmytriyenko
0 siblings, 0 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2017-10-17 3:05 UTC (permalink / raw)
To: ChenQi; +Cc: openembedded-core
On Tue, Oct 17, 2017 at 10:31:11AM +0800, ChenQi wrote:
> On 10/17/2017 10:18 AM, Denys Dmytriyenko wrote:
> >On Tue, Oct 17, 2017 at 09:46:32AM +0800, Chen Qi wrote:
> >>We changed to make tools required by testimage to be included conditionally.
> >>This resulted in users who use ssh for git fetching having failures.
> >>
> >>Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
> >>
> >>[YOCTO #12227]
> >>
> >>Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> >>---
> >1. Why don't people specify what has changed between v1 and v2 of the patch?
>
> It's in [OE-core] [PATCH V2 0/1] bitbake.conf: add ssh to
> HOSTTOOLS_NONFATAL.
The changelog between patch revisions?
> >2. A corrected/sorted patch already went in earlier:
> >http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a
>
> Sorry. My carelessness.
> I should have checked the latest master.
>
> Best Regards,
> Chen Qi
> >
> >> meta/conf/bitbake.conf | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> >>index 0eefb86..4fba9d6 100644
> >>--- a/meta/conf/bitbake.conf
> >>+++ b/meta/conf/bitbake.conf
> >>@@ -487,7 +487,7 @@ HOSTTOOLS += " \
> >> HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
> >> # Link to these if present
> >>-HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
> >>+HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
> >> # Temporary add few more detected in bitbake world
> >> HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> >>--
> >>1.9.1
> >>
> >>--
> >>_______________________________________________
> >>Openembedded-core mailing list
> >>Openembedded-core@lists.openembedded.org
> >>http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ patchtest: failure for bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
2017-10-17 1:46 [PATCH V2 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL Chen Qi
2017-10-17 1:46 ` [PATCH V2 1/1] " Chen Qi
@ 2017-10-17 2:00 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-10-17 2:00 UTC (permalink / raw)
To: Qi.Chen; +Cc: openembedded-core
== Series Details ==
Series: bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
Revision: 1
URL : https://patchwork.openembedded.org/series/9370/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 3b413a8057)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-17 3:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-17 1:46 [PATCH V2 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL Chen Qi
2017-10-17 1:46 ` [PATCH V2 1/1] " Chen Qi
2017-10-17 2:18 ` Denys Dmytriyenko
2017-10-17 2:31 ` ChenQi
2017-10-17 3:05 ` Denys Dmytriyenko
2017-10-17 2:00 ` ✗ patchtest: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox