From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] scripts/send-recipe-update-reminders: send recipe version update reminders by email
Date: Tue, 17 Oct 2017 09:07:03 -0500 [thread overview]
Message-ID: <20171017090703.85ac6135846b0a469bca4631@linux.intel.com> (raw)
In-Reply-To: <20171017124339.3966-1-alexander.kanavin@linux.intel.com>
On Tue, 17 Oct 2017 15:43:39 +0300
Alexander Kanavin <alexander.kanavin@linux.intel.com> wrote:
I like the idea of a simpler script to do this job.
Just one minor comment on the code: I would use non-zero exit values in case of errors and as a possible future enhancement, use a template (jinja2 for example) to format the email and just populate this with the data from checkpkg.
Leo
next prev parent reply other threads:[~2017-10-17 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 12:43 [PATCH] scripts/send-recipe-update-reminders: send recipe version update reminders by email Alexander Kanavin
2017-10-17 14:07 ` Leonardo Sandoval [this message]
2017-10-18 10:09 ` Alexander Kanavin
2017-10-17 14:26 ` Leonardo Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017090703.85ac6135846b0a469bca4631@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox