From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] scripts/send-recipe-update-reminders: send recipe version update reminders by email
Date: Wed, 18 Oct 2017 13:09:50 +0300 [thread overview]
Message-ID: <7279bf95-7391-73d9-523a-8296e4a487be@linux.intel.com> (raw)
In-Reply-To: <20171017090703.85ac6135846b0a469bca4631@linux.intel.com>
On 10/17/2017 05:07 PM, Leonardo Sandoval wrote:
>
> I like the idea of a simpler script to do this job.
>
> Just one minor comment on the code: I would use non-zero exit values
> in case of errors
Yep, fixed and will resent.
> and as a possible future enhancement, use a template (jinja2 for
> example) to format the email and just populate this with the data
> from checkpkg.
Current version of the script relies entirely on python3's standard
library; I wouldn't like to introduce 3rd party dependencies. Standard
string formatting is fine for the job imo, although I stretched the
readability to the limit :)
> AUH is the system that send emails with upgrade statistics (basically
> the system tries to upgrade and prepare the patch if possible) and
> RRS is the system that sends emails reporting upgradable recipes
> (just those recipes that needs to upgrade). I know, a bit confusing
> but in your context you are referring to the RRS.
Actually, the point of the script is that it sends *personal* reminders
- RRS wasn't doing that, and I'm not sure how much attention anyone paid
to those summaries that RRS sent to yocto ML. So it's a replacement for
both perhaps, except it doesn't have the ambition to also do the update
work for the maintainer, but 'devtool upgrade && devtool finish' is
arguably not more difficult than xsel|git am, followed by author reset :)
Alex
next prev parent reply other threads:[~2017-10-18 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 12:43 [PATCH] scripts/send-recipe-update-reminders: send recipe version update reminders by email Alexander Kanavin
2017-10-17 14:07 ` Leonardo Sandoval
2017-10-18 10:09 ` Alexander Kanavin [this message]
2017-10-17 14:26 ` Leonardo Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7279bf95-7391-73d9-523a-8296e4a487be@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox