[PATCH] curl: upgrade to 7.56.1

[PATCH] curl: upgrade to 7.56.1

[Oleksandr Kravchuk]

Upgarded curl to version 7.56.1. Removed few patches fixing CVEs, since
those fixes are included in the this release. Also removed installation
of 'curl/curlbuild.h', which has been removed in v7.55.0.
---
 meta/recipes-support/curl/{curl_7.54.1.bb => curl_7.56.1.bb} | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
 rename meta/recipes-support/curl/{curl_7.54.1.bb => curl_7.56.1.bb} (89%)

diff --git a/meta/recipes-support/curl/curl_7.54.1.bb b/meta/recipes-support/curl/curl_7.56.1.bb
similarity index 89%
rename from meta/recipes-support/curl/curl_7.54.1.bb
rename to meta/recipes-support/curl/curl_7.56.1.bb
index 58f0531..2891a4b 100644
--- a/meta/recipes-support/curl/curl_7.54.1.bb
+++ b/meta/recipes-support/curl/curl_7.56.1.bb
@@ -7,10 +7,6 @@ LIC_FILES_CHKSUM = "file://COPYING;beginline=8;md5=3a34942f4ae3fbf1a303160714e66
 
 SRC_URI = "http://curl.haxx.se/download/curl-${PV}.tar.bz2 \
            file://0001-replace-krb5-config-with-pkg-config.patch \
-           file://CVE-2017-1000099.patch \
-           file://CVE-2017-1000100.patch \
-           file://CVE-2017-1000101.patch \
-           file://CVE-2017-1000254.patch \
 "
 
 SRC_URI_append_class-target = " \
@@ -22,8 +18,8 @@ SRC_URI_append_class-target = " \
 #
 SRC_URI += " file://configure_ac.patch"
 
-SRC_URI[md5sum] = "6b6eb722f512e7a24855ff084f54fe55"
-SRC_URI[sha256sum] = "fdfc4df2d001ee0c44ec071186e770046249263c491fcae48df0e1a3ca8f25a0"
+SRC_URI[md5sum] = "428de25834ef8c04076906d6d5c0498e"
+SRC_URI[sha256sum] = "2594670367875e7d87b0f129b5e4690150780884d90244ba0fe3e74a778b5f90"
 
 CVE_PRODUCT = "libcurl"
 inherit autotools pkgconfig binconfig multilib_header
@@ -64,10 +60,6 @@ EXTRA_OECONF = " \
     --without-libpsl \
 "
 
-do_install_append() {
-	oe_multilib_header curl/curlbuild.h
-}
-
 do_install_append_class-target() {
 	# cleanup buildpaths from curl-config
 	sed -i \
-- 
2.7.4

Re: [PATCH] curl: upgrade to 7.56.1

[Alexander Kanavin]

On 11/13/2017 02:00 PM, Oleksandr Kravchuk wrote:
> Upgarded curl to version 7.56.1. Removed few patches fixing CVEs, since
> those fixes are included in the this release. Also removed installation
> of 'curl/curlbuild.h', which has been removed in v7.55.0.

In this case you should investigate further, and summarize your findings 
in the commit message. Why did the upstream remove the header? Did they 
replace it with something else? Most importantly, does the replacement 
need processing or patching too?


Alex

Re: [PATCH] curl: upgrade to 7.56.1

[Alexander Kanavin]

On 11/13/2017 02:13 PM, Kravchuk, Oleksandr wrote:
> No, they rely on another header file, curl/system.h now, instead of curl/curlbuild.h, which used to be generated during the build time.
> 
> Here is an explanation: https://daniel.haxx.se/blog/2017/06/15/target-independent-libcurl-headers/
> 

Thanks :) I actually already knew that; the point is that you need to 
include the information and the link into the commit message.

Alex

✗ patchtest: failure for curl: upgrade to 7.56.1

[Patchwork]

== Series Details ==

Series: curl: upgrade to 7.56.1
Revision: 1
URL   : https://patchwork.openembedded.org/series/9742/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            curl: upgrade to 7.56.1
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe