[PATCH v2] ca-certificates: Add /etc to SYSROOT_DIRS

[PATCH v2] ca-certificates: Add /etc to SYSROOT_DIRS

[Patrick Vacek]

From: Patrick Vacek <patrickvacek@gmail.com>

For recipes that depend on native ca-certificates.crt, /etc should be
added to the list of directories that automatically populate the
sysroot, otherwise the file may not be there.

Signed-off-by: Patrick Vacek <patrick@advancedtelematic.com>
---
 meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
index 59e7d51437..52a1a07f68 100644
--- a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
+++ b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
@@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
            file://sbindir.patch"
 
 S = "${WORKDIR}/git"
+SYSROOT_DIRS_class-native += "${sysconfdir}"
 
 inherit allarch
 
-- 
2.11.0

Re: [PATCH v2] ca-certificates: Add /etc to SYSROOT_DIRS

[Andre McCurdy]

On Wed, Nov 15, 2017 at 4:40 AM, Patrick Vacek
<patrick@advancedtelematic.com> wrote:
> From: Patrick Vacek <patrickvacek@gmail.com>
>
> For recipes that depend on native ca-certificates.crt, /etc should be
> added to the list of directories that automatically populate the
> sysroot, otherwise the file may not be there.
>
> Signed-off-by: Patrick Vacek <patrick@advancedtelematic.com>
> ---
>  meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
> index 59e7d51437..52a1a07f68 100644
> --- a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
> +++ b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
> @@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
>             file://sbindir.patch"
>
>  S = "${WORKDIR}/git"
> +SYSROOT_DIRS_class-native += "${sysconfdir}"

This change has now been merged, but unfortunately it looks wrong.
This use of += with an over-ride doesn't achieve what you describe in
the commit message (the += will append "${sysconfdir}" to the
over-ride value and then the over-ride value will COMPLETELY REPLACE
the original value of SYSROOT_DIRS, not add to it).

The change also appears to be unnecessary as ${sysconfdir} is appended
to SYSROOT_DIRS for -native recipes by default (via
SYSROOT_DIRS_NATIVE in staging.bbclass).

Exactly what issue were you trying to solve?

>
>  inherit allarch
>
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2] ca-certificates: Add /etc to SYSROOT_DIRS

[Alexander Kanavin]

There's no problem in reverting the change, if there is no real need
for it, just in case.

Alex

2018-07-06 5:28 GMT+02:00 Andre McCurdy <armccurdy@gmail.com>:
> On Wed, Nov 15, 2017 at 4:40 AM, Patrick Vacek
> <patrick@advancedtelematic.com> wrote:
>> From: Patrick Vacek <patrickvacek@gmail.com>
>>
>> For recipes that depend on native ca-certificates.crt, /etc should be
>> added to the list of directories that automatically populate the
>> sysroot, otherwise the file may not be there.
>>
>> Signed-off-by: Patrick Vacek <patrick@advancedtelematic.com>
>> ---
>>  meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
>> index 59e7d51437..52a1a07f68 100644
>> --- a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
>> +++ b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
>> @@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
>>             file://sbindir.patch"
>>
>>  S = "${WORKDIR}/git"
>> +SYSROOT_DIRS_class-native += "${sysconfdir}"
>
> This change has now been merged, but unfortunately it looks wrong.
> This use of += with an over-ride doesn't achieve what you describe in
> the commit message (the += will append "${sysconfdir}" to the
> over-ride value and then the over-ride value will COMPLETELY REPLACE
> the original value of SYSROOT_DIRS, not add to it).
>
> The change also appears to be unnecessary as ${sysconfdir} is appended
> to SYSROOT_DIRS for -native recipes by default (via
> SYSROOT_DIRS_NATIVE in staging.bbclass).
>
> Exactly what issue were you trying to solve?
>
>>
>>  inherit allarch
>>
>> --
>> 2.11.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2] ca-certificates: Add /etc to SYSROOT_DIRS

[Alexander Kanavin]

Patrick's email is no longer valid, so we should probably just do the
revert without expecting a clarification.

Alex

2018-07-06 6:57 GMT+02:00 Alexander Kanavin <alex.kanavin@gmail.com>:
> There's no problem in reverting the change, if there is no real need
> for it, just in case.
>
> Alex
>
> 2018-07-06 5:28 GMT+02:00 Andre McCurdy <armccurdy@gmail.com>:
>> On Wed, Nov 15, 2017 at 4:40 AM, Patrick Vacek
>> <patrick@advancedtelematic.com> wrote:
>>> From: Patrick Vacek <patrickvacek@gmail.com>
>>>
>>> For recipes that depend on native ca-certificates.crt, /etc should be
>>> added to the list of directories that automatically populate the
>>> sysroot, otherwise the file may not be there.
>>>
>>> Signed-off-by: Patrick Vacek <patrick@advancedtelematic.com>
>>> ---
>>>  meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
>>> index 59e7d51437..52a1a07f68 100644
>>> --- a/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
>>> +++ b/meta/recipes-support/ca-certificates/ca-certificates_20170717.bb
>>> @@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
>>>             file://sbindir.patch"
>>>
>>>  S = "${WORKDIR}/git"
>>> +SYSROOT_DIRS_class-native += "${sysconfdir}"
>>
>> This change has now been merged, but unfortunately it looks wrong.
>> This use of += with an over-ride doesn't achieve what you describe in
>> the commit message (the += will append "${sysconfdir}" to the
>> over-ride value and then the over-ride value will COMPLETELY REPLACE
>> the original value of SYSROOT_DIRS, not add to it).
>>
>> The change also appears to be unnecessary as ${sysconfdir} is appended
>> to SYSROOT_DIRS for -native recipes by default (via
>> SYSROOT_DIRS_NATIVE in staging.bbclass).
>>
>> Exactly what issue were you trying to solve?
>>
>>>
>>>  inherit allarch
>>>
>>> --
>>> 2.11.0
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core