* [PATCH] recipes-graphics/piglit: Add patch for fix build in HiKey platforms @ 2017-11-24 16:52 Aníbal Limón 2017-11-24 18:08 ` ✗ patchtest: failure for " Patchwork 2017-11-27 23:06 ` [PATCH] " Randy MacLeod 0 siblings, 2 replies; 4+ messages in thread From: Aníbal Limón @ 2017-11-24 16:52 UTC (permalink / raw) To: openembedded-core; +Cc: Aníbal Limón From: Aníbal Limón <anibal.limon@linaro.org> Some EGL implementations do not actually ship all Khronos-extensions. As it turns out, the Mali 450 driver does not include eglGetPlatformDisplay symbol so there is not grauntee to exists use piglit_egl_get_default_display wrapper instead. Signed-off-by: Aníbal Limón <anibal.limon@linaro.org> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> --- ...gl-context-priority.c-Use-piglit_egl_get_.patch | 39 ++++++++++++++++++++++ meta/recipes-graphics/piglit/piglit_git.bb | 1 + 2 files changed, 40 insertions(+) create mode 100644 meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch diff --git a/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch new file mode 100644 index 0000000000..6b73950fc1 --- /dev/null +++ b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch @@ -0,0 +1,39 @@ +From 3b6c3abe3698abb0ae08d14a399eea29805cafd6 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <anibal.limon@linaro.org> +Date: Fri, 24 Nov 2017 10:11:42 -0600 +Subject: [PATCH] tests/egl/egl-context-priority.c: Use + piglit_egl_get_default_display +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Some EGL implementations do not actually ship all Khronos-extensions. +As it turns out, the Mali 450 driver does not include eglGetPlatformDisplay +symbol so there is not grauntee to exists use piglit_egl_get_default_display +wrapper instead. See rev 45095dc08b. + +Signed-off-by: Aníbal Limón <anibal.limon@linaro.org> +Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> + +Upstream-Status: Submitted [piglit@lists.freedesktop.org] +--- + tests/egl/egl-context-priority.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/tests/egl/egl-context-priority.c b/tests/egl/egl-context-priority.c +index 7f26fc614..9590ccae3 100644 +--- a/tests/egl/egl-context-priority.c ++++ b/tests/egl/egl-context-priority.c +@@ -99,8 +99,7 @@ piglit_init(int argc, char **argv) + if (!strstr(exts, "EGL_MESA_platform_surfaceless")) + piglit_report_result(PIGLIT_SKIP); + +- dpy = eglGetPlatformDisplay(EGL_PLATFORM_SURFACELESS_MESA, +- EGL_DEFAULT_DISPLAY, NULL); ++ dpy = piglit_egl_get_default_display(EGL_PLATFORM_SURFACELESS_MESA); + + ok = eglInitialize(dpy, &major, &minor); + if (!ok) { +-- +2.11.0 + diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb index eae3eed342..c6d4e5c6e0 100644 --- a/meta/recipes-graphics/piglit/piglit_git.bb +++ b/meta/recipes-graphics/piglit/piglit_git.bb @@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b2beded7103a3d8a442a2a0391d607b0" SRC_URI = "git://anongit.freedesktop.org/piglit \ file://0001-cmake-install-bash-completions-in-the-right-place.patch \ file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch \ + file://0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch \ " # From 2017-02-06 -- 2.11.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ patchtest: failure for recipes-graphics/piglit: Add patch for fix build in HiKey platforms 2017-11-24 16:52 [PATCH] recipes-graphics/piglit: Add patch for fix build in HiKey platforms Aníbal Limón @ 2017-11-24 18:08 ` Patchwork 2017-11-27 23:06 ` [PATCH] " Randy MacLeod 1 sibling, 0 replies; 4+ messages in thread From: Patchwork @ 2017-11-24 18:08 UTC (permalink / raw) To: Aníbal Limón; +Cc: openembedded-core == Series Details == Series: recipes-graphics/piglit: Add patch for fix build in HiKey platforms Revision: 1 URL : https://patchwork.openembedded.org/series/9946/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Issue Series does not apply on top of target branch [test_series_merge_on_head] Suggested fix Rebase your series on top of targeted branch Targeted branch master (currently at 33418ed064) If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] recipes-graphics/piglit: Add patch for fix build in HiKey platforms 2017-11-24 16:52 [PATCH] recipes-graphics/piglit: Add patch for fix build in HiKey platforms Aníbal Limón 2017-11-24 18:08 ` ✗ patchtest: failure for " Patchwork @ 2017-11-27 23:06 ` Randy MacLeod 2017-11-27 23:14 ` Anibal Limón 1 sibling, 1 reply; 4+ messages in thread From: Randy MacLeod @ 2017-11-27 23:06 UTC (permalink / raw) To: Aníbal Limón, openembedded-core; +Cc: Aníbal Limón On 2017-11-24 11:52 AM, Aníbal Limón wrote: > From: Aníbal Limón <anibal.limon@linaro.org> > > Some EGL implementations do not actually ship all Khronos-extensions. > As it turns out, the Mali 450 driver does not include eglGetPlatformDisplay > symbol so there is not grauntee to exists use piglit_egl_get_default_display Anibal, First, my grammar OCD corrections, :) s/grauntee/guarantee/ and more generally: so there is not guarantee ... so there is no guarantee that it exists, use piglit_egl_get_default_display or just use the upstream commit log: The entry point is not guaranteed to exist, so use the piglit_egl_get_default_display() helper which does the correct thing. This a backport of 45095dc08b from the piglet git repo so please make that clear in the long log as well. Thanks, ../Randy > wrapper instead. > > Signed-off-by: Aníbal Limón <anibal.limon@linaro.org> > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> > --- > ...gl-context-priority.c-Use-piglit_egl_get_.patch | 39 ++++++++++++++++++++++ > meta/recipes-graphics/piglit/piglit_git.bb | 1 + > 2 files changed, 40 insertions(+) > create mode 100644 meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch > > diff --git a/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch > new file mode 100644 > index 0000000000..6b73950fc1 > --- /dev/null > +++ b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch > @@ -0,0 +1,39 @@ > +From 3b6c3abe3698abb0ae08d14a399eea29805cafd6 Mon Sep 17 00:00:00 2001 > +From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <anibal.limon@linaro.org> > +Date: Fri, 24 Nov 2017 10:11:42 -0600 > +Subject: [PATCH] tests/egl/egl-context-priority.c: Use > + piglit_egl_get_default_display > +MIME-Version: 1.0 > +Content-Type: text/plain; charset=UTF-8 > +Content-Transfer-Encoding: 8bit > + > +Some EGL implementations do not actually ship all Khronos-extensions. > +As it turns out, the Mali 450 driver does not include eglGetPlatformDisplay > +symbol so there is not grauntee to exists use piglit_egl_get_default_display > +wrapper instead. See rev 45095dc08b. > + > +Signed-off-by: Aníbal Limón <anibal.limon@linaro.org> > +Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> > + > +Upstream-Status: Submitted [piglit@lists.freedesktop.org] > +--- > + tests/egl/egl-context-priority.c | 3 +-- > + 1 file changed, 1 insertion(+), 2 deletions(-) > + > +diff --git a/tests/egl/egl-context-priority.c b/tests/egl/egl-context-priority.c > +index 7f26fc614..9590ccae3 100644 > +--- a/tests/egl/egl-context-priority.c > ++++ b/tests/egl/egl-context-priority.c > +@@ -99,8 +99,7 @@ piglit_init(int argc, char **argv) > + if (!strstr(exts, "EGL_MESA_platform_surfaceless")) > + piglit_report_result(PIGLIT_SKIP); > + > +- dpy = eglGetPlatformDisplay(EGL_PLATFORM_SURFACELESS_MESA, > +- EGL_DEFAULT_DISPLAY, NULL); > ++ dpy = piglit_egl_get_default_display(EGL_PLATFORM_SURFACELESS_MESA); > + > + ok = eglInitialize(dpy, &major, &minor); > + if (!ok) { > +-- > +2.11.0 > + > diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb > index eae3eed342..c6d4e5c6e0 100644 > --- a/meta/recipes-graphics/piglit/piglit_git.bb > +++ b/meta/recipes-graphics/piglit/piglit_git.bb > @@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b2beded7103a3d8a442a2a0391d607b0" > SRC_URI = "git://anongit.freedesktop.org/piglit \ > file://0001-cmake-install-bash-completions-in-the-right-place.patch \ > file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch \ > + file://0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch \ > " > > # From 2017-02-06 > -- # Randy MacLeod. WR Linux # Wind River an Intel Company ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] recipes-graphics/piglit: Add patch for fix build in HiKey platforms 2017-11-27 23:06 ` [PATCH] " Randy MacLeod @ 2017-11-27 23:14 ` Anibal Limón 0 siblings, 0 replies; 4+ messages in thread From: Anibal Limón @ 2017-11-27 23:14 UTC (permalink / raw) To: Randy MacLeod; +Cc: Aníbal Limón, openembedded-core [-- Attachment #1: Type: text/plain, Size: 4608 bytes --] On Mon, Nov 27, 2017 at 5:06 PM, Randy MacLeod <randy.macleod@windriver.com> wrote: > On 2017-11-24 11:52 AM, Aníbal Limón wrote: > >> From: Aníbal Limón <anibal.limon@linaro.org> >> >> Some EGL implementations do not actually ship all Khronos-extensions. >> As it turns out, the Mali 450 driver does not include >> eglGetPlatformDisplay >> symbol so there is not grauntee to exists use >> piglit_egl_get_default_display >> > > Anibal, > > First, my grammar OCD corrections, :) > > s/grauntee/guarantee/ > Ok, typo. > > and more generally: > so there is not guarantee ... > so there is no guarantee that it exists, > use piglit_egl_get_default_display > > or just use the upstream commit log: > The entry point is not guaranteed to exist, so use the > piglit_egl_get_default_display() helper which does the > correct thing. > > > This a backport of 45095dc08b from the piglet git repo > so please make that clear in the long log as well. > This isn't a backport, i will explain better in the commit message. Cheers, Anibal > > Thanks, > > ../Randy > > > > wrapper instead. >> >> Signed-off-by: Aníbal Limón <anibal.limon@linaro.org> >> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> >> --- >> ...gl-context-priority.c-Use-piglit_egl_get_.patch | 39 >> ++++++++++++++++++++++ >> meta/recipes-graphics/piglit/piglit_git.bb | 1 + >> 2 files changed, 40 insertions(+) >> create mode 100644 meta/recipes-graphics/piglit/p >> iglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch >> >> diff --git a/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl- >> context-priority.c-Use-piglit_egl_get_.patch >> b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl- >> context-priority.c-Use-piglit_egl_get_.patch >> new file mode 100644 >> index 0000000000..6b73950fc1 >> --- /dev/null >> +++ b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl- >> context-priority.c-Use-piglit_egl_get_.patch >> @@ -0,0 +1,39 @@ >> +From 3b6c3abe3698abb0ae08d14a399eea29805cafd6 Mon Sep 17 00:00:00 2001 >> +From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <anibal.limon@linaro.org> >> +Date: Fri, 24 Nov 2017 10:11:42 -0600 >> +Subject: [PATCH] tests/egl/egl-context-priority.c: Use >> + piglit_egl_get_default_display >> +MIME-Version: 1.0 >> +Content-Type: text/plain; charset=UTF-8 >> +Content-Transfer-Encoding: 8bit >> + >> +Some EGL implementations do not actually ship all Khronos-extensions. >> +As it turns out, the Mali 450 driver does not include >> eglGetPlatformDisplay >> +symbol so there is not grauntee to exists use >> piglit_egl_get_default_display >> +wrapper instead. See rev 45095dc08b. >> + >> +Signed-off-by: Aníbal Limón <anibal.limon@linaro.org> >> +Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> >> + >> +Upstream-Status: Submitted [piglit@lists.freedesktop.org] >> +--- >> + tests/egl/egl-context-priority.c | 3 +-- >> + 1 file changed, 1 insertion(+), 2 deletions(-) >> + >> +diff --git a/tests/egl/egl-context-priority.c >> b/tests/egl/egl-context-priority.c >> +index 7f26fc614..9590ccae3 100644 >> +--- a/tests/egl/egl-context-priority.c >> ++++ b/tests/egl/egl-context-priority.c >> +@@ -99,8 +99,7 @@ piglit_init(int argc, char **argv) >> + if (!strstr(exts, "EGL_MESA_platform_surfaceless")) >> + piglit_report_result(PIGLIT_SKIP); >> + >> +- dpy = eglGetPlatformDisplay(EGL_PLATFORM_SURFACELESS_MESA, >> +- EGL_DEFAULT_DISPLAY, NULL); >> ++ dpy = piglit_egl_get_default_display(EGL_PLATFORM_SURFACELESS_ >> MESA); >> + >> + ok = eglInitialize(dpy, &major, &minor); >> + if (!ok) { >> +-- >> +2.11.0 >> + >> diff --git a/meta/recipes-graphics/piglit/piglit_git.bb >> b/meta/recipes-graphics/piglit/piglit_git.bb >> index eae3eed342..c6d4e5c6e0 100644 >> --- a/meta/recipes-graphics/piglit/piglit_git.bb >> +++ b/meta/recipes-graphics/piglit/piglit_git.bb >> @@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b2beded710 >> 3a3d8a442a2a0391d607b0" >> SRC_URI = "git://anongit.freedesktop.org/piglit \ >> file://0001-cmake-install-bash-completions-in-the-right-place.patch >> \ >> file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch >> \ >> + file://0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch >> \ >> " >> # From 2017-02-06 >> >> > > -- > # Randy MacLeod. WR Linux > # Wind River an Intel Company > [-- Attachment #2: Type: text/html, Size: 6833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-27 23:14 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-11-24 16:52 [PATCH] recipes-graphics/piglit: Add patch for fix build in HiKey platforms Aníbal Limón 2017-11-24 18:08 ` ✗ patchtest: failure for " Patchwork 2017-11-27 23:06 ` [PATCH] " Randy MacLeod 2017-11-27 23:14 ` Anibal Limón
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox