Re: ✗ patchtest: failure for initramfs-framework installation improvements (rev4)

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3079 bytes --]

On Mon, Dec 04, 2017 at 09:23:59AM -0600, Leonardo Sandoval wrote:
> On Fri, 1 Dec 2017 23:07:48 +0100
> Martin Jansa <martin.jansa@gmail.com> wrote:
> 
> > Is it trying to apply whole series (including the 2 patches which were
> > already merged to master and actually introduced the issue I was trying to
> > fix)?
> > 
> > Does it mean that I cannot send a fix into the e-mail thread where the
> > issue was introduced and discussed?
> 
> I do not the answer but I can tell you about the fail check: patchtest is pretty dummy in this check, it simply does git apply --check <your series.mbox> so you need to base on master's HEAD.

But the patch I've sent is rebased on master's HEAD.

My question is how to send the patch to the thread where it IMHO belongs
without patchtest trying to apply all the patches in the thread (if
that's what it meants by "series".

See:
https://patchwork.openembedded.org/series/9783/
the last patch isn't 3/3 from this series, it's just independent new fix for changes
introduced in this series (e-mail thread).

so it should apply only this one:
https://patchwork.openembedded.org/patch/146352/

I know this cannot be as clever as e.g. gerrit, but my question still
stands:
Do we need to send fixes for already merged changes as new e-mail
threads (replace In-reply-to: with maybe just a link to ML archive
in the commit message)?

Regards,

> > On Fri, Dec 1, 2017 at 11:02 PM, Patchwork <
> > patchwork@patchwork.openembedded.org> wrote:  
> > 
> > > == Series Details ==
> > >
> > > Series: initramfs-framework installation improvements (rev4)
> > > Revision: 4
> > > URL   : https://patchwork.openembedded.org/series/9783/
> > > State : failure
> > >
> > > == Summary ==
> > >
> > >
> > > Thank you for submitting this patch series to OpenEmbedded Core. This is
> > > an automated response. Several tests have been executed on the proposed
> > > series by patchtest resulting in the following failures:
> > >
> > >
> > >
> > > * Issue             Series does not apply on top of target branch
> > > [test_series_merge_on_head]
> > >   Suggested fix    Rebase your series on top of targeted branch
> > >   Targeted branch  master (currently at addf309165)
> > >
> > >
> > >
> > > If you believe any of these test results are incorrect, please reply to the
> > > mailing list (openembedded-core@lists.openembedded.org) raising your
> > > concerns.
> > > Otherwise we would appreciate you correcting the issues and submitting a
> > > new
> > > version of the patchset if applicable. Please ensure you add/increment the
> > > version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> > > [PATCH v3] -> ...).
> > >
> > > ---
> > > Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_
> > > Guidelines
> > > Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> > > Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
> > >
> > >  

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]