Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Cal Sullivan <california.l.sullivan@intel.com>
To: Martin Jansa <martin.jansa@gmail.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>,
	akuster808@gmail.com
Subject: Re: [PATCH] initramfs-module-install: Remove allarch and FILESEXTRAPATHS
Date: Thu, 7 Dec 2017 10:13:57 -0800	[thread overview]
Message-ID: <af2b02f4-2f8b-4db1-e448-2d9755eec4b4@intel.com> (raw)
In-Reply-To: <1512165201-51-1-git-send-email-Martin.Jansa@gmail.com>

Ack'd.

We need this in master so it can be backported to rocko along with my 
patches.

Thanks,
Cal

On 12/01/2017 01:53 PM, Martin Jansa wrote:
> * files is already included in default FILESPATH
> * it cannot inherit allarch as it RDEPENDS on bunch of TUNE_PKGARCH packages
> * use the same COMPATIBLE_HOST restrictions as grub has to prevent ERRORs in
>    bitbake world
>    ERROR: Nothing RPROVIDES 'grub' (but oe-core/meta/recipes-core/initrdscripts/initramfs-module-install_1.0.bb RDEPENDS on or otherwise requires it)
>    grub was skipped: incompatible with host arm-oe-linux-gnueabi (not in COMPATIBLE_HOST)
>    grub was skipped: incompatible with host arm-oe-linux-gnueabi (not in COMPATIBLE_HOST)
>    NOTE: Runtime target 'grub' is unbuildable, removing...
>    Missing or unbuildable dependency chain was: ['grub']
>    ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   .../initrdscripts/initramfs-module-install-efi_1.0.bb             | 3 ---
>   meta/recipes-core/initrdscripts/initramfs-module-install_1.0.bb   | 8 +++++---
>   2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/meta/recipes-core/initrdscripts/initramfs-module-install-efi_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-module-install-efi_1.0.bb
> index 24b53a8..1e7f76f 100644
> --- a/meta/recipes-core/initrdscripts/initramfs-module-install-efi_1.0.bb
> +++ b/meta/recipes-core/initrdscripts/initramfs-module-install-efi_1.0.bb
> @@ -5,9 +5,6 @@ RDEPENDS_${PN} = "initramfs-framework-base parted e2fsprogs-mke2fs dosfstools ut
>   
>   PR = "r4"
>   
> -inherit allarch
> -
> -FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
>   SRC_URI = "file://init-install-efi.sh"
>   
>   S = "${WORKDIR}"
> diff --git a/meta/recipes-core/initrdscripts/initramfs-module-install_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-module-install_1.0.bb
> index ce7f165..02b69f3 100644
> --- a/meta/recipes-core/initrdscripts/initramfs-module-install_1.0.bb
> +++ b/meta/recipes-core/initrdscripts/initramfs-module-install_1.0.bb
> @@ -3,11 +3,13 @@ LICENSE = "MIT"
>   LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>   RDEPENDS_${PN} = "initramfs-framework-base grub parted e2fsprogs-mke2fs util-linux-blkid"
>   
> -PR = "r1"
> +# The same restriction as grub
> +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*)-(linux.*|freebsd.*)'
> +COMPATIBLE_HOST_armv7a = 'null'
> +COMPATIBLE_HOST_armv7ve = 'null'
>   
> -inherit allarch
> +PR = "r1"
>   
> -FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
>   SRC_URI = "file://init-install.sh"
>   
>   S = "${WORKDIR}"



  reply	other threads:[~2017-12-07 18:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 21:20 [PATCH 0/3] initramfs-framework installation improvements California Sullivan
2017-11-14 21:20 ` [PATCH 1/3] initramfs-module-install-efi: point to original copy and delete new file California Sullivan
2017-11-15 20:31   ` Otavio Salvador
2017-11-14 21:20 ` [PATCH 2/3] initramfs-module-install-efi: update summary California Sullivan
2017-11-15 20:31   ` Otavio Salvador
2017-11-14 21:20 ` [PATCH 3/3] initramfs-framework: add install module California Sullivan
2017-11-14 22:03 ` [PATCH 3/3 V2] " California Sullivan
2017-12-01 21:01   ` Martin Jansa
2017-12-01 21:53     ` [PATCH] initramfs-module-install: Remove allarch and FILESEXTRAPATHS Martin Jansa
2017-12-07 18:13       ` Cal Sullivan [this message]
2017-12-01 22:05     ` [PATCH 3/3 V2] initramfs-framework: add install module Cal Sullivan
2017-11-14 22:10 ` [PATCHi 3/3 V3] " California Sullivan
2017-11-15 20:36   ` Otavio Salvador
2017-12-01 22:02 ` ✗ patchtest: failure for initramfs-framework installation improvements (rev4) Patchwork
2017-12-01 22:07   ` Martin Jansa
2017-12-04 15:23     ` Leonardo Sandoval
2017-12-04 20:26       ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af2b02f4-2f8b-4db1-e448-2d9755eec4b4@intel.com \
    --to=california.l.sullivan@intel.com \
    --cc=akuster808@gmail.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox