[PATCH] kernel-devsrc: Use full mrproper to clean

[PATCH] kernel-devsrc: Use full mrproper to clean

[Saul Wold]

By using the full mrproper clean target it also removes some generated files
that are not required on the target to build. It also helps to fix reprodudible
builds as the generated files could have different permissions causing the
check to fail.

Tested with building and booting kernel from source on the target

[YOCTO #12137]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
index c1b5b7786d7..d925a33aeb1 100644
--- a/meta/recipes-kernel/linux/kernel-devsrc.bb
+++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
@@ -52,7 +52,7 @@ do_install() {
         # The main build artifacts. We clean the directory to avoid QA errors on mismatched
         # architecture (since scripts and helpers are native format).
         KBUILD_OUTPUT="$kerneldir"
-        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean _mrproper_scripts
+        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean mrproper
         # make clean generates an absolute path symlink called "source"
         # in $kerneldir points to $kerneldir, which doesn't make any
         # sense, so remove it.
-- 
2.13.6

Re: [PATCH] kernel-devsrc: Use full mrproper to clean

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

This breaks some of the sanity tests, which build a kernel module:

https://autobuilder.yocto.io/builders/nightly-x86-64/builds/664

Ross

On 5 December 2017 at 23:00, Saul Wold <sgw@linux.intel.com> wrote:

> By using the full mrproper clean target it also removes some generated
> files
> that are not required on the target to build. It also helps to fix
> reprodudible
> builds as the generated files could have different permissions causing the
> check to fail.
>
> Tested with building and booting kernel from source on the target
>
> [YOCTO #12137]
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb
> b/meta/recipes-kernel/linux/kernel-devsrc.bb
> index c1b5b7786d7..d925a33aeb1 100644
> --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> @@ -52,7 +52,7 @@ do_install() {
>          # The main build artifacts. We clean the directory to avoid QA
> errors on mismatched
>          # architecture (since scripts and helpers are native format).
>          KBUILD_OUTPUT="$kerneldir"
> -        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}"
> clean _mrproper_scripts
> +        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}"
> clean mrproper
>          # make clean generates an absolute path symlink called "source"
>          # in $kerneldir points to $kerneldir, which doesn't make any
>          # sense, so remove it.
> --
> 2.13.6
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3093 bytes --]

Re: [PATCH] kernel-devsrc: Use full mrproper to clean

[Saul Wold]

On Tue, 2017-12-12 at 11:57 +0000, Burton, Ross wrote:
> This breaks some of the sanity tests, which build a kernel module:
> 
> https://autobuilder.yocto.io/builders/nightly-x86-64/builds/664
> 
Interesting, I did a local build of a kernel module as well as a full
build of the kernel with out failure, I will investigate the oe-
selftest failure.

Sau!

> Ross
> 
> On 5 December 2017 at 23:00, Saul Wold <sgw@linux.intel.com> wrote:
> > By using the full mrproper clean target it also removes some
> > generated files
> > that are not required on the target to build. It also helps to fix
> > reprodudible
> > builds as the generated files could have different permissions
> > causing the
> > check to fail.
> > 
> > Tested with building and booting kernel from source on the target
> > 
> > [YOCTO #12137]
> > 
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> >  meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > index c1b5b7786d7..d925a33aeb1 100644
> > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > @@ -52,7 +52,7 @@ do_install() {
> >          # The main build artifacts. We clean the directory to
> > avoid QA errors on mismatched
> >          # architecture (since scripts and helpers are native
> > format).
> >          KBUILD_OUTPUT="$kerneldir"
> > -        oe_runmake -C $kerneldir CC="${KERNEL_CC}"
> > LD="${KERNEL_LD}" clean _mrproper_scripts
> > +        oe_runmake -C $kerneldir CC="${KERNEL_CC}"
> > LD="${KERNEL_LD}" clean mrproper
> >          # make clean generates an absolute path symlink called
> > "source"
> >          # in $kerneldir points to $kerneldir, which doesn't make
> > any
> >          # sense, so remove it.
> > --
> > 2.13.6
> > 
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
>