Re: bash: add missing build dependencies for ptest

Re: bash: add missing build dependencies for ptest

[Denys Dmytriyenko]

Somehow, below change was never sent or discussed on the list - can't seem to 
find it.

Does this mean bash always requires glibc-locale built, even if I don't use 
ptest or enable locale?

-- 
Denys



commit 2820a2c530018f59895fb57770caa8511d31afd4
Author: Ross Burton <ross.burton@intel.com>
Date:   Fri Oct 13 14:52:16 2017 +0100

    bash: add missing build dependencies for ptest
    
    Signed-off-by: Ross Burton <ross.burton@intel.com>

diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
index f8a92b5..f4e1f7a 100644
--- a/meta/recipes-extended/bash/bash.inc
+++ b/meta/recipes-extended/bash/bash.inc
@@ -24,7 +24,9 @@ ALTERNATIVE_PRIORITY = "100"
 RDEPENDS_${PN} += "base-files"
 RDEPENDS_${PN}_class-nativesdk = ""
 RDEPENDS_${PN}-ptest += "make"
-RDEPENDS_${PN}-ptest_append_libc-glibc += " locale-base-fr-fr locale-base-de-de"
+
+DEPENDS_append_libc-glibc = " glibc-locale"
+RDEPENDS_${PN}-ptest_append_libc-glibc = " locale-base-fr-fr locale-base-de-de"
 
 USERADD_PACKAGES = "${PN}-ptest"
 USERADD_PARAM_${PN}-ptest = "--create-home --user-group test"

Re: bash: add missing build dependencies for ptest

[Denys Dmytriyenko]

I believe below DEPENDS line should actually refer "virtual/libc-locale" 
instead of directly "glibc-locale":

http://cgit.openembedded.org/openembedded-core/tree/meta/conf/distro/include/tclibc-glibc.inc


On Mon, Jan 08, 2018 at 08:57:38PM -0500, Denys Dmytriyenko wrote:
> Somehow, below change was never sent or discussed on the list - can't seem to 
> find it.
> 
> Does this mean bash always requires glibc-locale built, even if I don't use 
> ptest or enable locale?
> 
> -- 
> Denys
> 
> 
> 
> commit 2820a2c530018f59895fb57770caa8511d31afd4
> Author: Ross Burton <ross.burton@intel.com>
> Date:   Fri Oct 13 14:52:16 2017 +0100
> 
>     bash: add missing build dependencies for ptest
>     
>     Signed-off-by: Ross Burton <ross.burton@intel.com>
> 
> diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
> index f8a92b5..f4e1f7a 100644
> --- a/meta/recipes-extended/bash/bash.inc
> +++ b/meta/recipes-extended/bash/bash.inc
> @@ -24,7 +24,9 @@ ALTERNATIVE_PRIORITY = "100"
>  RDEPENDS_${PN} += "base-files"
>  RDEPENDS_${PN}_class-nativesdk = ""
>  RDEPENDS_${PN}-ptest += "make"
> -RDEPENDS_${PN}-ptest_append_libc-glibc += " locale-base-fr-fr locale-base-de-de"
> +
> +DEPENDS_append_libc-glibc = " glibc-locale"
> +RDEPENDS_${PN}-ptest_append_libc-glibc = " locale-base-fr-fr locale-base-de-de"
>  
>  USERADD_PACKAGES = "${PN}-ptest"
>  USERADD_PARAM_${PN}-ptest = "--create-home --user-group test"
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core