Re: kernel-yocto: create dummy git user if necessary

[Justin Bronder <jsbronder@cold-front.org>]

On 09/02/18 15:27 -0500, Bruce Ashfield wrote:
> On Fri, Feb 9, 2018 at 2:53 PM, Justin Bronder <jsbronder@cold-front.org> wrote:
> > The user's global git configuration may not have the name and email set
> > and git autodetection can fail.  The initialization commit for a non-git
> > kernel directory doesn't really need to be tied back to them anyways.
> > Instead, create a user and email that's clearly tied back to
> > kernel-yocto.bbclass.
> >
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> >  meta/classes/kernel-yocto.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> > index 60979a218f..dbf01f86b6 100644
> > --- a/meta/classes/kernel-yocto.bbclass
> > +++ b/meta/classes/kernel-yocto.bbclass
> > @@ -247,6 +247,8 @@ do_kernel_checkout() {
> >                 fi
> >                 rm -f .gitignore
> >                 git init
> > +               git config user.name 'Yocto Kernel Git Initializer'
> > +               git config user.email 'kernel-yocto.bbclass@invalid'
> 
> 
> This is already handled in the utility classes via the
> check_git_config routine and it is called in
> kernel-yocto's do_patch routine.
> 
> If it is needed earlier (as it appears it is), move that call to
> do_kernel_checkout.

Ah, didn't see that.  Thanks.  I'll send a new patch shortly.

-- 
Justin Bronder