* [PATCH] kernel-yocto: create dummy git user if necessary
@ 2018-02-09 19:53 Justin Bronder
2018-02-09 20:27 ` Bruce Ashfield
0 siblings, 1 reply; 3+ messages in thread
From: Justin Bronder @ 2018-02-09 19:53 UTC (permalink / raw)
To: openembedded-core
The user's global git configuration may not have the name and email set
and git autodetection can fail. The initialization commit for a non-git
kernel directory doesn't really need to be tied back to them anyways.
Instead, create a user and email that's clearly tied back to
kernel-yocto.bbclass.
Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
---
meta/classes/kernel-yocto.bbclass | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 60979a218f..dbf01f86b6 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -247,6 +247,8 @@ do_kernel_checkout() {
fi
rm -f .gitignore
git init
+ git config user.name 'Yocto Kernel Git Initializer'
+ git config user.email 'kernel-yocto.bbclass@invalid'
git add .
git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
git clean -d -f
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] kernel-yocto: create dummy git user if necessary
2018-02-09 19:53 [PATCH] kernel-yocto: create dummy git user if necessary Justin Bronder
@ 2018-02-09 20:27 ` Bruce Ashfield
2018-02-09 20:38 ` Justin Bronder
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Ashfield @ 2018-02-09 20:27 UTC (permalink / raw)
To: Justin Bronder; +Cc: Patches and discussions about the oe-core layer
On Fri, Feb 9, 2018 at 2:53 PM, Justin Bronder <jsbronder@cold-front.org> wrote:
> The user's global git configuration may not have the name and email set
> and git autodetection can fail. The initialization commit for a non-git
> kernel directory doesn't really need to be tied back to them anyways.
> Instead, create a user and email that's clearly tied back to
> kernel-yocto.bbclass.
>
> Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> ---
> meta/classes/kernel-yocto.bbclass | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index 60979a218f..dbf01f86b6 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -247,6 +247,8 @@ do_kernel_checkout() {
> fi
> rm -f .gitignore
> git init
> + git config user.name 'Yocto Kernel Git Initializer'
> + git config user.email 'kernel-yocto.bbclass@invalid'
This is already handled in the utility classes via the
check_git_config routine and it is called in
kernel-yocto's do_patch routine.
If it is needed earlier (as it appears it is), move that call to
do_kernel_checkout.
Bruce
> git add .
> git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
> git clean -d -f
> --
> 2.13.6
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: kernel-yocto: create dummy git user if necessary
2018-02-09 20:27 ` Bruce Ashfield
@ 2018-02-09 20:38 ` Justin Bronder
0 siblings, 0 replies; 3+ messages in thread
From: Justin Bronder @ 2018-02-09 20:38 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
On 09/02/18 15:27 -0500, Bruce Ashfield wrote:
> On Fri, Feb 9, 2018 at 2:53 PM, Justin Bronder <jsbronder@cold-front.org> wrote:
> > The user's global git configuration may not have the name and email set
> > and git autodetection can fail. The initialization commit for a non-git
> > kernel directory doesn't really need to be tied back to them anyways.
> > Instead, create a user and email that's clearly tied back to
> > kernel-yocto.bbclass.
> >
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> > meta/classes/kernel-yocto.bbclass | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> > index 60979a218f..dbf01f86b6 100644
> > --- a/meta/classes/kernel-yocto.bbclass
> > +++ b/meta/classes/kernel-yocto.bbclass
> > @@ -247,6 +247,8 @@ do_kernel_checkout() {
> > fi
> > rm -f .gitignore
> > git init
> > + git config user.name 'Yocto Kernel Git Initializer'
> > + git config user.email 'kernel-yocto.bbclass@invalid'
>
>
> This is already handled in the utility classes via the
> check_git_config routine and it is called in
> kernel-yocto's do_patch routine.
>
> If it is needed earlier (as it appears it is), move that call to
> do_kernel_checkout.
Ah, didn't see that. Thanks. I'll send a new patch shortly.
--
Justin Bronder
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-09 20:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-09 19:53 [PATCH] kernel-yocto: create dummy git user if necessary Justin Bronder
2018-02-09 20:27 ` Bruce Ashfield
2018-02-09 20:38 ` Justin Bronder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox