Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Justin Bronder <jsbronder@cold-front.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: ccache: update to 3.4.1
Date: Wed, 7 Mar 2018 10:59:47 -0500	[thread overview]
Message-ID: <20180307155947.GN23655@lasswell> (raw)
In-Reply-To: <21925259-562a-78b6-8616-9345bcfee525@gmail.com>

On 02/03/18 19:14 -0800, Khem Raj wrote:
> On 3/2/18 2:09 PM, Justin Bronder wrote:
> > https://ccache.samba.org/releasenotes.html#_ccache_3_4_1
> > 
> > License-Update: copyright years and file paths updated
> > 
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> >  meta/recipes-devtools/ccache/ccache_3.3.5.bb | 12 ------------
> >  meta/recipes-devtools/ccache/ccache_3.4.1.bb | 12 ++++++++++++
> >  2 files changed, 12 insertions(+), 12 deletions(-)
> >  delete mode 100644 meta/recipes-devtools/ccache/ccache_3.3.5.bb
> >  create mode 100644 meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > 
> > diff --git a/meta/recipes-devtools/ccache/ccache_3.3.5.bb b/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > deleted file mode 100644
> > index 929f0f1276..0000000000
> > --- a/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > +++ /dev/null
> > @@ -1,12 +0,0 @@
> > -require ccache.inc
> > -
> > -LICENSE = "GPLv3+"
> > -LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=dae379a85bb6e9d594773e0aa64876f6"
> > -
> > -SRC_URI[md5sum] = "eee58db7cce892febddb989308dc568f"
> > -SRC_URI[sha256sum] = "190576a6e938760ec8113523e6fd380141117303e90766cc4802e770422b30c6"
> > -
> > -SRC_URI += " \
> > -            file://0002-dev.mk.in-fix-file-name-too-long.patch \
> > -            file://Revert-Create-man-page-in-the-make-install-from-git-.patch \
> > -"
> > diff --git a/meta/recipes-devtools/ccache/ccache_3.4.1.bb b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > new file mode 100644
> > index 0000000000..e3bf74e9c6
> > --- /dev/null
> > +++ b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > @@ -0,0 +1,12 @@
> > +require ccache.inc
> > +
> > +LICENSE = "GPLv3+"
> > +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=4fa0d99234a05c3a32d380379d5d064a"
> 
> 
> it seems checksum changed. So please add a short description what
> changed in license terms.

Was the included License-Update tag not enough?  It really is just an update to
the years and dealing with some files moving around in the repo.

> 
> Secondly, please use options to detect renames to git format-patch so we
> can get better diffs for review
> 
> you can make this default behaviour by adding
> 
> [diff]
>         renames = copies
> 
> to ~/.gitconfig

Thanks, will do.

-- 
Justin Bronder


  reply	other threads:[~2018-03-07 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 22:09 [PATCH v2] ccache: update to 3.4.1 Justin Bronder
2018-03-03  3:14 ` Khem Raj
2018-03-07 15:59   ` Justin Bronder [this message]
2018-03-07 16:10     ` Khem Raj
  -- strict thread matches above, loose matches on Subject: below --
2018-03-02 21:58 [PATCH] " Justin Bronder
2018-03-02 22:06 ` Denys Dmytriyenko
2018-03-02 22:11   ` Justin Bronder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307155947.GN23655@lasswell \
    --to=jsbronder@cold-front.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox