* [PATCH v2] ccache: update to 3.4.1
@ 2018-03-02 22:09 Justin Bronder
2018-03-03 3:14 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Justin Bronder @ 2018-03-02 22:09 UTC (permalink / raw)
To: openembedded-core
https://ccache.samba.org/releasenotes.html#_ccache_3_4_1
License-Update: copyright years and file paths updated
Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
---
meta/recipes-devtools/ccache/ccache_3.3.5.bb | 12 ------------
meta/recipes-devtools/ccache/ccache_3.4.1.bb | 12 ++++++++++++
2 files changed, 12 insertions(+), 12 deletions(-)
delete mode 100644 meta/recipes-devtools/ccache/ccache_3.3.5.bb
create mode 100644 meta/recipes-devtools/ccache/ccache_3.4.1.bb
diff --git a/meta/recipes-devtools/ccache/ccache_3.3.5.bb b/meta/recipes-devtools/ccache/ccache_3.3.5.bb
deleted file mode 100644
index 929f0f1276..0000000000
--- a/meta/recipes-devtools/ccache/ccache_3.3.5.bb
+++ /dev/null
@@ -1,12 +0,0 @@
-require ccache.inc
-
-LICENSE = "GPLv3+"
-LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=dae379a85bb6e9d594773e0aa64876f6"
-
-SRC_URI[md5sum] = "eee58db7cce892febddb989308dc568f"
-SRC_URI[sha256sum] = "190576a6e938760ec8113523e6fd380141117303e90766cc4802e770422b30c6"
-
-SRC_URI += " \
- file://0002-dev.mk.in-fix-file-name-too-long.patch \
- file://Revert-Create-man-page-in-the-make-install-from-git-.patch \
-"
diff --git a/meta/recipes-devtools/ccache/ccache_3.4.1.bb b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
new file mode 100644
index 0000000000..e3bf74e9c6
--- /dev/null
+++ b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
@@ -0,0 +1,12 @@
+require ccache.inc
+
+LICENSE = "GPLv3+"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=4fa0d99234a05c3a32d380379d5d064a"
+
+SRC_URI[md5sum] = "39492aea565c3e6d5affa633672a93bd"
+SRC_URI[sha256sum] = "8c2e260d4245e362552e47bec359941210a96419ac5adf582046ceb92489f7de"
+
+SRC_URI += " \
+ file://0002-dev.mk.in-fix-file-name-too-long.patch \
+ file://Revert-Create-man-page-in-the-make-install-from-git-.patch \
+"
--
2.13.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: ccache: update to 3.4.1
2018-03-02 22:06 ` Denys Dmytriyenko
@ 2018-03-02 22:11 ` Justin Bronder
0 siblings, 0 replies; 5+ messages in thread
From: Justin Bronder @ 2018-03-02 22:11 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: openembedded-core
On 02/03/18 17:06 -0500, Denys Dmytriyenko wrote:
> On Fri, Mar 02, 2018 at 04:58:17PM -0500, Justin Bronder wrote:
> > https://ccache.samba.org/releasenotes.html#_ccache_3_4_1
> >
> > License-Update: copyright years and file paths updated
> >
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> > meta/recipes-devtools/ccache/ccache_3.3.4.bb | 12 ------------
> > meta/recipes-devtools/ccache/ccache_3.4.1.bb | 12 ++++++++++++
>
> Please use -C/-M (--find-copies/--find-renames) flags to simplify review.
Sorry, I will do so in the future.
Note that I did just send a v2 fixing the patchtest failure prior to seeing this
email.
--
Justin Bronder
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ccache: update to 3.4.1
2018-03-02 22:09 [PATCH v2] ccache: update to 3.4.1 Justin Bronder
@ 2018-03-03 3:14 ` Khem Raj
2018-03-07 15:59 ` Justin Bronder
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2018-03-03 3:14 UTC (permalink / raw)
To: Justin Bronder, openembedded-core
On 3/2/18 2:09 PM, Justin Bronder wrote:
> https://ccache.samba.org/releasenotes.html#_ccache_3_4_1
>
> License-Update: copyright years and file paths updated
>
> Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> ---
> meta/recipes-devtools/ccache/ccache_3.3.5.bb | 12 ------------
> meta/recipes-devtools/ccache/ccache_3.4.1.bb | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 12 deletions(-)
> delete mode 100644 meta/recipes-devtools/ccache/ccache_3.3.5.bb
> create mode 100644 meta/recipes-devtools/ccache/ccache_3.4.1.bb
>
> diff --git a/meta/recipes-devtools/ccache/ccache_3.3.5.bb b/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> deleted file mode 100644
> index 929f0f1276..0000000000
> --- a/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -require ccache.inc
> -
> -LICENSE = "GPLv3+"
> -LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=dae379a85bb6e9d594773e0aa64876f6"
> -
> -SRC_URI[md5sum] = "eee58db7cce892febddb989308dc568f"
> -SRC_URI[sha256sum] = "190576a6e938760ec8113523e6fd380141117303e90766cc4802e770422b30c6"
> -
> -SRC_URI += " \
> - file://0002-dev.mk.in-fix-file-name-too-long.patch \
> - file://Revert-Create-man-page-in-the-make-install-from-git-.patch \
> -"
> diff --git a/meta/recipes-devtools/ccache/ccache_3.4.1.bb b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> new file mode 100644
> index 0000000000..e3bf74e9c6
> --- /dev/null
> +++ b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> @@ -0,0 +1,12 @@
> +require ccache.inc
> +
> +LICENSE = "GPLv3+"
> +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=4fa0d99234a05c3a32d380379d5d064a"
it seems checksum changed. So please add a short description what
changed in license terms.
Secondly, please use options to detect renames to git format-patch so we
can get better diffs for review
you can make this default behaviour by adding
[diff]
renames = copies
to ~/.gitconfig
> +
> +SRC_URI[md5sum] = "39492aea565c3e6d5affa633672a93bd"
> +SRC_URI[sha256sum] = "8c2e260d4245e362552e47bec359941210a96419ac5adf582046ceb92489f7de"
> +
> +SRC_URI += " \
> + file://0002-dev.mk.in-fix-file-name-too-long.patch \
> + file://Revert-Create-man-page-in-the-make-install-from-git-.patch \
> +"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ccache: update to 3.4.1
2018-03-03 3:14 ` Khem Raj
@ 2018-03-07 15:59 ` Justin Bronder
2018-03-07 16:10 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Justin Bronder @ 2018-03-07 15:59 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On 02/03/18 19:14 -0800, Khem Raj wrote:
> On 3/2/18 2:09 PM, Justin Bronder wrote:
> > https://ccache.samba.org/releasenotes.html#_ccache_3_4_1
> >
> > License-Update: copyright years and file paths updated
> >
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> > meta/recipes-devtools/ccache/ccache_3.3.5.bb | 12 ------------
> > meta/recipes-devtools/ccache/ccache_3.4.1.bb | 12 ++++++++++++
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> > delete mode 100644 meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > create mode 100644 meta/recipes-devtools/ccache/ccache_3.4.1.bb
> >
> > diff --git a/meta/recipes-devtools/ccache/ccache_3.3.5.bb b/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > deleted file mode 100644
> > index 929f0f1276..0000000000
> > --- a/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > +++ /dev/null
> > @@ -1,12 +0,0 @@
> > -require ccache.inc
> > -
> > -LICENSE = "GPLv3+"
> > -LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=dae379a85bb6e9d594773e0aa64876f6"
> > -
> > -SRC_URI[md5sum] = "eee58db7cce892febddb989308dc568f"
> > -SRC_URI[sha256sum] = "190576a6e938760ec8113523e6fd380141117303e90766cc4802e770422b30c6"
> > -
> > -SRC_URI += " \
> > - file://0002-dev.mk.in-fix-file-name-too-long.patch \
> > - file://Revert-Create-man-page-in-the-make-install-from-git-.patch \
> > -"
> > diff --git a/meta/recipes-devtools/ccache/ccache_3.4.1.bb b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > new file mode 100644
> > index 0000000000..e3bf74e9c6
> > --- /dev/null
> > +++ b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > @@ -0,0 +1,12 @@
> > +require ccache.inc
> > +
> > +LICENSE = "GPLv3+"
> > +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=4fa0d99234a05c3a32d380379d5d064a"
>
>
> it seems checksum changed. So please add a short description what
> changed in license terms.
Was the included License-Update tag not enough? It really is just an update to
the years and dealing with some files moving around in the repo.
>
> Secondly, please use options to detect renames to git format-patch so we
> can get better diffs for review
>
> you can make this default behaviour by adding
>
> [diff]
> renames = copies
>
> to ~/.gitconfig
Thanks, will do.
--
Justin Bronder
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ccache: update to 3.4.1
2018-03-07 15:59 ` Justin Bronder
@ 2018-03-07 16:10 ` Khem Raj
0 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2018-03-07 16:10 UTC (permalink / raw)
To: Justin Bronder; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2681 bytes --]
On Wed, Mar 7, 2018 at 7:59 AM Justin Bronder <jsbronder@cold-front.org>
wrote:
> On 02/03/18 19:14 -0800, Khem Raj wrote:
> > On 3/2/18 2:09 PM, Justin Bronder wrote:
> > > https://ccache.samba.org/releasenotes.html#_ccache_3_4_1
> > >
> > > License-Update: copyright years and file paths updated
> > >
> > > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > > ---
> > > meta/recipes-devtools/ccache/ccache_3.3.5.bb | 12 ------------
> > > meta/recipes-devtools/ccache/ccache_3.4.1.bb | 12 ++++++++++++
> > > 2 files changed, 12 insertions(+), 12 deletions(-)
> > > delete mode 100644 meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > > create mode 100644 meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > >
> > > diff --git a/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> b/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > > deleted file mode 100644
> > > index 929f0f1276..0000000000
> > > --- a/meta/recipes-devtools/ccache/ccache_3.3.5.bb
> > > +++ /dev/null
> > > @@ -1,12 +0,0 @@
> > > -require ccache.inc
> > > -
> > > -LICENSE = "GPLv3+"
> > > -LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=dae379a85bb6e9d594773e0aa64876f6"
> > > -
> > > -SRC_URI[md5sum] = "eee58db7cce892febddb989308dc568f"
> > > -SRC_URI[sha256sum] =
> "190576a6e938760ec8113523e6fd380141117303e90766cc4802e770422b30c6"
> > > -
> > > -SRC_URI += " \
> > > - file://0002-dev.mk.in-fix-file-name-too-long.patch \
> > > -
> file://Revert-Create-man-page-in-the-make-install-from-git-.patch \
> > > -"
> > > diff --git a/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > > new file mode 100644
> > > index 0000000000..e3bf74e9c6
> > > --- /dev/null
> > > +++ b/meta/recipes-devtools/ccache/ccache_3.4.1.bb
> > > @@ -0,0 +1,12 @@
> > > +require ccache.inc
> > > +
> > > +LICENSE = "GPLv3+"
> > > +LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=4fa0d99234a05c3a32d380379d5d064a"
> >
> >
> > it seems checksum changed. So please add a short description what
> > changed in license terms.
>
> Was the included License-Update tag not enough? It really is just an
> update to
> the years and dealing with some files moving around in the repo.
It is now when I look hard but I missed it last time another reason to make
it detect renames so we have less to look at
>
>
> >
> > Secondly, please use options to detect renames to git format-patch so we
> > can get better diffs for review
> >
> > you can make this default behaviour by adding
> >
> > [diff]
> > renames = copies
> >
> > to ~/.gitconfig
>
> Thanks, will do.
>
> --
> Justin Bronder
>
[-- Attachment #2: Type: text/html, Size: 4439 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-07 16:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-02 22:09 [PATCH v2] ccache: update to 3.4.1 Justin Bronder
2018-03-03 3:14 ` Khem Raj
2018-03-07 15:59 ` Justin Bronder
2018-03-07 16:10 ` Khem Raj
-- strict thread matches above, loose matches on Subject: below --
2018-03-02 21:58 [PATCH] " Justin Bronder
2018-03-02 22:06 ` Denys Dmytriyenko
2018-03-02 22:11 ` Justin Bronder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox