[PATCH] kernel-fitimage.bbclass: Deploy fitImage without Initramfs

[PATCH] kernel-fitimage.bbclass: Deploy fitImage without Initramfs

[Vineeth Chowdary Karumanchi]

This patch deploys fitImage (linux.bin + dtb ).
The use case is to have 2 partioned sd card, with
FAT partition having bootloader + fitImage and
ext4 partion having rootfs.

Signen-off-by: Vineeth Chowdary Karumanchi <vineethchowz.chowdary@xilinx.com>
---
 meta/classes/kernel-fitimage.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index 50a91e1..25884d5 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -464,6 +464,10 @@ kernel_do_deploy_append() {
                linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
                linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
                install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin
+               fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}-${DATETIME}"
+               fitimage_symlink_name=fitImage-${MACHINE}
+               install -m 0644 arch/${ARCH}/boot/fitImage ${DEPLOYDIR}/${fitimage_base_name}.bin
+

                if [ -n "${INITRAMFS_IMAGE}" ]; then
                        echo "Copying fit-image-${INITRAMFS_IMAGE}.its source file..."
@@ -478,6 +482,7 @@ kernel_do_deploy_append() {
                cd ${DEPLOYDIR}
                ln -sf ${its_base_name}.its ${its_symlink_name}.its
                ln -sf ${linux_bin_base_name}.bin ${linux_bin_symlink_name}.bin
+               ln -sf ${fitimage_base_name}.bin ${fitimage_symlink_name}.bin

                if [ -n "${INITRAMFS_IMAGE}" ]; then
                        ln -sf ${its_initramfs_base_name}.its ${its_initramfs_symlink_name}.its
--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

✗ patchtest: failure for kernel-fitimage.bbclass: Deploy fitImage without Initramfs

[Patchwork]

== Series Details ==

Series: kernel-fitimage.bbclass: Deploy fitImage without Initramfs
Revision: 1
URL   : https://patchwork.openembedded.org/series/11297/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at b8ddb0c8d7)

* Patch            kernel-fitimage.bbclass: Deploy fitImage without Initramfs
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] kernel-fitimage.bbclass: Deploy fitImage without Initramfs

[Martin Hundebøll]

Hi Vineeth,

On 2018-03-07 15:41, Vineeth Chowdary Karumanchi wrote:
> This patch deploys fitImage (linux.bin + dtb ).
> The use case is to have 2 partioned sd card, with
> FAT partition having bootloader + fitImage and
> ext4 partion having rootfs.
> 
> Signen-off-by: Vineeth Chowdary Karumanchi <vineethchowz.chowdary@xilinx.com>
> ---
>   meta/classes/kernel-fitimage.bbclass | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 50a91e1..25884d5 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -464,6 +464,10 @@ kernel_do_deploy_append() {
>                  linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
>                  linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
>                  install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin
> +               fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}-${DATETIME}"
> +               fitimage_symlink_name=fitImage-${MACHINE}
> +               install -m 0644 arch/${ARCH}/boot/fitImage ${DEPLOYDIR}/${fitimage_base_name}.bin
> +

Isn't this already handled by the "linux_bin_base_name" variable just 
above (i.e. fitImahe-linux.bin-${MACHINE}). I have various fitimages, 
and as far as I recall, a non-initramfs fitimage is already deployed.

// Martin

Re: [PATCH] kernel-fitimage.bbclass: Deploy fitImage without Initramfs

[Manjukumar Harthikote Matha]

Hi Martin,

> -----Original Message-----
> From: Martin Hundebøll [mailto:mnhu@prevas.dk]
> Sent: Wednesday, March 07, 2018 11:26 PM
> To: Vineeth Karumanchi <VINEETHC@xilinx.com>; openembedded-
> core@lists.openembedded.org; Manjukumar Harthikote Matha
> <MANJUKUM@xilinx.com>
> Subject: Re: [OE-core] [PATCH] kernel-fitimage.bbclass: Deploy fitImage without
> Initramfs
> 
> Hi Vineeth,
> 
> On 2018-03-07 15:41, Vineeth Chowdary Karumanchi wrote:
> > This patch deploys fitImage (linux.bin + dtb ).
> > The use case is to have 2 partioned sd card, with FAT partition having
> > bootloader + fitImage and
> > ext4 partion having rootfs.
> >
> > Signen-off-by: Vineeth Chowdary Karumanchi
> > <vineethchowz.chowdary@xilinx.com>
> > ---
> >   meta/classes/kernel-fitimage.bbclass | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/classes/kernel-fitimage.bbclass
> > b/meta/classes/kernel-fitimage.bbclass
> > index 50a91e1..25884d5 100644
> > --- a/meta/classes/kernel-fitimage.bbclass
> > +++ b/meta/classes/kernel-fitimage.bbclass
> > @@ -464,6 +464,10 @@ kernel_do_deploy_append() {
> >                  linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-
> ${DATETIME}"
> >                  linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
> >                  install -m 0644 linux.bin
> > ${DEPLOYDIR}/${linux_bin_base_name}.bin
> > +               fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}-
> ${DATETIME}"
> > +               fitimage_symlink_name=fitImage-${MACHINE}
> > +               install -m 0644 arch/${ARCH}/boot/fitImage
> > + ${DEPLOYDIR}/${fitimage_base_name}.bin
> > +
> 
> Isn't this already handled by the "linux_bin_base_name" variable just above (i.e.
> fitImahe-linux.bin-${MACHINE}). I have various fitimages, and as far as I recall, a
> non-initramfs fitimage is already deployed.
> 
This patch seems to do the right thing.

linux.bin is being copied as fitImage-linux.bin-${MACHINE} , and I think it is incorrect.
It should be fitImage, which is generated in do_assemble_fitimage

If you look at initramfs case:
install -m 0644 arch/${ARCH}/boot/fitImage-${INITRAMFS_IMAGE} ${DEPLOYDIR}/${fit_initramfs_base_name}.bin which is correct

Thanks,
Manju

Re: [PATCH] kernel-fitimage.bbclass: Deploy fitImage without Initramfs

[Vineeth Karumanchi]

Hi Martin,


On 03/08/2018 01:25 PM, Manjukumar Harthikote Matha wrote:
> Hi Martin,
> 
>> -----Original Message-----
>> From: Martin Hundebøll [mailto:mnhu@prevas.dk]
>> Sent: Wednesday, March 07, 2018 11:26 PM
>> To: Vineeth Karumanchi <VINEETHC@xilinx.com>; openembedded-
>> core@lists.openembedded.org; Manjukumar Harthikote Matha
>> <MANJUKUM@xilinx.com>
>> Subject: Re: [OE-core] [PATCH] kernel-fitimage.bbclass: Deploy fitImage without
>> Initramfs
>>
>> Hi Vineeth,
>>
>> On 2018-03-07 15:41, Vineeth Chowdary Karumanchi wrote:
>>> This patch deploys fitImage (linux.bin + dtb ).
>>> The use case is to have 2 partioned sd card, with FAT partition having
>>> bootloader + fitImage and
>>> ext4 partion having rootfs.
>>>
>>> Signen-off-by: Vineeth Chowdary Karumanchi
>>> <vineethchowz.chowdary@xilinx.com>
>>> ---
>>>    meta/classes/kernel-fitimage.bbclass | 5 +++++
>>>    1 file changed, 5 insertions(+)
>>>
>>> diff --git a/meta/classes/kernel-fitimage.bbclass
>>> b/meta/classes/kernel-fitimage.bbclass
>>> index 50a91e1..25884d5 100644
>>> --- a/meta/classes/kernel-fitimage.bbclass
>>> +++ b/meta/classes/kernel-fitimage.bbclass
>>> @@ -464,6 +464,10 @@ kernel_do_deploy_append() {
>>>                   linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-
>> ${DATETIME}"
>>>                   linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
>>>                   install -m 0644 linux.bin
>>> ${DEPLOYDIR}/${linux_bin_base_name}.bin
>>> +               fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}-
>> ${DATETIME}"
>>> +               fitimage_symlink_name=fitImage-${MACHINE}
>>> +               install -m 0644 arch/${ARCH}/boot/fitImage
>>> + ${DEPLOYDIR}/${fitimage_base_name}.bin
>>> +
>>
>> Isn't this already handled by the "linux_bin_base_name" variable just above (i.e.
>> fitImahe-linux.bin-${MACHINE}).

It is linux.bin which is generated at the time of fitImage creation.

- linux.bin and arch/${ARCH}/boot/fitImage differ,
- uboot fails to recognise linux.bin
- arch/${ARCH}/boot/fitImage is the fitimage.

Thanks
VIneeth

>> I have various fitimages, and as far as I recall, a
>> non-initramfs fitimage is already deployed.
>>
> This patch seems to do the right thing.
> 
> linux.bin is being copied as fitImage-linux.bin-${MACHINE} , and I think it is incorrect.
> It should be fitImage, which is generated in do_assemble_fitimage
> 
> If you look at initramfs case:
> install -m 0644 arch/${ARCH}/boot/fitImage-${INITRAMFS_IMAGE} ${DEPLOYDIR}/${fit_initramfs_base_name}.bin which is correct
> 
> Thanks,
> Manju
>