* [PATCH] image_types: use pigz to create .gz files @ 2018-04-10 14:35 Ross Burton 2018-04-11 10:53 ` Martin Jansa 0 siblings, 1 reply; 8+ messages in thread From: Ross Burton @ 2018-04-10 14:35 UTC (permalink / raw) To: openembedded-core Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b) the image creation has been using gzip instead of pigz, despite still depending on pigz-native. Fix this by invoking pigz explicitly. Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/classes/image_types.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass index e872ae20982..00a00d318f4 100644 --- a/meta/classes/image_types.bbclass +++ b/meta/classes/image_types.bbclass @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= "" CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 ${COMPRESSIONTYPES}" CONVERSION_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" -CONVERSION_CMD_gz = "gzip -f -9 -n -c ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" +CONVERSION_CMD_gz = "pigz -f -9 -n -c ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" CONVERSION_CMD_bz2 = "pbzip2 -f -k ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS} --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz" CONVERSION_CMD_lz4 = "lz4 -9 -z -l ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4" -- 2.11.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] image_types: use pigz to create .gz files 2018-04-10 14:35 [PATCH] image_types: use pigz to create .gz files Ross Burton @ 2018-04-11 10:53 ` Martin Jansa 2018-04-11 13:36 ` Burton, Ross 0 siblings, 1 reply; 8+ messages in thread From: Martin Jansa @ 2018-04-11 10:53 UTC (permalink / raw) To: Ross Burton; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 1941 bytes --] What about using pigz for sstate-cache archives? On Tue, Apr 10, 2018 at 4:35 PM, Ross Burton <ross.burton@intel.com> wrote: > Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b) > the > image creation has been using gzip instead of pigz, despite still > depending on > pigz-native. Fix this by invoking pigz explicitly. > > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/classes/image_types.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types. > bbclass > index e872ae20982..00a00d318f4 100644 > --- a/meta/classes/image_types.bbclass > +++ b/meta/classes/image_types.bbclass > @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= "" > > CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum > sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 > ${COMPRESSIONTYPES}" > CONVERSION_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}${IMAGE_NAME_ > SUFFIX}.${type}" > -CONVERSION_CMD_gz = "gzip -f -9 -n -c ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" > +CONVERSION_CMD_gz = "pigz -f -9 -n -c ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" > CONVERSION_CMD_bz2 = "pbzip2 -f -k ${IMAGE_NAME}${IMAGE_NAME_ > SUFFIX}.${type}" > CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS} > --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz" > CONVERSION_CMD_lz4 = "lz4 -9 -z -l ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4" > -- > 2.11.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > [-- Attachment #2: Type: text/html, Size: 2727 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] image_types: use pigz to create .gz files 2018-04-11 10:53 ` Martin Jansa @ 2018-04-11 13:36 ` Burton, Ross 2018-04-11 16:03 ` Khem Raj 2018-04-13 12:07 ` Richard Purdie 0 siblings, 2 replies; 8+ messages in thread From: Burton, Ross @ 2018-04-11 13:36 UTC (permalink / raw) To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer Wouldn't that introduce a fun circular dependency if pigz-native needs to be built? Ross On 11 April 2018 at 11:53, Martin Jansa <martin.jansa@gmail.com> wrote: > What about using pigz for sstate-cache archives? > > On Tue, Apr 10, 2018 at 4:35 PM, Ross Burton <ross.burton@intel.com> wrote: >> >> Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b) >> the >> image creation has been using gzip instead of pigz, despite still >> depending on >> pigz-native. Fix this by invoking pigz explicitly. >> >> Signed-off-by: Ross Burton <ross.burton@intel.com> >> --- >> meta/classes/image_types.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/classes/image_types.bbclass >> b/meta/classes/image_types.bbclass >> index e872ae20982..00a00d318f4 100644 >> --- a/meta/classes/image_types.bbclass >> +++ b/meta/classes/image_types.bbclass >> @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= "" >> >> CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum >> sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 >> ${COMPRESSIONTYPES}" >> CONVERSION_CMD_lzma = "lzma -k -f -7 >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >> -CONVERSION_CMD_gz = "gzip -f -9 -n -c >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >> +CONVERSION_CMD_gz = "pigz -f -9 -n -c >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >> CONVERSION_CMD_bz2 = "pbzip2 -f -k >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >> CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS} >> --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz" >> CONVERSION_CMD_lz4 = "lz4 -9 -z -l >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} >> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4" >> -- >> 2.11.0 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] image_types: use pigz to create .gz files 2018-04-11 13:36 ` Burton, Ross @ 2018-04-11 16:03 ` Khem Raj 2018-04-11 16:07 ` Burton, Ross 2018-04-13 12:07 ` Richard Purdie 1 sibling, 1 reply; 8+ messages in thread From: Khem Raj @ 2018-04-11 16:03 UTC (permalink / raw) To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer On Wed, Apr 11, 2018 at 6:36 AM, Burton, Ross <ross.burton@intel.com> wrote: > Wouldn't that introduce a fun circular dependency if pigz-native needs > to be built? > interesting idea certainly, if it ends up with improvements in build time, we could add pigz to host dependencies. > Ross > > On 11 April 2018 at 11:53, Martin Jansa <martin.jansa@gmail.com> wrote: >> What about using pigz for sstate-cache archives? >> >> On Tue, Apr 10, 2018 at 4:35 PM, Ross Burton <ross.burton@intel.com> wrote: >>> >>> Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b) >>> the >>> image creation has been using gzip instead of pigz, despite still >>> depending on >>> pigz-native. Fix this by invoking pigz explicitly. >>> >>> Signed-off-by: Ross Burton <ross.burton@intel.com> >>> --- >>> meta/classes/image_types.bbclass | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/classes/image_types.bbclass >>> b/meta/classes/image_types.bbclass >>> index e872ae20982..00a00d318f4 100644 >>> --- a/meta/classes/image_types.bbclass >>> +++ b/meta/classes/image_types.bbclass >>> @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= "" >>> >>> CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum >>> sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 >>> ${COMPRESSIONTYPES}" >>> CONVERSION_CMD_lzma = "lzma -k -f -7 >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >>> -CONVERSION_CMD_gz = "gzip -f -9 -n -c >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >>> +CONVERSION_CMD_gz = "pigz -f -9 -n -c >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >>> CONVERSION_CMD_bz2 = "pbzip2 -f -k >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >>> CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS} >>> --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz" >>> CONVERSION_CMD_lz4 = "lz4 -9 -z -l >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} >>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4" >>> -- >>> 2.11.0 >>> >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >> > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] image_types: use pigz to create .gz files 2018-04-11 16:03 ` Khem Raj @ 2018-04-11 16:07 ` Burton, Ross 2018-04-12 1:19 ` Denys Dmytriyenko 0 siblings, 1 reply; 8+ messages in thread From: Burton, Ross @ 2018-04-11 16:07 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer Woud be interesting to see a benchmark of a full build from scratch with host gzip vs host pigz... On 11 April 2018 at 17:03, Khem Raj <raj.khem@gmail.com> wrote: > On Wed, Apr 11, 2018 at 6:36 AM, Burton, Ross <ross.burton@intel.com> wrote: >> Wouldn't that introduce a fun circular dependency if pigz-native needs >> to be built? >> > > interesting idea certainly, if it ends up with improvements in build > time, we could > add pigz to host dependencies. > >> Ross >> >> On 11 April 2018 at 11:53, Martin Jansa <martin.jansa@gmail.com> wrote: >>> What about using pigz for sstate-cache archives? >>> >>> On Tue, Apr 10, 2018 at 4:35 PM, Ross Burton <ross.burton@intel.com> wrote: >>>> >>>> Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b) >>>> the >>>> image creation has been using gzip instead of pigz, despite still >>>> depending on >>>> pigz-native. Fix this by invoking pigz explicitly. >>>> >>>> Signed-off-by: Ross Burton <ross.burton@intel.com> >>>> --- >>>> meta/classes/image_types.bbclass | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/meta/classes/image_types.bbclass >>>> b/meta/classes/image_types.bbclass >>>> index e872ae20982..00a00d318f4 100644 >>>> --- a/meta/classes/image_types.bbclass >>>> +++ b/meta/classes/image_types.bbclass >>>> @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= "" >>>> >>>> CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum >>>> sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 >>>> ${COMPRESSIONTYPES}" >>>> CONVERSION_CMD_lzma = "lzma -k -f -7 >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >>>> -CONVERSION_CMD_gz = "gzip -f -9 -n -c >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >>>> +CONVERSION_CMD_gz = "pigz -f -9 -n -c >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >>>> CONVERSION_CMD_bz2 = "pbzip2 -f -k >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >>>> CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS} >>>> --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz" >>>> CONVERSION_CMD_lz4 = "lz4 -9 -z -l >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4" >>>> -- >>>> 2.11.0 >>>> >>>> -- >>>> _______________________________________________ >>>> Openembedded-core mailing list >>>> Openembedded-core@lists.openembedded.org >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> >>> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] image_types: use pigz to create .gz files 2018-04-11 16:07 ` Burton, Ross @ 2018-04-12 1:19 ` Denys Dmytriyenko 2018-04-12 1:33 ` Khem Raj 0 siblings, 1 reply; 8+ messages in thread From: Denys Dmytriyenko @ 2018-04-12 1:19 UTC (permalink / raw) To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer On Wed, Apr 11, 2018 at 05:07:38PM +0100, Burton, Ross wrote: > Woud be interesting to see a benchmark of a full build from scratch > with host gzip vs host pigz... Is pigz so widely used now to be available in every Linux distro like gzip? > On 11 April 2018 at 17:03, Khem Raj <raj.khem@gmail.com> wrote: > > On Wed, Apr 11, 2018 at 6:36 AM, Burton, Ross <ross.burton@intel.com> wrote: > >> Wouldn't that introduce a fun circular dependency if pigz-native needs > >> to be built? > >> > > > > interesting idea certainly, if it ends up with improvements in build > > time, we could > > add pigz to host dependencies. > > > >> Ross > >> > >> On 11 April 2018 at 11:53, Martin Jansa <martin.jansa@gmail.com> wrote: > >>> What about using pigz for sstate-cache archives? > >>> > >>> On Tue, Apr 10, 2018 at 4:35 PM, Ross Burton <ross.burton@intel.com> wrote: > >>>> > >>>> Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b) > >>>> the > >>>> image creation has been using gzip instead of pigz, despite still > >>>> depending on > >>>> pigz-native. Fix this by invoking pigz explicitly. > >>>> > >>>> Signed-off-by: Ross Burton <ross.burton@intel.com> > >>>> --- > >>>> meta/classes/image_types.bbclass | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/meta/classes/image_types.bbclass > >>>> b/meta/classes/image_types.bbclass > >>>> index e872ae20982..00a00d318f4 100644 > >>>> --- a/meta/classes/image_types.bbclass > >>>> +++ b/meta/classes/image_types.bbclass > >>>> @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= "" > >>>> > >>>> CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum > >>>> sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 > >>>> ${COMPRESSIONTYPES}" > >>>> CONVERSION_CMD_lzma = "lzma -k -f -7 > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" > >>>> -CONVERSION_CMD_gz = "gzip -f -9 -n -c > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" > >>>> +CONVERSION_CMD_gz = "pigz -f -9 -n -c > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" > >>>> CONVERSION_CMD_bz2 = "pbzip2 -f -k > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" > >>>> CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS} > >>>> --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz" > >>>> CONVERSION_CMD_lz4 = "lz4 -9 -z -l > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4" > >>>> -- > >>>> 2.11.0 > >>>> > >>>> -- > >>>> _______________________________________________ > >>>> Openembedded-core mailing list > >>>> Openembedded-core@lists.openembedded.org > >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core > >>> > >>> > >> -- > >> _______________________________________________ > >> Openembedded-core mailing list > >> Openembedded-core@lists.openembedded.org > >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] image_types: use pigz to create .gz files 2018-04-12 1:19 ` Denys Dmytriyenko @ 2018-04-12 1:33 ` Khem Raj 0 siblings, 0 replies; 8+ messages in thread From: Khem Raj @ 2018-04-12 1:33 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: Patches and discussions about the oe-core layer On Wed, Apr 11, 2018 at 6:19 PM, Denys Dmytriyenko <denis@denix.org> wrote: > On Wed, Apr 11, 2018 at 05:07:38PM +0100, Burton, Ross wrote: >> Woud be interesting to see a benchmark of a full build from scratch >> with host gzip vs host pigz... > > Is pigz so widely used now to be available in every Linux distro like gzip? > Tested distros do seem to provide it as old as ubuntu 14.04 and centos 6 xz is another option for sstate archives the extra time it requires might be compensated with threaded run in addition the archives will be smaller > >> On 11 April 2018 at 17:03, Khem Raj <raj.khem@gmail.com> wrote: >> > On Wed, Apr 11, 2018 at 6:36 AM, Burton, Ross <ross.burton@intel.com> wrote: >> >> Wouldn't that introduce a fun circular dependency if pigz-native needs >> >> to be built? >> >> >> > >> > interesting idea certainly, if it ends up with improvements in build >> > time, we could >> > add pigz to host dependencies. >> > >> >> Ross >> >> >> >> On 11 April 2018 at 11:53, Martin Jansa <martin.jansa@gmail.com> wrote: >> >>> What about using pigz for sstate-cache archives? >> >>> >> >>> On Tue, Apr 10, 2018 at 4:35 PM, Ross Burton <ross.burton@intel.com> wrote: >> >>>> >> >>>> Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b) >> >>>> the >> >>>> image creation has been using gzip instead of pigz, despite still >> >>>> depending on >> >>>> pigz-native. Fix this by invoking pigz explicitly. >> >>>> >> >>>> Signed-off-by: Ross Burton <ross.burton@intel.com> >> >>>> --- >> >>>> meta/classes/image_types.bbclass | 2 +- >> >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>>> >> >>>> diff --git a/meta/classes/image_types.bbclass >> >>>> b/meta/classes/image_types.bbclass >> >>>> index e872ae20982..00a00d318f4 100644 >> >>>> --- a/meta/classes/image_types.bbclass >> >>>> +++ b/meta/classes/image_types.bbclass >> >>>> @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= "" >> >>>> >> >>>> CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum >> >>>> sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 >> >>>> ${COMPRESSIONTYPES}" >> >>>> CONVERSION_CMD_lzma = "lzma -k -f -7 >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >> >>>> -CONVERSION_CMD_gz = "gzip -f -9 -n -c >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >> >>>> +CONVERSION_CMD_gz = "pigz -f -9 -n -c >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz" >> >>>> CONVERSION_CMD_bz2 = "pbzip2 -f -k >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" >> >>>> CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS} >> >>>> --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz" >> >>>> CONVERSION_CMD_lz4 = "lz4 -9 -z -l >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} >> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4" >> >>>> -- >> >>>> 2.11.0 >> >>>> >> >>>> -- >> >>>> _______________________________________________ >> >>>> Openembedded-core mailing list >> >>>> Openembedded-core@lists.openembedded.org >> >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >>> >> >>> >> >> -- >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] image_types: use pigz to create .gz files 2018-04-11 13:36 ` Burton, Ross 2018-04-11 16:03 ` Khem Raj @ 2018-04-13 12:07 ` Richard Purdie 1 sibling, 0 replies; 8+ messages in thread From: Richard Purdie @ 2018-04-13 12:07 UTC (permalink / raw) To: Burton, Ross, Martin Jansa Cc: Patches and discussions about the oe-core layer On Wed, 2018-04-11 at 14:36 +0100, Burton, Ross wrote: > Wouldn't that introduce a fun circular dependency if pigz-native > needs > to be built? For the sstate code we could probably make it use pigz if present. We could also only depend on pigz-native for target, or encode the actual pigz-native dependencies. So there may be a few options if its worth the performance win. Cheers, Richard ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-04-13 12:07 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-04-10 14:35 [PATCH] image_types: use pigz to create .gz files Ross Burton 2018-04-11 10:53 ` Martin Jansa 2018-04-11 13:36 ` Burton, Ross 2018-04-11 16:03 ` Khem Raj 2018-04-11 16:07 ` Burton, Ross 2018-04-12 1:19 ` Denys Dmytriyenko 2018-04-12 1:33 ` Khem Raj 2018-04-13 12:07 ` Richard Purdie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox