[PATCH] Only add uninative and checksum if inherited uninative class

[PATCH] Only add uninative and checksum if inherited uninative class

[Jeremy Puhlman]

The checksum value is only calculated if the uninative class is
inherited, so check for inherit before adding it to local.conf

Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
---
 meta/classes/populate_sdk_ext.bbclass | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index e1bba49eaf..8dfb8df52e 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -325,8 +325,9 @@ python copy_buildsystem () {
             f.write('TCLIBCAPPEND = ""\n')
             f.write('DL_DIR = "${TOPDIR}/downloads"\n')
 
-            f.write('INHERIT += "%s"\n' % 'uninative')
-            f.write('UNINATIVE_CHECKSUM[%s] = "%s"\n\n' % (d.getVar('BUILD_ARCH'), uninative_checksum))
+            if bb.data.inherits_class('uninative', d):
+               f.write('INHERIT += "%s"\n' % 'uninative')
+               f.write('UNINATIVE_CHECKSUM[%s] = "%s"\n\n' % (d.getVar('BUILD_ARCH'), uninative_checksum))
             f.write('CONF_VERSION = "%s"\n\n' % d.getVar('CONF_VERSION', False))
 
             # Some classes are not suitable for SDK, remove them from INHERIT
-- 
2.11.1

✗ patchtest: failure for Only add uninative and checksum if inherited uninative class

[Patchwork]

== Series Details ==

Series: Only add uninative and checksum if inherited uninative class
Revision: 1
URL   : https://patchwork.openembedded.org/series/11924/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            Only add uninative and checksum if inherited uninative class
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] Only add uninative and checksum if inherited uninative class

[Jeremy Puhlman]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

Any issue with this patch?

On Wed, Apr 25, 2018 at 2:18 PM, Jeremy Puhlman <jpuhlman@mvista.com> wrote:

> The checksum value is only calculated if the uninative class is
> inherited, so check for inherit before adding it to local.conf
>
> Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
> ---
>  meta/classes/populate_sdk_ext.bbclass | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_ext.bbclass
> b/meta/classes/populate_sdk_ext.bbclass
> index e1bba49eaf..8dfb8df52e 100644
> --- a/meta/classes/populate_sdk_ext.bbclass
> +++ b/meta/classes/populate_sdk_ext.bbclass
> @@ -325,8 +325,9 @@ python copy_buildsystem () {
>              f.write('TCLIBCAPPEND = ""\n')
>              f.write('DL_DIR = "${TOPDIR}/downloads"\n')
>
> -            f.write('INHERIT += "%s"\n' % 'uninative')
> -            f.write('UNINATIVE_CHECKSUM[%s] = "%s"\n\n' %
> (d.getVar('BUILD_ARCH'), uninative_checksum))
> +            if bb.data.inherits_class('uninative', d):
> +               f.write('INHERIT += "%s"\n' % 'uninative')
> +               f.write('UNINATIVE_CHECKSUM[%s] = "%s"\n\n' %
> (d.getVar('BUILD_ARCH'), uninative_checksum))
>              f.write('CONF_VERSION = "%s"\n\n' % d.getVar('CONF_VERSION',
> False))
>
>              # Some classes are not suitable for SDK, remove them from
> INHERIT
> --
> 2.11.1
>
>


-- 
Jeremy Puhlman
Montavista Software, LLC.

[-- Attachment #2: Type: text/html, Size: 2275 bytes --]