Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] toolchain-scripts/meta-ide-support: Handle dash shells correctly
@ 2018-05-04  8:51 Richard Purdie
  2018-05-04  8:51 ` [PATCH 2/2] settings-daemon: Drop pointless apply=yes in SRC_URI Richard Purdie
  2018-05-04  9:02 ` ✗ patchtest: failure for "toolchain-scripts/meta-ide-sup..." and 1 more Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Richard Purdie @ 2018-05-04  8:51 UTC (permalink / raw)
  To: openembedded-core

Where /bin/sh is dash, the recent toolchain scripts change fails as the $(pwd)
usage in oe-init-build-env doesn't function correctly. Fix this by saving
and restoring the cwd and calling the script within its own directory.

This fixes meta-ide-support on dash based systems.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/toolchain-scripts.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
index ee411dd..71da5e5 100644
--- a/meta/classes/toolchain-scripts.bbclass
+++ b/meta/classes/toolchain-scripts.bbclass
@@ -62,7 +62,7 @@ toolchain_create_tree_env_script () {
 	script=${TMPDIR}/environment-setup-${REAL_MULTIMACH_TARGET_SYS}
 	rm -f $script
 	touch $script
-	echo ". ${COREBASE}/oe-init-build-env ${TOPDIR}" >> $script
+	echo 'orig=`pwd`; cd ${COREBASE}; . ./oe-init-build-env ${TOPDIR}; cd $orig' >> $script
 	echo 'export PATH=${STAGING_DIR_NATIVE}/usr/bin:${STAGING_BINDIR_TOOLCHAIN}:$PATH' >> $script
 	echo 'export PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR}' >> $script
 	echo 'export PKG_CONFIG_PATH=${PKG_CONFIG_PATH}' >> $script
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] settings-daemon: Drop pointless apply=yes in SRC_URI
  2018-05-04  8:51 [PATCH 1/2] toolchain-scripts/meta-ide-support: Handle dash shells correctly Richard Purdie
@ 2018-05-04  8:51 ` Richard Purdie
  2018-05-04  9:02 ` ✗ patchtest: failure for "toolchain-scripts/meta-ide-sup..." and 1 more Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2018-05-04  8:51 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-sato/settings-daemon/settings-daemon_0.0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-sato/settings-daemon/settings-daemon_0.0.2.bb b/meta/recipes-sato/settings-daemon/settings-daemon_0.0.2.bb
index ceaecca..bb6b69b 100644
--- a/meta/recipes-sato/settings-daemon/settings-daemon_0.0.2.bb
+++ b/meta/recipes-sato/settings-daemon/settings-daemon_0.0.2.bb
@@ -10,7 +10,7 @@ SECTION = "x11"
 # SRCREV tagged 0.0.2
 SRCREV = "b2e5da502f8c5ff75e9e6da771372ef8e40fd9a2"
 SRC_URI = "git://git.yoctoproject.org/xsettings-daemon \
-           file://addsoundkeys.patch;apply=yes \
+           file://addsoundkeys.patch \
            file://70settings-daemon.sh \
            "
 UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* ✗ patchtest: failure for "toolchain-scripts/meta-ide-sup..." and 1 more
  2018-05-04  8:51 [PATCH 1/2] toolchain-scripts/meta-ide-support: Handle dash shells correctly Richard Purdie
  2018-05-04  8:51 ` [PATCH 2/2] settings-daemon: Drop pointless apply=yes in SRC_URI Richard Purdie
@ 2018-05-04  9:02 ` Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2018-05-04  9:02 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

== Series Details ==

Series: "toolchain-scripts/meta-ide-sup..." and 1 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/11985/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 1b03cdf290)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-04  9:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-04  8:51 [PATCH 1/2] toolchain-scripts/meta-ide-support: Handle dash shells correctly Richard Purdie
2018-05-04  8:51 ` [PATCH 2/2] settings-daemon: Drop pointless apply=yes in SRC_URI Richard Purdie
2018-05-04  9:02 ` ✗ patchtest: failure for "toolchain-scripts/meta-ide-sup..." and 1 more Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox