Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: openembedded-core@lists.openembedded.org,
	alexander.kanavin@linux.intel.com
Cc: muhammad_shakeel@mentor.com, Stefan Agner <stefan.agner@toradex.com>
Subject: [PATCH 0/3] postinsts fixes
Date: Tue, 15 May 2018 16:04:48 +0200	[thread overview]
Message-ID: <20180515140451.60660-1-stefan@agner.ch> (raw)

From: Stefan Agner <stefan.agner@toradex.com>

Hi,

This follows up on the discussion a while ago:
https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg104996.html

Patch 1 is rather simple and really fixes the main issue. The patch
by itself has been tested with the relevant self test and passes.

Patch 2/3 get rid of /etc/*-postinsts script in cases where the package
management is present. This avoids a bunch of unnecessary scripts to be
present on the rootfs. It also avoids the systemd service to be present
forever with in case no postinst scripts have been deployed:
Condition: start condition failed at Tue 2018-05-15 10:57:43 UTC; 42s ago
           └─ ConditionPathExistsGlob=/etc/*-postinsts was not met

Self test executed using:
$ oe-selftest --run-tests runtime_test.Postinst.test_postinst_rootfs_and_boot

Stefan Agner (3):
  opkg: avoid running postinst scripts twice when using systemd
  run-postinsts: Do not rely on /etc/*-postinsts
  rootfs.py: Don't install postinsts if package management is present

 meta/lib/oe/rootfs.py                               |  3 +++
 .../opkg/opkg/opkg-configure.service                | 17 -----------------
 meta/recipes-devtools/opkg/opkg_0.3.6.bb            | 14 --------------
 .../run-postinsts/run-postinsts/run-postinsts       | 21 ++++++++++++---------
 .../run-postinsts/run-postinsts.service             |  1 -
 5 files changed, 15 insertions(+), 41 deletions(-)
 delete mode 100644 meta/recipes-devtools/opkg/opkg/opkg-configure.service

-- 
2.13.6



             reply	other threads:[~2018-05-15 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 14:04 Stefan Agner [this message]
2018-05-15 14:04 ` [PATCH 1/3] opkg: avoid running postinst scripts twice when using systemd Stefan Agner
2018-06-05 22:17   ` Christopher Larson
2018-05-15 14:04 ` [PATCH 2/3] run-postinsts: Do not rely on /etc/*-postinsts Stefan Agner
2018-05-15 14:04 ` [PATCH 3/3] rootfs.py: Don't install postinsts if package management is present Stefan Agner
2018-05-15 15:03 ` [PATCH 0/3] postinsts fixes Alexander Kanavin
2018-05-15 16:07   ` Stefan Agner
2018-05-15 16:07     ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515140451.60660-1-stefan@agner.ch \
    --to=stefan@agner.ch \
    --cc=alexander.kanavin@linux.intel.com \
    --cc=muhammad_shakeel@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=stefan.agner@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox