Re: [PATCH 0/3] postinsts fixes

[Alexander Kanavin <alexander.kanavin@linux.intel.com>]

On 05/15/2018 07:07 PM, Stefan Agner wrote:
> On 15.05.2018 17:03, Alexander Kanavin wrote:
>> On 05/15/2018 05:04 PM, Stefan Agner wrote:
>>> This follows up on the discussion a while ago:
>>> https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg104996.html
>>
>> Took me a moment to realize all three patches are specific to
>> opkg/dpkg and do not change how rpm (or general 'postinst handling')
>> works. Perhaps you could amend the commit messages to emphasize that?
> 
> Patch 1 has opkg in the subject.
> 
> Patch 2/3 mention opkg/dpkg in the commit log.
> 
> Patch 3 also really edits the DpkgOpkgRootfs class, which should make it
> rather obvious.
> 
> But I agree for patch 2 it would be good to emphasize it.
> 
> How about adding this after the first paragraph:
> The behavior for rpm stays the same.

That, and amend the commit summaries:

patch 2:

run-postinsts: for dpkg/opkg, do not rely on /etc/*-postinsts

patch 3:

rootfs.py: for dpkg/opkg, don't install postinsts if package management 
is present

Otherwise those one liners can give the wrong impression.

Alex