From: Martin Kelly <mkelly@xevo.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v3 3/6] toolchain-scripts: print post-relocate error
Date: Mon, 4 Jun 2018 16:05:59 -0700 [thread overview]
Message-ID: <20180604230602.8461-4-mkelly@xevo.com> (raw)
In-Reply-To: <20180604230602.8461-1-mkelly@xevo.com>
Currently, if a post-relocate script fails, it fails silently. We should
be louder about this, as it likely indicates a broken SDK.
Print a message if a post-relocate script fails.
Signed-off-by: Martin Kelly <mkelly@xevo.com>
---
meta/classes/toolchain-scripts.bbclass | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
index da8a57f24b..ef190a69ec 100644
--- a/meta/classes/toolchain-scripts.bbclass
+++ b/meta/classes/toolchain-scripts.bbclass
@@ -129,6 +129,11 @@ if [ -d "${SDKPATHNATIVE}/post-relocate-setup.d/" ]; then
continue
fi
\$s "\$1"
+ status=\$?
+ if [ \$status != 0 ]; then
+ echo "post-relocate command \"\$s \$1\" failed with status \$status" >&2
+ exit \$status
+ fi
done
rm -rf "${SDKPATHNATIVE}/post-relocate-setup.d"
fi
--
2.11.0
next prev parent reply other threads:[~2018-06-04 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 23:05 [PATCH v3 0/6] meson: implement nativesdk support Martin Kelly
2018-06-04 23:05 ` [PATCH v3 1/6] toolchain-scripts: retab file Martin Kelly
2018-06-05 10:09 ` Peter Kjellerstedt
2018-06-05 10:36 ` Richard Purdie
2018-06-05 12:04 ` Peter Kjellerstedt
2018-06-05 16:56 ` Martin Kelly
2018-06-04 23:05 ` [PATCH v3 2/6] toolchain-scripts: allow non-sh post-relocate Martin Kelly
2018-06-05 10:27 ` Peter Kjellerstedt
2018-06-05 10:36 ` Richard Purdie
2018-06-04 23:05 ` Martin Kelly [this message]
2018-06-04 23:06 ` [PATCH v3 4/6] toolchain-scripts: pass env to post-relocate Martin Kelly
2018-06-04 23:06 ` [PATCH v3 5/6] meson: handle exe wrappers Martin Kelly
2018-06-04 23:06 ` [PATCH v3 6/6] meson: enable nativesdk Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604230602.8461-4-mkelly@xevo.com \
--to=mkelly@xevo.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox