From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Martin Kelly <mkelly@xevo.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3 1/6] toolchain-scripts: retab file
Date: Tue, 5 Jun 2018 10:09:40 +0000 [thread overview]
Message-ID: <248cbe41837f42c88d3b38cefec71a4b@XBOX02.axis.com> (raw)
In-Reply-To: <20180604230602.8461-2-mkelly@xevo.com>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Martin Kelly
> Sent: den 5 juni 2018 01:06
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH v3 1/6] toolchain-scripts: retab file
>
> Two functions is uses a mix of spaces and tabs. The rest of the file
> uses tabs, so switch to tabs uniformly.
>
> Signed-off-by: Martin Kelly <mkelly@xevo.com>
> ---
> meta/classes/toolchain-scripts.bbclass | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> index 71da5e5409..a72436167c 100644
> --- a/meta/classes/toolchain-scripts.bbclass
> +++ b/meta/classes/toolchain-scripts.bbclass
> @@ -122,7 +122,7 @@ toolchain_create_post_relocate_script() {
> rm -f $script
> touch $script
>
> - cat >> $script <<EOF
> + cat >> $script <<EOF
> if [ -d "${SDKPATHNATIVE}/post-relocate-setup.d/" ]; then
> for s in ${SDKPATHNATIVE}/post-relocate-setup.d/*.sh; do
> \$s "\$1"
This part should be indented using tabs as well.
> @@ -166,13 +166,13 @@ toolchain_create_sdk_siteconfig () {
> toolchain_create_sdk_siteconfig[vardepsexclude] = "TOOLCHAIN_CONFIGSITE_SYSROOTCACHE"
>
> python __anonymous () {
> - import oe.classextend
> - deps = ""
> - for dep in (d.getVar('TOOLCHAIN_NEED_CONFIGSITE_CACHE') or "").split():
> - deps += " %s:do_populate_sysroot" % dep
> - for variant in (d.getVar('MULTILIB_VARIANTS') or "").split():
> - clsextend = oe.classextend.ClassExtender(variant, d)
> - newdep = clsextend.extend_name(dep)
> - deps += " %s:do_populate_sysroot" % newdep
> - d.appendVarFlag('do_configure', 'depends', deps)
> + import oe.classextend
> + deps = ""
> + for dep in (d.getVar('TOOLCHAIN_NEED_CONFIGSITE_CACHE') or "").split():
> + deps += " %s:do_populate_sysroot" % dep
> + for variant in (d.getVar('MULTILIB_VARIANTS') or "").split():
> + clsextend = oe.classextend.ClassExtender(variant, d)
> + newdep = clsextend.extend_name(dep)
> + deps += " %s:do_populate_sysroot" % newdep
> + d.appendVarFlag('do_configure', 'depends', deps)
This is Python code. I believe the OE-Core standard is for Python code
to be indented using four spaces (whereas shell code should be indented
using tabs).
> }
> --
> 2.11.0
//Peter
next prev parent reply other threads:[~2018-06-05 10:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 23:05 [PATCH v3 0/6] meson: implement nativesdk support Martin Kelly
2018-06-04 23:05 ` [PATCH v3 1/6] toolchain-scripts: retab file Martin Kelly
2018-06-05 10:09 ` Peter Kjellerstedt [this message]
2018-06-05 10:36 ` Richard Purdie
2018-06-05 12:04 ` Peter Kjellerstedt
2018-06-05 16:56 ` Martin Kelly
2018-06-04 23:05 ` [PATCH v3 2/6] toolchain-scripts: allow non-sh post-relocate Martin Kelly
2018-06-05 10:27 ` Peter Kjellerstedt
2018-06-05 10:36 ` Richard Purdie
2018-06-04 23:05 ` [PATCH v3 3/6] toolchain-scripts: print post-relocate error Martin Kelly
2018-06-04 23:06 ` [PATCH v3 4/6] toolchain-scripts: pass env to post-relocate Martin Kelly
2018-06-04 23:06 ` [PATCH v3 5/6] meson: handle exe wrappers Martin Kelly
2018-06-04 23:06 ` [PATCH v3 6/6] meson: enable nativesdk Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248cbe41837f42c88d3b38cefec71a4b@XBOX02.axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=mkelly@xevo.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox