* [PATCH] icecc-toolchain: Remove environment setup
@ 2018-06-06 15:24 Joshua Watt
2018-06-06 17:34 ` Martin Kelly
0 siblings, 1 reply; 2+ messages in thread
From: Joshua Watt @ 2018-06-06 15:24 UTC (permalink / raw)
To: openembedded-core, Martin Kelly
The handling of the environment setup was moved to the post-relocate
script handler, and so is no longer necessary in the setup script
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
.../icecc-toolchain/icecc-toolchain/icecc-setup.sh | 5 -----
1 file changed, 5 deletions(-)
diff --git a/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh b/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh
index 04808265781..25250b7c0e2 100644
--- a/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh
+++ b/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh
@@ -20,11 +20,6 @@
# SOFTWARE.
#
-# Setup environment
-for env_setup_script in `ls $1/environment-setup-*`; do
- . $env_setup_script
-done
-
# ICECC_PATH will have been found icecc-env.sh
if [ -z "$ICECC_PATH" ]; then
exit 0
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] icecc-toolchain: Remove environment setup
2018-06-06 15:24 [PATCH] icecc-toolchain: Remove environment setup Joshua Watt
@ 2018-06-06 17:34 ` Martin Kelly
0 siblings, 0 replies; 2+ messages in thread
From: Martin Kelly @ 2018-06-06 17:34 UTC (permalink / raw)
To: Joshua Watt, openembedded-core
On 06/06/2018 08:24 AM, Joshua Watt wrote:
> The handling of the environment setup was moved to the post-relocate
> script handler, and so is no longer necessary in the setup script
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
> .../icecc-toolchain/icecc-toolchain/icecc-setup.sh | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh b/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh
> index 04808265781..25250b7c0e2 100644
> --- a/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh
> +++ b/meta/recipes-devtools/icecc-toolchain/icecc-toolchain/icecc-setup.sh
> @@ -20,11 +20,6 @@
> # SOFTWARE.
> #
>
> -# Setup environment
> -for env_setup_script in `ls $1/environment-setup-*`; do
> - . $env_setup_script
> -done
> -
> # ICECC_PATH will have been found icecc-env.sh
> if [ -z "$ICECC_PATH" ]; then
> exit 0
>
Reviewed-by: Martin Kelly <mkelly@xevo.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-06 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 15:24 [PATCH] icecc-toolchain: Remove environment setup Joshua Watt
2018-06-06 17:34 ` Martin Kelly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox