[PATCH] Revert "gnutls: rationalise libunistring arguments"

Openembedded Core Discussions
 help / color / mirror / Atom feed

* [PATCH] Revert "gnutls: rationalise libunistring arguments"
@ 2018-07-27 21:04 Khem Raj
  2018-08-03 15:40 ` Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2018-07-27 21:04 UTC (permalink / raw)
  To: openembedded-core

This reverts commit 60fef4940de7f0440f1216eb2ea0ea683b3e8fdd.
---
 meta/recipes-support/gnutls/gnutls.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
index b62a137e59..98ec8d9667 100644
--- a/meta/recipes-support/gnutls/gnutls.inc
+++ b/meta/recipes-support/gnutls/gnutls.inc
@@ -41,6 +41,7 @@ EXTRA_OECONF = " \
     --enable-local-libopts \
     --enable-openssl-compatibility \
     --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
+    --without-libunistring-prefix \
 "
 
 LDFLAGS_append_libc-musl = " -largp"
-- 
2.18.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] Revert "gnutls: rationalise libunistring arguments"
  2018-07-27 21:04 [PATCH] Revert "gnutls: rationalise libunistring arguments" Khem Raj
@ 2018-08-03 15:40 ` Khem Raj
  2018-08-03 15:47   ` Richard Purdie
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2018-08-03 15:40 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

ping^1
On Fri, Jul 27, 2018 at 2:04 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> This reverts commit 60fef4940de7f0440f1216eb2ea0ea683b3e8fdd.
> ---
>  meta/recipes-support/gnutls/gnutls.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
> index b62a137e59..98ec8d9667 100644
> --- a/meta/recipes-support/gnutls/gnutls.inc
> +++ b/meta/recipes-support/gnutls/gnutls.inc
> @@ -41,6 +41,7 @@ EXTRA_OECONF = " \
>      --enable-local-libopts \
>      --enable-openssl-compatibility \
>      --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
> +    --without-libunistring-prefix \
>  "
>
>  LDFLAGS_append_libc-musl = " -largp"
> --
> 2.18.0
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Revert "gnutls: rationalise libunistring arguments"
  2018-08-03 15:40 ` Khem Raj
@ 2018-08-03 15:47   ` Richard Purdie
  2018-08-03 15:49     ` Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2018-08-03 15:47 UTC (permalink / raw)
  To: Khem Raj, Patches and discussions about the oe-core layer

On Fri, 2018-08-03 at 08:40 -0700, Khem Raj wrote:
> ping^1

Could you put something about why in the commit message please?

Cheers,

Richard


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Revert "gnutls: rationalise libunistring arguments"
  2018-08-03 15:47   ` Richard Purdie
@ 2018-08-03 15:49     ` Khem Raj
  2018-08-03 16:36       ` richard.purdie
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2018-08-03 15:49 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer

Yes, will do. I explained it in original thread as well
On Fri, Aug 3, 2018 at 8:47 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Fri, 2018-08-03 at 08:40 -0700, Khem Raj wrote:
> > ping^1
>
> Could you put something about why in the commit message please?
>
> Cheers,
>
> Richard


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Revert "gnutls: rationalise libunistring arguments"
  2018-08-03 15:49     ` Khem Raj
@ 2018-08-03 16:36       ` richard.purdie
  0 siblings, 0 replies; 5+ messages in thread
From: richard.purdie @ 2018-08-03 16:36 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

On Fri, 2018-08-03 at 08:49 -0700, Khem Raj wrote:
> Yes, will do. I explained it in original thread as well

I know, but we need it in the commit message so we record why we did
it...

Cheers,

Richard


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-08-03 16:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-27 21:04 [PATCH] Revert "gnutls: rationalise libunistring arguments" Khem Raj
2018-08-03 15:40 ` Khem Raj
2018-08-03 15:47   ` Richard Purdie
2018-08-03 15:49     ` Khem Raj
2018-08-03 16:36       ` richard.purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox