[PATCH V2 0/2] Remove allarch from recipes which rdeps TUNE_PKGARCH packages

[PATCH V2 0/2] Remove allarch from recipes which rdeps TUNE_PKGARCH packages

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

V2:
* rebase on Ross's patch 'ca-certificates: upgrade 20170717 -> 20180409'

Kai Kang (2):
  remove allarch from recipes which rdepends on TUNE_PKGARCH packages
  layer.conf: update SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS

 meta/conf/layer.conf                                       | 7 -------
 meta/recipes-connectivity/ppp-dialin/ppp-dialin_0.1.bb     | 2 +-
 meta/recipes-connectivity/resolvconf/resolvconf_1.79.bb    | 2 --
 meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 2 --
 .../initrdscripts/initramfs-module-setup-live_1.0.bb       | 2 --
 .../docbook-xml/docbook-xsl-stylesheets_1.79.1.bb          | 1 -
 meta/recipes-graphics/wayland/weston-init.bb               | 2 +-
 meta/recipes-graphics/xorg-font/font-alias_1.0.3.bb        | 2 --
 meta/recipes-graphics/xorg-font/xorg-minimal-fonts.bb      | 2 +-
 .../ca-certificates/ca-certificates_20180409.bb            | 2 --
 10 files changed, 3 insertions(+), 21 deletions(-)

-- 
2.17.1

[PATCH 1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

The following allarch packages rdepends on TUNE_PKGARCH packages. So
remove allarch from these recipes.

ca-certificates -> openssl
docbook-xsl-stylesheets -> perl
font-alias -> font-util
initramfs-module-setup-live -> udev-extraconf
initramfs-framework -> ${VIRTUAL-RUNTIME_base-utils} (busybox by default)
ppp-dialin -> ppp
resolvconf -> bash
weston-init -> weston kbd
xorg-minimal-fonts -> font-alias

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-connectivity/ppp-dialin/ppp-dialin_0.1.bb          | 2 +-
 meta/recipes-connectivity/resolvconf/resolvconf_1.79.bb         | 2 --
 meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb      | 2 --
 .../initrdscripts/initramfs-module-setup-live_1.0.bb            | 2 --
 .../docbook-xml/docbook-xsl-stylesheets_1.79.1.bb               | 1 -
 meta/recipes-graphics/wayland/weston-init.bb                    | 2 +-
 meta/recipes-graphics/xorg-font/font-alias_1.0.3.bb             | 2 --
 meta/recipes-graphics/xorg-font/xorg-minimal-fonts.bb           | 2 +-
 .../recipes-support/ca-certificates/ca-certificates_20180409.bb | 2 --
 9 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/meta/recipes-connectivity/ppp-dialin/ppp-dialin_0.1.bb b/meta/recipes-connectivity/ppp-dialin/ppp-dialin_0.1.bb
index b5f68951d7..eee6ef6518 100644
--- a/meta/recipes-connectivity/ppp-dialin/ppp-dialin_0.1.bb
+++ b/meta/recipes-connectivity/ppp-dialin/ppp-dialin_0.1.bb
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384
 SRC_URI = "file://host-peer \
            file://ppp-dialin"
 
-inherit allarch useradd
+inherit useradd
 
 S = "${WORKDIR}"
 
diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.79.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.79.bb
index 8550177288..0fdd479e1c 100644
--- a/meta/recipes-connectivity/resolvconf/resolvconf_1.79.bb
+++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.79.bb
@@ -23,8 +23,6 @@ SRC_URI[sha256sum] = "8e2843cd4162b706f0481b3c281657728cbc2822e50a64fff79b79bd8a
 # so we check the latest upstream from a directory that does get updated
 UPSTREAM_CHECK_URI = "${DEBIAN_MIRROR}/main/r/resolvconf/"
 
-inherit allarch
-
 do_compile () {
 	:
 }
diff --git a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
index 6337b998ac..6d1dbdd2b8 100644
--- a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
+++ b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
@@ -5,8 +5,6 @@ RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_base-utils}"
 
 PR = "r4"
 
-inherit allarch
-
 SRC_URI = "file://init \
            file://exec \
            file://nfsrootfs \
diff --git a/meta/recipes-core/initrdscripts/initramfs-module-setup-live_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-module-setup-live_1.0.bb
index 4d2fe9dd2b..26468c1b5d 100644
--- a/meta/recipes-core/initrdscripts/initramfs-module-setup-live_1.0.bb
+++ b/meta/recipes-core/initrdscripts/initramfs-module-setup-live_1.0.bb
@@ -5,8 +5,6 @@ RDEPENDS_${PN} = "initramfs-framework-base udev-extraconf"
 
 PR = "r4"
 
-inherit allarch
-
 FILESEXTRAPATHS_prepend := "${THISDIR}/initramfs-framework:"
 SRC_URI = "file://setup-live"
 
diff --git a/meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets_1.79.1.bb b/meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets_1.79.1.bb
index 07d32ce979..c1bcc1743c 100644
--- a/meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets_1.79.1.bb
+++ b/meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets_1.79.1.bb
@@ -17,7 +17,6 @@ UPSTREAM_CHECK_REGEX = "/docbook-xsl/(?P<pver>(\d+[\.\-_]*)+(?!\.0)\.\d+)/"
 
 S = "${WORKDIR}/docbook-xsl-${PV}"
 
-inherit allarch
 BBCLASSEXTEND = "native"
 
 do_configure (){
diff --git a/meta/recipes-graphics/wayland/weston-init.bb b/meta/recipes-graphics/wayland/weston-init.bb
index 22ba5f3fb3..f3b4398295 100644
--- a/meta/recipes-graphics/wayland/weston-init.bb
+++ b/meta/recipes-graphics/wayland/weston-init.bb
@@ -18,7 +18,7 @@ do_install() {
 	sed -i 's,@LOCALSTATEDIR@,${localstatedir},g' ${D}${bindir}/weston-start
 }
 
-inherit allarch update-rc.d distro_features_check systemd
+inherit update-rc.d distro_features_check systemd
 
 # rdepends on weston which depends on virtual/egl
 REQUIRED_DISTRO_FEATURES = "opengl"
diff --git a/meta/recipes-graphics/xorg-font/font-alias_1.0.3.bb b/meta/recipes-graphics/xorg-font/font-alias_1.0.3.bb
index 15e101596a..de1c8ead38 100644
--- a/meta/recipes-graphics/xorg-font/font-alias_1.0.3.bb
+++ b/meta/recipes-graphics/xorg-font/font-alias_1.0.3.bb
@@ -15,8 +15,6 @@ DEPENDS = "util-macros-native font-util-native"
 RDEPENDS_${PN} = "encodings font-util"
 RDEPENDS_${PN}_class-native = "font-util-native"
 
-inherit allarch
-
 PE = "1"
 PR = "${INC_PR}.3"
 
diff --git a/meta/recipes-graphics/xorg-font/xorg-minimal-fonts.bb b/meta/recipes-graphics/xorg-font/xorg-minimal-fonts.bb
index 9bcd1b2fa6..9740df45f6 100644
--- a/meta/recipes-graphics/xorg-font/xorg-minimal-fonts.bb
+++ b/meta/recipes-graphics/xorg-font/xorg-minimal-fonts.bb
@@ -13,7 +13,7 @@ SRC_URI = "file://misc"
 PE = "1"
 PR = "r2"
 
-inherit allarch distro_features_check
+inherit distro_features_check
 
 # The font-alias requires x11 in DISTRO_FEATURES
 REQUIRED_DISTRO_FEATURES = "x11"
diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20180409.bb b/meta/recipes-support/ca-certificates/ca-certificates_20180409.bb
index 0d57083c52..3297b23507 100644
--- a/meta/recipes-support/ca-certificates/ca-certificates_20180409.bb
+++ b/meta/recipes-support/ca-certificates/ca-certificates_20180409.bb
@@ -27,8 +27,6 @@ SRC_URI = "git://salsa.debian.org/debian/ca-certificates.git;protocol=https \
 
 S = "${WORKDIR}/git"
 
-inherit allarch
-
 EXTRA_OEMAKE = "\
     'CERTSDIR=${datadir}/ca-certificates' \
     'SBINDIR=${sbindir}' \
-- 
2.17.1

Re: [PATCH 1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages

[richard.purdie]

On Fri, 2018-08-03 at 09:49 +0800, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> The following allarch packages rdepends on TUNE_PKGARCH packages. So
> remove allarch from these recipes.
> 
> ca-certificates -> openssl

Should we reverse this, i.e. have openssl RRECOMMENDS ca-certificates?

> docbook-xsl-stylesheets -> perl
> font-alias -> font-util
> initramfs-module-setup-live -> udev-extraconf
> initramfs-framework -> ${VIRTUAL-RUNTIME_base-utils} (busybox by
> default)
> ppp-dialin -> ppp

ppp RRECOMMENDS ppp-dialin?

> resolvconf -> bash
> weston-init -> weston kbd

weston RRECOMMENDS weston-init?

Not really sure about some of these but we should at least consider
it...

Cheers,

Richard

Re: [PATCH 1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages

[Mark Hatle]

On 8/3/18 4:28 PM, richard.purdie@linuxfoundation.org wrote:
> On Fri, 2018-08-03 at 09:49 +0800, kai.kang@windriver.com wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> The following allarch packages rdepends on TUNE_PKGARCH packages. So
>> remove allarch from these recipes.
>>
>> ca-certificates -> openssl
> 
> Should we reverse this, i.e. have openssl RRECOMMENDS ca-certificates?

I believe this is what other distros do.  I think the dependency on
ca-certficiates was there because there is a script included that uses OpenSSL
to generate the certificates.  (Theoretically you can use this script post
install to update the certs.)

/usr/sbin/update-ca-certificates

I suspect the others had similar dependencies.. some included script needed
something from another package to run.

Not sure if this changes the suggestion though...

--Mark

>> docbook-xsl-stylesheets -> perl
>> font-alias -> font-util
>> initramfs-module-setup-live -> udev-extraconf
>> initramfs-framework -> ${VIRTUAL-RUNTIME_base-utils} (busybox by
>> default)
>> ppp-dialin -> ppp
> 
> ppp RRECOMMENDS ppp-dialin?
> 
>> resolvconf -> bash
>> weston-init -> weston kbd
> 
> weston RRECOMMENDS weston-init?
> 
> Not really sure about some of these but we should at least consider
> it...
> 
> Cheers,
> 
> Richard
> 

Re: [PATCH 1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages

[Kang Kai]

On 2018年08月06日 22:51, Mark Hatle wrote:
> On 8/3/18 4:28 PM, richard.purdie@linuxfoundation.org wrote:
>> On Fri, 2018-08-03 at 09:49 +0800, kai.kang@windriver.com wrote:
>>> From: Kai Kang <kai.kang@windriver.com>
>>>
>>> The following allarch packages rdepends on TUNE_PKGARCH packages. So
>>> remove allarch from these recipes.
>>>
>>> ca-certificates -> openssl
>> Should we reverse this, i.e. have openssl RRECOMMENDS ca-certificates?
> I believe this is what other distros do.  I think the dependency on
> ca-certficiates was there because there is a script included that uses OpenSSL
> to generate the certificates.  (Theoretically you can use this script post
> install to update the certs.)
>
> /usr/sbin/update-ca-certificates
>
> I suspect the others had similar dependencies.. some included script needed
> something from another package to run.
>
> Not sure if this changes the suggestion though...
>
> --Mark
>
>>> docbook-xsl-stylesheets -> perl
>>> font-alias -> font-util
>>> initramfs-module-setup-live -> udev-extraconf
>>> initramfs-framework -> ${VIRTUAL-RUNTIME_base-utils} (busybox by
>>> default)
>>> ppp-dialin -> ppp
>> ppp RRECOMMENDS ppp-dialin?

ppp-dialin installs script ppp-dialin which calls /usr/sbin/pppd.


>>
>>> resolvconf -> bash
>>> weston-init -> weston kbd
>> weston RRECOMMENDS weston-init?

weston-init install init file which calls weston or weston-launch from 
package weston and openvt from package kbd.

Regards,
Kai


>>
>> Not really sure about some of these but we should at least consider
>> it...
>>
>> Cheers,
>>
>> Richard
>>
>

-- 
Regards,
Neil | Kai Kang

Re: [PATCH 1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages

[richard.purdie]

On Tue, 2018-08-07 at 17:37 +0800, Kang Kai wrote:
> On 2018年08月06日 22:51, Mark Hatle wrote:
> > On 8/3/18 4:28 PM, richard.purdie@linuxfoundation.org wrote:
> > > On Fri, 2018-08-03 at 09:49 +0800, kai.kang@windriver.com wrote:
> > > > From: Kai Kang <kai.kang@windriver.com>
> > > > 
> > > > The following allarch packages rdepends on TUNE_PKGARCH
> > > > packages. So
> > > > remove allarch from these recipes.
> > > > 
> > > > ca-certificates -> openssl
> > > 
> > > Should we reverse this, i.e. have openssl RRECOMMENDS ca-
> > > certificates?
> > 
> > I believe this is what other distros do.  I think the dependency on
> > ca-certficiates was there because there is a script included that
> > uses OpenSSL
> > to generate the certificates.  (Theoretically you can use this
> > script post
> > install to update the certs.)
> > 
> > /usr/sbin/update-ca-certificates
> > 
> > I suspect the others had similar dependencies.. some included
> > script needed
> > something from another package to run.
> > 
> > Not sure if this changes the suggestion though...
> > 
> > --Mark
> > 
> > > > docbook-xsl-stylesheets -> perl
> > > > font-alias -> font-util
> > > > initramfs-module-setup-live -> udev-extraconf
> > > > initramfs-framework -> ${VIRTUAL-RUNTIME_base-utils} (busybox
> > > > by
> > > > default)
> > > > ppp-dialin -> ppp
> > > 
> > > ppp RRECOMMENDS ppp-dialin?
> 
> ppp-dialin installs script ppp-dialin which calls /usr/sbin/pppd.
> 
> 
> > > 
> > > > resolvconf -> bash
> > > > weston-init -> weston kbd
> > > 
> > > weston RRECOMMENDS weston-init?
> 
> weston-init install init file which calls weston or weston-launch
> from 
> package weston and openvt from package kbd.

Agreed.

My worry is that this move effectively makes allarch usesless since any
script using an interpreter will now need to be not allarch since most
interpreters are not allarch.

I'm not sure this is a good move...

Cheers,

Richard

Re: [PATCH 1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages

[Richard Purdie]

On Tue, 2018-08-07 at 11:44 +0100, richard.purdie@linuxfoundation.org
wrote:
> On Tue, 2018-08-07 at 17:37 +0800, Kang Kai wrote:
> > On 2018年08月06日 22:51, Mark Hatle wrote:
> > > > 
> > > > > resolvconf -> bash
> > > > > weston-init -> weston kbd
> > > > 
> > > > weston RRECOMMENDS weston-init?
> > 
> > weston-init install init file which calls weston or weston-launch
> > from 
> > package weston and openvt from package kbd.
> 
> Agreed.
> 
> My worry is that this move effectively makes allarch usesless since
> any
> script using an interpreter will now need to be not allarch since
> most
> interpreters are not allarch.
> 
> I'm not sure this is a good move...

Thinking about this further, we could just disable allarch if multilib
is enabled? That would seem to address most of the issues, not entirely
satisfactorily but enough to make things work... ?

Cheers,

Richard

Re: [PATCH 1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages

[Mark Hatle]

On 8/7/18 9:56 AM, Richard Purdie wrote:
> On Tue, 2018-08-07 at 11:44 +0100, richard.purdie@linuxfoundation.org
> wrote:
>> On Tue, 2018-08-07 at 17:37 +0800, Kang Kai wrote:
>>> On 2018年08月06日 22:51, Mark Hatle wrote:
>>>>>
>>>>>> resolvconf -> bash
>>>>>> weston-init -> weston kbd
>>>>>
>>>>> weston RRECOMMENDS weston-init?
>>>
>>> weston-init install init file which calls weston or weston-launch
>>> from 
>>> package weston and openvt from package kbd.
>>
>> Agreed.
>>
>> My worry is that this move effectively makes allarch usesless since
>> any
>> script using an interpreter will now need to be not allarch since
>> most
>> interpreters are not allarch.
>>
>> I'm not sure this is a good move...
> 
> Thinking about this further, we could just disable allarch if multilib
> is enabled? That would seem to address most of the issues, not entirely
> satisfactorily but enough to make things work... ?

Yes, this would resolve some of the concerns.  We already know that these
allarch SHOULD be identical for all multilibs, so install space should not be an
issue, it's only build time concerns.

--Mark

> Cheers,
> 
> Richard
> 

[PATCH 2/2] layer.conf: update SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

allarch has been removed from some packages which rdepends on
TUNE_PKGARCH packages, so remove related depenencies from
SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/conf/layer.conf | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
index 315fb936fa..49ce7a913a 100644
--- a/meta/conf/layer.conf
+++ b/meta/conf/layer.conf
@@ -53,10 +53,6 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   *->icecc-create-env-native \
   gcc-cross-${TARGET_ARCH}->virtual/${TARGET_PREFIX}libc-for-gcc \
   gcc-cross-${TARGET_ARCH}->linux-libc-headers \
-  ppp-dialin->ppp \
-  resolvconf->bash \
-  docbook-xsl-stylesheets->perl \
-  ca-certificates->openssl \
   initramfs-framework->${VIRTUAL-RUNTIME_base-utils} \
   initramfs-framework->eudev \
   initramfs-framework->systemd \
@@ -72,10 +68,7 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   liberation-fonts->fontconfig \
   cantarell-fonts->fontconfig \
   gnome-icon-theme->librsvg \
-  font-alias->font-util \
   systemd-boot->systemd-bootconf \
-  weston-init->weston \
-  weston-init->kbd \
 "
 
 # We need to keep bitbake tools in PATH
-- 
2.17.1

✗ patchtest: failure for Remove allarch from recipes which rdeps TUNE_PKGARCH packages (rev2)

[Patchwork]

== Series Details ==

Series: Remove allarch from recipes which rdeps TUNE_PKGARCH packages (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/13360/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 1c4d9f46d5)

* Patch            [1/2] remove allarch from recipes which rdepends on TUNE_PKGARCH packages
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe