* [PATCH] libusb: Add ptest
@ 2018-08-06 12:08 Maksym Kokhan
2018-08-06 12:32 ` ✗ patchtest: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Maksym Kokhan @ 2018-08-06 12:08 UTC (permalink / raw)
To: openembedded-core; +Cc: Ruslan Bilovol, Andrii Bordunov, Maksym Kokhan
Add ptest support to libusb package.
Uses existing libusb tests.
Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
Reviewed-by: Andrii Bordunov <andrii.bordunov@globallogic.com>
---
meta/recipes-support/libusb/libusb1/run-ptest | 15 +++++++++++++++
meta/recipes-support/libusb/libusb1_1.0.21.bb | 11 ++++++++++-
2 files changed, 25 insertions(+), 1 deletion(-)
create mode 100755 meta/recipes-support/libusb/libusb1/run-ptest
diff --git a/meta/recipes-support/libusb/libusb1/run-ptest b/meta/recipes-support/libusb/libusb1/run-ptest
new file mode 100755
index 0000000..646a966
--- /dev/null
+++ b/meta/recipes-support/libusb/libusb1/run-ptest
@@ -0,0 +1,15 @@
+#!/bin/sh
+
+echo
+echo "---------------------------- libusb1 tests ---------------------------"
+echo
+
+./stress | tr '\n' ' ' | \
+sed 's/Starting test run: \([a-zA-Z_]*\)\.\.\. \([a-zA-Z_]*\) (.) /\2 \1\n/g' | \
+sed '$d' | \
+sed '{
+ s/^Success/PASS:/g
+ s/^Failure/FAIL:/g
+ s/^Error/FAIL:/g
+ s/^Skip/SKIP:/g
+}'
diff --git a/meta/recipes-support/libusb/libusb1_1.0.21.bb b/meta/recipes-support/libusb/libusb1_1.0.21.bb
index 1fefd14..073de38 100644
--- a/meta/recipes-support/libusb/libusb1_1.0.21.bb
+++ b/meta/recipes-support/libusb/libusb1_1.0.21.bb
@@ -10,6 +10,7 @@ BBCLASSEXTEND = "native nativesdk"
SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
file://no-dll.patch \
+ file://run-ptest \
"
SRC_URI[md5sum] = "1da9ea3c27b3858fa85c5f4466003e44"
@@ -17,7 +18,7 @@ SRC_URI[sha256sum] = "7dce9cce9a81194b7065ee912bcd55eeffebab694ea403ffb91b67db66
S = "${WORKDIR}/libusb-${PV}"
-inherit autotools pkgconfig
+inherit autotools pkgconfig ptest
# Don't configure udev by default since it will cause a circular
# dependecy with udev package, which depends on libusb
@@ -30,6 +31,14 @@ do_install_append() {
fi
}
+do_compile_ptest() {
+ oe_runmake -C tests stress
+}
+
+do_install_ptest() {
+ install -m 755 ${WORKDIR}/build/tests/.libs/stress ${D}${PTEST_PATH}
+}
+
FILES_${PN} += "${base_libdir}/*.so.*"
FILES_${PN}-dev += "${base_libdir}/*.so ${base_libdir}/*.la"
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✗ patchtest: failure for libusb: Add ptest
2018-08-06 12:08 [PATCH] libusb: Add ptest Maksym Kokhan
@ 2018-08-06 12:32 ` Patchwork
2018-08-06 13:39 ` [PATCH] " Anuj Mittal
2018-08-06 14:32 ` ✗ patchtest: failure for libusb: Add ptest (rev2) Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-08-06 12:32 UTC (permalink / raw)
To: Andrii Bordunov via Openembedded-core; +Cc: openembedded-core
== Series Details ==
Series: libusb: Add ptest
Revision: 1
URL : https://patchwork.openembedded.org/series/13400/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 1c4d9f46d5)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] libusb: Add ptest
2018-08-06 12:08 [PATCH] libusb: Add ptest Maksym Kokhan
2018-08-06 12:32 ` ✗ patchtest: failure for " Patchwork
@ 2018-08-06 13:39 ` Anuj Mittal
2018-08-06 14:16 ` Maksym Kokhan
2018-08-06 14:32 ` ✗ patchtest: failure for libusb: Add ptest (rev2) Patchwork
2 siblings, 1 reply; 7+ messages in thread
From: Anuj Mittal @ 2018-08-06 13:39 UTC (permalink / raw)
To: Maksym Kokhan, openembedded-core; +Cc: Ruslan Bilovol, Andrii Bordunov
On 08/06/2018 08:08 PM, Maksym Kokhan via Openembedded-core wrote:
> Add ptest support to libusb package.
> Uses existing libusb tests.
>
> Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> Reviewed-by: Andrii Bordunov <andrii.bordunov@globallogic.com>
> ---
> meta/recipes-support/libusb/libusb1/run-ptest | 15 +++++++++++++++
> meta/recipes-support/libusb/libusb1_1.0.21.bb | 11 ++++++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
> create mode 100755 meta/recipes-support/libusb/libusb1/run-ptest
>
> diff --git a/meta/recipes-support/libusb/libusb1/run-ptest b/meta/recipes-support/libusb/libusb1/run-ptest
> new file mode 100755
> index 0000000..646a966
> --- /dev/null
> +++ b/meta/recipes-support/libusb/libusb1/run-ptest
> @@ -0,0 +1,15 @@
> +#!/bin/sh
> +
> +echo
> +echo "---------------------------- libusb1 tests ---------------------------"
> +echo
> +
> +./stress | tr '\n' ' ' | \
> +sed 's/Starting test run: \([a-zA-Z_]*\)\.\.\. \([a-zA-Z_]*\) (.) /\2 \1\n/g' | \
> +sed '$d' | \
> +sed '{
> + s/^Success/PASS:/g
> + s/^Failure/FAIL:/g
> + s/^Error/FAIL:/g
> + s/^Skip/SKIP:/g
> +}'
> diff --git a/meta/recipes-support/libusb/libusb1_1.0.21.bb b/meta/recipes-support/libusb/libusb1_1.0.21.bb
> index 1fefd14..073de38 100644
> --- a/meta/recipes-support/libusb/libusb1_1.0.21.bb
> +++ b/meta/recipes-support/libusb/libusb1_1.0.21.bb
> @@ -10,6 +10,7 @@ BBCLASSEXTEND = "native nativesdk"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
> file://no-dll.patch \
> + file://run-ptest \
> "
>
> SRC_URI[md5sum] = "1da9ea3c27b3858fa85c5f4466003e44"
> @@ -17,7 +18,7 @@ SRC_URI[sha256sum] = "7dce9cce9a81194b7065ee912bcd55eeffebab694ea403ffb91b67db66
>
> S = "${WORKDIR}/libusb-${PV}"
>
> -inherit autotools pkgconfig
> +inherit autotools pkgconfig ptest
>
> # Don't configure udev by default since it will cause a circular
> # dependecy with udev package, which depends on libusb
> @@ -30,6 +31,14 @@ do_install_append() {
> fi
> }
>
> +do_compile_ptest() {
> + oe_runmake -C tests stress
> +}
> +
> +do_install_ptest() {
> + install -m 755 ${WORKDIR}/build/tests/.libs/stress ${D}${PTEST_PATH}
This should use ${B} instead of ${WORKDIR}/build otherwise this will
fail when using devtool or externalsrc class or in general when
WORKDIR/build != B.
Thanks,
Anuj
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] libusb: Add ptest
2018-08-06 13:39 ` [PATCH] " Anuj Mittal
@ 2018-08-06 14:16 ` Maksym Kokhan
2018-08-06 16:52 ` Burton, Ross
0 siblings, 1 reply; 7+ messages in thread
From: Maksym Kokhan @ 2018-08-06 14:16 UTC (permalink / raw)
To: openembedded-core; +Cc: Ruslan Bilovol, Andrii Bordunov, Maksym Kokhan
The run-ptest script was added to run existing libusb1 tests and libusb1
recipe was changed to add ptest support to that package.
Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
Reviewed-by: Andrii Bordunov <andrii.bordunov@globallogic.com>
---
meta/recipes-support/libusb/libusb1/run-ptest | 15 +++++++++++++++
meta/recipes-support/libusb/libusb1_1.0.21.bb | 11 ++++++++++-
2 files changed, 25 insertions(+), 1 deletion(-)
create mode 100755 meta/recipes-support/libusb/libusb1/run-ptest
diff --git a/meta/recipes-support/libusb/libusb1/run-ptest b/meta/recipes-support/libusb/libusb1/run-ptest
new file mode 100755
index 0000000..646a966
--- /dev/null
+++ b/meta/recipes-support/libusb/libusb1/run-ptest
@@ -0,0 +1,15 @@
+#!/bin/sh
+
+echo
+echo "---------------------------- libusb1 tests ---------------------------"
+echo
+
+./stress | tr '\n' ' ' | \
+sed 's/Starting test run: \([a-zA-Z_]*\)\.\.\. \([a-zA-Z_]*\) (.) /\2 \1\n/g' | \
+sed '$d' | \
+sed '{
+ s/^Success/PASS:/g
+ s/^Failure/FAIL:/g
+ s/^Error/FAIL:/g
+ s/^Skip/SKIP:/g
+}'
diff --git a/meta/recipes-support/libusb/libusb1_1.0.21.bb b/meta/recipes-support/libusb/libusb1_1.0.21.bb
index 1fefd14..56822a6 100644
--- a/meta/recipes-support/libusb/libusb1_1.0.21.bb
+++ b/meta/recipes-support/libusb/libusb1_1.0.21.bb
@@ -10,6 +10,7 @@ BBCLASSEXTEND = "native nativesdk"
SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
file://no-dll.patch \
+ file://run-ptest \
"
SRC_URI[md5sum] = "1da9ea3c27b3858fa85c5f4466003e44"
@@ -17,7 +18,7 @@ SRC_URI[sha256sum] = "7dce9cce9a81194b7065ee912bcd55eeffebab694ea403ffb91b67db66
S = "${WORKDIR}/libusb-${PV}"
-inherit autotools pkgconfig
+inherit autotools pkgconfig ptest
# Don't configure udev by default since it will cause a circular
# dependecy with udev package, which depends on libusb
@@ -30,6 +31,14 @@ do_install_append() {
fi
}
+do_compile_ptest() {
+ oe_runmake -C tests stress
+}
+
+do_install_ptest() {
+ install -m 755 ${B}/tests/.libs/stress ${D}${PTEST_PATH}
+}
+
FILES_${PN} += "${base_libdir}/*.so.*"
FILES_${PN}-dev += "${base_libdir}/*.so ${base_libdir}/*.la"
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] libusb: Add ptest
2018-08-06 14:16 ` Maksym Kokhan
@ 2018-08-06 16:52 ` Burton, Ross
2018-08-07 14:28 ` Maksym Kokhan
0 siblings, 1 reply; 7+ messages in thread
From: Burton, Ross @ 2018-08-06 16:52 UTC (permalink / raw)
To: Maksym Kokhan; +Cc: Ruslan Bilovol, Andrii Bordunov, OE-core
The upgrade to libusb 1.0.22 happened in *May* so please do try and
keep up to date with master. In this case git did managed to merge
anyway, but generally that won't be true.
Ross
On 6 August 2018 at 15:16, Maksym Kokhan via Openembedded-core
<openembedded-core@lists.openembedded.org> wrote:
> The run-ptest script was added to run existing libusb1 tests and libusb1
> recipe was changed to add ptest support to that package.
>
> Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> Reviewed-by: Andrii Bordunov <andrii.bordunov@globallogic.com>
> ---
> meta/recipes-support/libusb/libusb1/run-ptest | 15 +++++++++++++++
> meta/recipes-support/libusb/libusb1_1.0.21.bb | 11 ++++++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
> create mode 100755 meta/recipes-support/libusb/libusb1/run-ptest
>
> diff --git a/meta/recipes-support/libusb/libusb1/run-ptest b/meta/recipes-support/libusb/libusb1/run-ptest
> new file mode 100755
> index 0000000..646a966
> --- /dev/null
> +++ b/meta/recipes-support/libusb/libusb1/run-ptest
> @@ -0,0 +1,15 @@
> +#!/bin/sh
> +
> +echo
> +echo "---------------------------- libusb1 tests ---------------------------"
> +echo
> +
> +./stress | tr '\n' ' ' | \
> +sed 's/Starting test run: \([a-zA-Z_]*\)\.\.\. \([a-zA-Z_]*\) (.) /\2 \1\n/g' | \
> +sed '$d' | \
> +sed '{
> + s/^Success/PASS:/g
> + s/^Failure/FAIL:/g
> + s/^Error/FAIL:/g
> + s/^Skip/SKIP:/g
> +}'
> diff --git a/meta/recipes-support/libusb/libusb1_1.0.21.bb b/meta/recipes-support/libusb/libusb1_1.0.21.bb
> index 1fefd14..56822a6 100644
> --- a/meta/recipes-support/libusb/libusb1_1.0.21.bb
> +++ b/meta/recipes-support/libusb/libusb1_1.0.21.bb
> @@ -10,6 +10,7 @@ BBCLASSEXTEND = "native nativesdk"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
> file://no-dll.patch \
> + file://run-ptest \
> "
>
> SRC_URI[md5sum] = "1da9ea3c27b3858fa85c5f4466003e44"
> @@ -17,7 +18,7 @@ SRC_URI[sha256sum] = "7dce9cce9a81194b7065ee912bcd55eeffebab694ea403ffb91b67db66
>
> S = "${WORKDIR}/libusb-${PV}"
>
> -inherit autotools pkgconfig
> +inherit autotools pkgconfig ptest
>
> # Don't configure udev by default since it will cause a circular
> # dependecy with udev package, which depends on libusb
> @@ -30,6 +31,14 @@ do_install_append() {
> fi
> }
>
> +do_compile_ptest() {
> + oe_runmake -C tests stress
> +}
> +
> +do_install_ptest() {
> + install -m 755 ${B}/tests/.libs/stress ${D}${PTEST_PATH}
> +}
> +
> FILES_${PN} += "${base_libdir}/*.so.*"
>
> FILES_${PN}-dev += "${base_libdir}/*.so ${base_libdir}/*.la"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] libusb: Add ptest
2018-08-06 16:52 ` Burton, Ross
@ 2018-08-07 14:28 ` Maksym Kokhan
0 siblings, 0 replies; 7+ messages in thread
From: Maksym Kokhan @ 2018-08-07 14:28 UTC (permalink / raw)
To: ross.burton; +Cc: Ruslan Bilovol, Andrii Bordunov, openembedded-core
On Mon, Aug 6, 2018 at 7:53 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> The upgrade to libusb 1.0.22 happened in *May* so please do try and
> keep up to date with master. In this case git did managed to merge
> anyway, but generally that won't be true.
Thank you for your reply, I fixed my mistake so now my patch is up to
date with master, and I sent the final patch v3.
Thanks,
Maksym
>
> Ross
>
> On 6 August 2018 at 15:16, Maksym Kokhan via Openembedded-core
> <openembedded-core@lists.openembedded.org> wrote:
> > The run-ptest script was added to run existing libusb1 tests and libusb1
> > recipe was changed to add ptest support to that package.
> >
> > Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> > Reviewed-by: Andrii Bordunov <andrii.bordunov@globallogic.com>
> > ---
> > meta/recipes-support/libusb/libusb1/run-ptest | 15 +++++++++++++++
> > meta/recipes-support/libusb/libusb1_1.0.21.bb | 11 ++++++++++-
> > 2 files changed, 25 insertions(+), 1 deletion(-)
> > create mode 100755 meta/recipes-support/libusb/libusb1/run-ptest
> >
> > diff --git a/meta/recipes-support/libusb/libusb1/run-ptest b/meta/recipes-support/libusb/libusb1/run-ptest
> > new file mode 100755
> > index 0000000..646a966
> > --- /dev/null
> > +++ b/meta/recipes-support/libusb/libusb1/run-ptest
> > @@ -0,0 +1,15 @@
> > +#!/bin/sh
> > +
> > +echo
> > +echo "---------------------------- libusb1 tests ---------------------------"
> > +echo
> > +
> > +./stress | tr '\n' ' ' | \
> > +sed 's/Starting test run: \([a-zA-Z_]*\)\.\.\. \([a-zA-Z_]*\) (.) /\2 \1\n/g' | \
> > +sed '$d' | \
> > +sed '{
> > + s/^Success/PASS:/g
> > + s/^Failure/FAIL:/g
> > + s/^Error/FAIL:/g
> > + s/^Skip/SKIP:/g
> > +}'
> > diff --git a/meta/recipes-support/libusb/libusb1_1.0.21.bb b/meta/recipes-support/libusb/libusb1_1.0.21.bb
> > index 1fefd14..56822a6 100644
> > --- a/meta/recipes-support/libusb/libusb1_1.0.21.bb
> > +++ b/meta/recipes-support/libusb/libusb1_1.0.21.bb
> > @@ -10,6 +10,7 @@ BBCLASSEXTEND = "native nativesdk"
> >
> > SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
> > file://no-dll.patch \
> > + file://run-ptest \
> > "
> >
> > SRC_URI[md5sum] = "1da9ea3c27b3858fa85c5f4466003e44"
> > @@ -17,7 +18,7 @@ SRC_URI[sha256sum] = "7dce9cce9a81194b7065ee912bcd55eeffebab694ea403ffb91b67db66
> >
> > S = "${WORKDIR}/libusb-${PV}"
> >
> > -inherit autotools pkgconfig
> > +inherit autotools pkgconfig ptest
> >
> > # Don't configure udev by default since it will cause a circular
> > # dependecy with udev package, which depends on libusb
> > @@ -30,6 +31,14 @@ do_install_append() {
> > fi
> > }
> >
> > +do_compile_ptest() {
> > + oe_runmake -C tests stress
> > +}
> > +
> > +do_install_ptest() {
> > + install -m 755 ${B}/tests/.libs/stress ${D}${PTEST_PATH}
> > +}
> > +
> > FILES_${PN} += "${base_libdir}/*.so.*"
> >
> > FILES_${PN}-dev += "${base_libdir}/*.so ${base_libdir}/*.la"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ patchtest: failure for libusb: Add ptest (rev2)
2018-08-06 12:08 [PATCH] libusb: Add ptest Maksym Kokhan
2018-08-06 12:32 ` ✗ patchtest: failure for " Patchwork
2018-08-06 13:39 ` [PATCH] " Anuj Mittal
@ 2018-08-06 14:32 ` Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-08-06 14:32 UTC (permalink / raw)
To: Andrii Bordunov via Openembedded-core; +Cc: openembedded-core
== Series Details ==
Series: libusb: Add ptest (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/13400/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 1c4d9f46d5)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-08-07 14:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-06 12:08 [PATCH] libusb: Add ptest Maksym Kokhan
2018-08-06 12:32 ` ✗ patchtest: failure for " Patchwork
2018-08-06 13:39 ` [PATCH] " Anuj Mittal
2018-08-06 14:16 ` Maksym Kokhan
2018-08-06 16:52 ` Burton, Ross
2018-08-07 14:28 ` Maksym Kokhan
2018-08-06 14:32 ` ✗ patchtest: failure for libusb: Add ptest (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox